diff options
author | Dan Sinclair <dsinclair@chromium.org> | 2017-11-20 20:28:53 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-20 20:28:53 +0000 |
commit | 71803d230109cb841a323c579082a5cbd6fcbe3c (patch) | |
tree | b6f777e04fec69a05a8658728e54a73a48e5f120 /xfa/fxfa/parser/cxfa_imagedata.cpp | |
parent | 03d9180f30f2ba79ef48b4003306224428f4ad47 (diff) | |
download | pdfium-71803d230109cb841a323c579082a5cbd6fcbe3c.tar.xz |
Cleanup CXFA_{ExData|Image}Data Setter returns.
This CL changes the Set methods from {ExData|Image}Data which return
bool but the return value is never used to return void instead.
Change-Id: I0b6aa40e27839ffca21fdbcd6635d5a6224377e9
Reviewed-on: https://pdfium-review.googlesource.com/18790
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fxfa/parser/cxfa_imagedata.cpp')
-rw-r--r-- | xfa/fxfa/parser/cxfa_imagedata.cpp | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/xfa/fxfa/parser/cxfa_imagedata.cpp b/xfa/fxfa/parser/cxfa_imagedata.cpp index 7888c34205..145d3586a5 100644 --- a/xfa/fxfa/parser/cxfa_imagedata.cpp +++ b/xfa/fxfa/parser/cxfa_imagedata.cpp @@ -61,23 +61,23 @@ bool CXFA_ImageData::GetContent(WideString& wsText) { return true; } -bool CXFA_ImageData::SetContentType(const WideString& wsContentType) { - return m_pNode->JSNode()->SetCData(XFA_Attribute::ContentType, wsContentType, - false, false); +void CXFA_ImageData::SetContentType(const WideString& wsContentType) { + m_pNode->JSNode()->SetCData(XFA_Attribute::ContentType, wsContentType, false, + false); } -bool CXFA_ImageData::SetHref(const WideString& wsHref) { - if (m_bDefValue) - return m_pNode->JSNode()->SetCData(XFA_Attribute::Href, wsHref, false, - false); - return m_pNode->JSNode()->SetAttribute(XFA_Attribute::Href, - wsHref.AsStringView(), false); +void CXFA_ImageData::SetHref(const WideString& wsHref) { + if (m_bDefValue) { + m_pNode->JSNode()->SetCData(XFA_Attribute::Href, wsHref, false, false); + return; + } + m_pNode->JSNode()->SetAttribute(XFA_Attribute::Href, wsHref.AsStringView(), + false); } -bool CXFA_ImageData::SetTransferEncoding(XFA_ATTRIBUTEENUM iTransferEncoding) { +void CXFA_ImageData::SetTransferEncoding(XFA_ATTRIBUTEENUM iTransferEncoding) { if (m_bDefValue) { - return m_pNode->JSNode()->SetEnum(XFA_Attribute::TransferEncoding, - iTransferEncoding, false); + m_pNode->JSNode()->SetEnum(XFA_Attribute::TransferEncoding, + iTransferEncoding, false); } - return true; } |