diff options
| author | Lei Zhang <thestig@chromium.org> | 2017-05-22 17:05:40 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-05-23 00:18:13 +0000 |
| commit | b45324bfb414acc595e478dc7dc63ac43c792580 (patch) | |
| tree | 90af2bb4c6386b2b2825c80d7405dace0416c69b /xfa/fxfa/parser/cxfa_node.cpp | |
| parent | 4cb82ee95256f110489f2b503e70729c44419e74 (diff) | |
| download | pdfium-b45324bfb414acc595e478dc7dc63ac43c792580.tar.xz | |
Use NOTREACHED() in more places.
Change-Id: I88466943171f19259f84add69679741d44c8e123
Reviewed-on: https://pdfium-review.googlesource.com/5551
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'xfa/fxfa/parser/cxfa_node.cpp')
| -rw-r--r-- | xfa/fxfa/parser/cxfa_node.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/xfa/fxfa/parser/cxfa_node.cpp b/xfa/fxfa/parser/cxfa_node.cpp index 8830f3412c..3c254ef6fc 100644 --- a/xfa/fxfa/parser/cxfa_node.cpp +++ b/xfa/fxfa/parser/cxfa_node.cpp @@ -20,6 +20,7 @@ #include "core/fxcrt/xml/cfx_xmlnode.h" #include "core/fxcrt/xml/cfx_xmltext.h" #include "fxjs/cfxjse_value.h" +#include "third_party/base/logging.h" #include "third_party/base/ptr_util.h" #include "third_party/base/stl_util.h" #include "xfa/fxfa/app/xfa_ffnotify.h" @@ -3174,7 +3175,7 @@ int32_t CXFA_Node::InstanceManager_SetInstances(int32_t iDesired) { continue; } if (pRemoveInstance->GetElementType() == XFA_Element::InstanceManager) { - ASSERT(false); + NOTREACHED(); break; } if (pRemoveInstance->GetNameHash() == dInstanceNameHash) { @@ -4460,7 +4461,7 @@ int32_t CXFA_Node::InsertChild(int32_t index, CXFA_Node* pNode) { bool CXFA_Node::InsertChild(CXFA_Node* pNode, CXFA_Node* pBeforeNode) { if (!pNode || pNode->m_pParent || (pBeforeNode && pBeforeNode->m_pParent != this)) { - ASSERT(false); + NOTREACHED(); return false; } bool ret = m_pDocument->RemovePurgeNode(pNode); @@ -4519,7 +4520,7 @@ CXFA_Node* CXFA_Node::Deprecated_GetPrevSibling() { bool CXFA_Node::RemoveChild(CXFA_Node* pNode, bool bNotify) { if (!pNode || pNode->m_pParent != this) { - ASSERT(false); + NOTREACHED(); return false; } if (m_pChild == pNode) { |