diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2018-02-14 16:20:01 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-14 16:20:01 +0000 |
| commit | 2fa6441d686e1205eb25ed2cbfc4cf47d96efec6 (patch) | |
| tree | ad5ebfd6bb73d0db5c5b81b61597c7b0f18f9a0f /xfa/fxfa/parser/cxfa_node.h | |
| parent | d8d6f55140bd4f0a67de833346113cfa6e03c4bd (diff) | |
| download | pdfium-2fa6441d686e1205eb25ed2cbfc4cf47d96efec6.tar.xz | |
Cleanup CXFA_Node::SetFlag
The SetFlag method has a signature of (flag, bool) which, looking at the
callsites makes you think it will set the flag to the boolean. This
isn't what happens, the flag is always set to true and the boolean
decides if we execute some notification code.
This CL splits SetFlag into SetFlag(flag) and SetFlagAndNotify(flag) to
make it a lot clearer what is happening.
Change-Id: I3e067c87532cce10b94bda10cc88feb62b948eb0
Reviewed-on: https://pdfium-review.googlesource.com/26750
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fxfa/parser/cxfa_node.h')
| -rw-r--r-- | xfa/fxfa/parser/cxfa_node.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xfa/fxfa/parser/cxfa_node.h b/xfa/fxfa/parser/cxfa_node.h index f5eb2be77e..f34bd9bfba 100644 --- a/xfa/fxfa/parser/cxfa_node.h +++ b/xfa/fxfa/parser/cxfa_node.h @@ -115,7 +115,8 @@ class CXFA_Node : public CXFA_Object { XFA_PacketType GetPacketType() const { return m_ePacket; } - void SetFlag(uint32_t dwFlag, bool bNotify); + void SetFlag(uint32_t dwFlag); + void SetFlagAndNotify(uint32_t dwFlag); void ClearFlag(uint32_t dwFlag); CXFA_Node* CreateInstanceIfPossible(bool bDataMerge); |