summaryrefslogtreecommitdiff
path: root/xfa/fxfa/parser/cxfa_node.h
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2018-08-20 19:14:17 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-08-20 19:14:17 +0000
commit4be873b32a85f475fa2b377371f859857e8f2b0e (patch)
tree0604c7b40ba7d4ebac4c119ff6e5fd532b45eb92 /xfa/fxfa/parser/cxfa_node.h
parent9273e0674ecf87929696ca89cbf16371edabc315 (diff)
downloadpdfium-4be873b32a85f475fa2b377371f859857e8f2b0e.tar.xz
Fix nits in CXFA_Node.
- Make methods const or move them into the anonymous namespace. - Make GetItemLabel() return the value. Change-Id: Ic6938d14e7efa09f1851950c28d3c855690d9aaf Reviewed-on: https://pdfium-review.googlesource.com/40650 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Diffstat (limited to 'xfa/fxfa/parser/cxfa_node.h')
-rw-r--r--xfa/fxfa/parser/cxfa_node.h7
1 files changed, 3 insertions, 4 deletions
diff --git a/xfa/fxfa/parser/cxfa_node.h b/xfa/fxfa/parser/cxfa_node.h
index 99930c6686..72e2a4eb4a 100644
--- a/xfa/fxfa/parser/cxfa_node.h
+++ b/xfa/fxfa/parser/cxfa_node.h
@@ -450,8 +450,8 @@ class CXFA_Node : public CXFA_Object {
bool CalculateImageAutoSize(CXFA_FFDoc* doc, CFX_SizeF* pSize);
float CalculateWidgetAutoHeight(float fHeightCalc);
float CalculateWidgetAutoWidth(float fWidthCalc);
- float GetWidthWithoutMargin(float fWidthCalc);
- float GetHeightWithoutMargin(float fHeightCalc);
+ float GetWidthWithoutMargin(float fWidthCalc) const;
+ float GetHeightWithoutMargin(float fHeightCalc) const;
void CalculateTextContentSize(CXFA_FFDoc* doc, CFX_SizeF* pSize);
CFX_SizeF CalculateAccWidthAndHeight(CXFA_FFDoc* doc, float fWidth);
void InitLayoutData();
@@ -460,8 +460,7 @@ class CXFA_Node : public CXFA_Object {
void InsertListTextItem(CXFA_Node* pItems,
const WideString& wsText,
int32_t nIndex);
- WideString FormatNumStr(const WideString& wsValue, LocaleIface* pLocale);
- void GetItemLabel(const WideStringView& wsValue, WideString& wsLabel);
+ WideString GetItemLabel(const WideStringView& wsValue) const;
std::pair<XFA_FFWidgetType, CXFA_Ui*> CreateChildUIAndValueNodesIfNeeded();
void CreateValueNodeIfNeeded(CXFA_Value* value, CXFA_Node* pUIChild);