diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-11-22 22:04:12 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-22 22:04:12 +0000 |
| commit | 9d0d36b7f3e2106bbeb332edf821fc2c637e6ea0 (patch) | |
| tree | 6d1a17b202cdb73956e768c56c1316c0d163effb /xfa/fxfa/parser/cxfa_validatedata.h | |
| parent | a1c4205eff6c8a0bb6a6abf58bbec06cb0fe22c5 (diff) | |
| download | pdfium-9d0d36b7f3e2106bbeb332edf821fc2c637e6ea0.tar.xz | |
Cleanup CXFA_ValidateData
This CL removes out-params in favour of returns; Makes params const;
Cleans up return types.
Change-Id: I2b7c237130a99859b08af0486a95b4c6f6974f62
Reviewed-on: https://pdfium-review.googlesource.com/19130
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fxfa/parser/cxfa_validatedata.h')
| -rw-r--r-- | xfa/fxfa/parser/cxfa_validatedata.h | 34 |
1 files changed, 20 insertions, 14 deletions
diff --git a/xfa/fxfa/parser/cxfa_validatedata.h b/xfa/fxfa/parser/cxfa_validatedata.h index a431cbdf20..e18fcadeaf 100644 --- a/xfa/fxfa/parser/cxfa_validatedata.h +++ b/xfa/fxfa/parser/cxfa_validatedata.h @@ -18,22 +18,28 @@ class CXFA_ValidateData : public CXFA_DataData { public: explicit CXFA_ValidateData(CXFA_Node* pNode); - int32_t GetFormatTest(); - int32_t GetNullTest(); - bool SetNullTest(WideString wsValue); - int32_t GetScriptTest(); - void GetFormatMessageText(WideString& wsMessage); - void SetFormatMessageText(WideString wsMessage); - void GetNullMessageText(WideString& wsMessage); - void SetNullMessageText(WideString wsMessage); - void GetScriptMessageText(WideString& wsMessage); - void SetScriptMessageText(WideString wsMessage); - void GetPicture(WideString& wsPicture); - CXFA_ScriptData GetScriptData(); + XFA_ATTRIBUTEENUM GetFormatTest() const; + WideString GetFormatMessageText() const; + void SetFormatMessageText(const WideString& wsMessage); + + XFA_ATTRIBUTEENUM GetNullTest() const; + void SetNullTest(const WideString& wsValue); + + WideString GetNullMessageText() const; + void SetNullMessageText(const WideString& wsMessage); + + XFA_ATTRIBUTEENUM GetScriptTest() const; + WideString GetScriptMessageText() const; + void SetScriptMessageText(const WideString& wsMessage); + + WideString GetPicture() const; + + CXFA_ScriptData GetScriptData() const; private: - void GetMessageText(WideString& wsMessage, const WideString& wsMessageType); - void SetMessageText(WideString& wsMessage, const WideString& wsMessageType); + WideString GetMessageText(const WideString& wsMessageType) const; + void SetMessageText(const WideString& wsMessageType, + const WideString& wsMessage); }; #endif // XFA_FXFA_PARSER_CXFA_VALIDATEDATA_H_ |