diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-11-22 22:09:42 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-22 22:09:42 +0000 |
| commit | fd16e44aa9b0e63e6d25254a3b812fb27152b6f4 (patch) | |
| tree | 92092b4cc86a05f90518b63c4f884566380bfd92 /xfa/fxfa/parser/xfa_document_datamerger_imp.cpp | |
| parent | 9d0d36b7f3e2106bbeb332edf821fc2c637e6ea0 (diff) | |
| download | pdfium-fd16e44aa9b0e63e6d25254a3b812fb27152b6f4.tar.xz | |
Cleanup CXFA_ValueData
This CL makes the methods const and uses return values instead of
out-params.
Change-Id: If760cd8c10d8f3a94dd3e13c46200cb6738a4d5a
Reviewed-on: https://pdfium-review.googlesource.com/19150
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Diffstat (limited to 'xfa/fxfa/parser/xfa_document_datamerger_imp.cpp')
| -rw-r--r-- | xfa/fxfa/parser/xfa_document_datamerger_imp.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/xfa/fxfa/parser/xfa_document_datamerger_imp.cpp b/xfa/fxfa/parser/xfa_document_datamerger_imp.cpp index 381e176927..2a3494f276 100644 --- a/xfa/fxfa/parser/xfa_document_datamerger_imp.cpp +++ b/xfa/fxfa/parser/xfa_document_datamerger_imp.cpp @@ -152,7 +152,7 @@ void CreateDataBinding(CXFA_Node* pFormNode, break; } case XFA_Element::ChoiceList: - defValueData.GetChildValueContent(wsValue); + wsValue = defValueData.GetChildValueContent(); if (pWidgetData->GetChoiceListOpen() == XFA_ATTRIBUTEENUM_MultiSelect) { std::vector<WideString> wsSelTextArray = pWidgetData->GetSelectedItemsValue(); @@ -180,7 +180,7 @@ void CreateDataBinding(CXFA_Node* pFormNode, } break; case XFA_Element::CheckButton: - defValueData.GetChildValueContent(wsValue); + wsValue = defValueData.GetChildValueContent(); if (wsValue.IsEmpty()) break; @@ -199,7 +199,7 @@ void CreateDataBinding(CXFA_Node* pFormNode, if (!pValue) continue; - CXFA_ValueData(pValue).GetChildValueContent(wsValue); + wsValue = CXFA_ValueData(pValue).GetChildValueContent(); if (wsValue.IsEmpty()) continue; @@ -249,7 +249,7 @@ void CreateDataBinding(CXFA_Node* pFormNode, break; } case XFA_Element::NumericEdit: { - defValueData.GetChildValueContent(wsValue); + wsValue = defValueData.GetChildValueContent(); if (wsValue.IsEmpty()) break; @@ -265,7 +265,7 @@ void CreateDataBinding(CXFA_Node* pFormNode, break; } default: - defValueData.GetChildValueContent(wsValue); + wsValue = defValueData.GetChildValueContent(); if (wsValue.IsEmpty()) break; |