Convert CXFA_BindItemsData::Get* to return strings

This CL changes the CXFA_BindItemsData to return the WideString values
instead of taking out params.

Change-Id: Ic756da02121c4ce40a123b887cc774045cbfaa8e
Reviewed-on: https://pdfium-review.googlesource.com/18811
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

2 files changed, 10 insertions, 9 deletions

diff --git a/xfa/fxfa/parser/cxfa_binditemsdata.cpp b/xfa/fxfa/parser/cxfa_binditemsdata.cpp
index 3f0614fd6f..7640314f06 100644
--- a/xfa/fxfa/parser/cxfa_binditemsdata.cpp
+++ b/xfa/fxfa/parser/cxfa_binditemsdata.cpp
@@ -11,16 +11,16 @@
 CXFA_BindItemsData::CXFA_BindItemsData(CXFA_Node* pNode)
     : CXFA_DataData(pNode) {}
 
-void CXFA_BindItemsData::GetLabelRef(WideString& wsLabelRef) {
-  wsLabelRef = m_pNode->JSNode()->GetCData(XFA_Attribute::LabelRef);
+WideString CXFA_BindItemsData::GetLabelRef() {
+  return m_pNode->JSNode()->GetCData(XFA_Attribute::LabelRef);
 }
 
-void CXFA_BindItemsData::GetValueRef(WideString& wsValueRef) {
-  wsValueRef = m_pNode->JSNode()->GetCData(XFA_Attribute::ValueRef);
+WideString CXFA_BindItemsData::GetValueRef() {
+  return m_pNode->JSNode()->GetCData(XFA_Attribute::ValueRef);
 }
 
-void CXFA_BindItemsData::GetRef(WideString& wsRef) {
-  wsRef = m_pNode->JSNode()->GetCData(XFA_Attribute::Ref);
+WideString CXFA_BindItemsData::GetRef() {
+  return m_pNode->JSNode()->GetCData(XFA_Attribute::Ref);
 }
 
 bool CXFA_BindItemsData::SetConnection(const WideString& wsConnection) {
diff --git a/xfa/fxfa/parser/cxfa_binditemsdata.h b/xfa/fxfa/parser/cxfa_binditemsdata.h
index f9b506a993..4e59fa1657 100644
--- a/xfa/fxfa/parser/cxfa_binditemsdata.h
+++ b/xfa/fxfa/parser/cxfa_binditemsdata.h
@@ -16,9 +16,10 @@ class CXFA_BindItemsData : public CXFA_DataData {
  public:
   explicit CXFA_BindItemsData(CXFA_Node* pNode);
 
-  void GetLabelRef(WideString& wsLabelRef);
-  void GetValueRef(WideString& wsValueRef);
-  void GetRef(WideString& wsRef);
+  WideString GetLabelRef();
+  WideString GetValueRef();
+  WideString GetRef();
+
   bool SetConnection(const WideString& wsConnection);
 };