diff options
author | Dan Sinclair <dsinclair@chromium.org> | 2018-01-11 16:38:31 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-01-11 16:38:31 +0000 |
commit | c7f4322f1ac8ee1604ac3e24860530994575c9af (patch) | |
tree | b0d90ac2bc06c293a6c15052141b32c19a283702 /xfa/fxfa/parser | |
parent | ce7df754b0608887a923d5083f0bbb999a735fce (diff) | |
download | pdfium-c7f4322f1ac8ee1604ac3e24860530994575c9af.tar.xz |
Rename CXFA_Calculate methods to make return clearer
This CL renames CXFA_Calculate::GetScript to make it clearer it can
return nullptr.
Change-Id: I1f5c19c16ea6cb1b3e7016ddac3f7f7fd6aa0320
Reviewed-on: https://pdfium-review.googlesource.com/22741
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fxfa/parser')
-rw-r--r-- | xfa/fxfa/parser/cxfa_calculate.cpp | 2 | ||||
-rw-r--r-- | xfa/fxfa/parser/cxfa_calculate.h | 2 | ||||
-rw-r--r-- | xfa/fxfa/parser/cxfa_node.cpp | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/xfa/fxfa/parser/cxfa_calculate.cpp b/xfa/fxfa/parser/cxfa_calculate.cpp index cacb326f0f..328678783c 100644 --- a/xfa/fxfa/parser/cxfa_calculate.cpp +++ b/xfa/fxfa/parser/cxfa_calculate.cpp @@ -49,7 +49,7 @@ XFA_AttributeEnum CXFA_Calculate::GetOverride() { .value_or(XFA_AttributeEnum::Error); } -CXFA_Script* CXFA_Calculate::GetScript() { +CXFA_Script* CXFA_Calculate::GetScriptIfExists() { return GetChild<CXFA_Script>(0, XFA_Element::Script, false); } diff --git a/xfa/fxfa/parser/cxfa_calculate.h b/xfa/fxfa/parser/cxfa_calculate.h index 3f6ca6a8c7..a5be908b4c 100644 --- a/xfa/fxfa/parser/cxfa_calculate.h +++ b/xfa/fxfa/parser/cxfa_calculate.h @@ -17,7 +17,7 @@ class CXFA_Calculate : public CXFA_Node { ~CXFA_Calculate() override; XFA_AttributeEnum GetOverride(); - CXFA_Script* GetScript(); + CXFA_Script* GetScriptIfExists(); WideString GetMessageText(); }; diff --git a/xfa/fxfa/parser/cxfa_node.cpp b/xfa/fxfa/parser/cxfa_node.cpp index 5d72cf7cb9..c7a0bb1668 100644 --- a/xfa/fxfa/parser/cxfa_node.cpp +++ b/xfa/fxfa/parser/cxfa_node.cpp @@ -1714,7 +1714,7 @@ int32_t CXFA_Node::ProcessCalculate(CXFA_FFDocView* docView) { CXFA_EventParam EventParam; EventParam.m_eType = XFA_EVENT_Calculate; - int32_t iRet = ExecuteScript(docView, calc->GetScript(), &EventParam); + int32_t iRet = ExecuteScript(docView, calc->GetScriptIfExists(), &EventParam); if (iRet != XFA_EVENTERROR_Success) return iRet; |