summaryrefslogtreecommitdiff
path: root/xfa/fxfa
diff options
context:
space:
mode:
authorDan Sinclair <dsinclair@chromium.org>2017-11-02 20:24:08 +0000
committerChromium commit bot <commit-bot@chromium.org>2017-11-02 20:24:08 +0000
commit5471335c2a70776b6734a4ee5a6732ee373c2236 (patch)
tree0203358e4debd59baacc44c4b5585286d9aba575 /xfa/fxfa
parent626c2a528fdbb53ddc6fede8ce879f56bfe87716 (diff)
downloadpdfium-5471335c2a70776b6734a4ee5a6732ee373c2236.tar.xz
Fix visibility of some CJX_Node methods
This CL fixes the visibility of several CJX_Node methods by making them private. The corresponding methods in CXFA_Node were removed as they aren't called. The OnChanged and OnChanging methods are moved to CJX_Node as they make more sense on the JS object. Change-Id: I2f791915508ec7732647de0db700c06edc4e011d Reviewed-on: https://pdfium-review.googlesource.com/17611 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'xfa/fxfa')
-rw-r--r--xfa/fxfa/parser/cxfa_node.cpp31
-rw-r--r--xfa/fxfa/parser/cxfa_node.h9
2 files changed, 0 insertions, 40 deletions
diff --git a/xfa/fxfa/parser/cxfa_node.cpp b/xfa/fxfa/parser/cxfa_node.cpp
index b2677573f5..e4fae59a4b 100644
--- a/xfa/fxfa/parser/cxfa_node.cpp
+++ b/xfa/fxfa/parser/cxfa_node.cpp
@@ -645,13 +645,6 @@ void CXFA_Node::Script_TreeClass_ResolveNodes(CFXJSE_Arguments* pArguments) {
JSNode()->Script_TreeClass_ResolveNodes(pArguments);
}
-void CXFA_Node::Script_Som_ResolveNodeList(CFXJSE_Value* pValue,
- WideString wsExpression,
- uint32_t dwFlag,
- CXFA_Node* refNode) {
- JSNode()->Script_Som_ResolveNodeList(pValue, wsExpression, dwFlag, refNode);
-}
-
void CXFA_Node::Script_TreeClass_All(CFXJSE_Value* pValue,
bool bSetting,
XFA_ATTRIBUTE eAttribute) {
@@ -825,13 +818,6 @@ void CXFA_Node::Script_Attribute_BOOLRead(CFXJSE_Value* pValue,
JSNode()->Script_Attribute_BOOLRead(pValue, bSetting, eAttribute);
}
-void CXFA_Node::Script_Attribute_SendAttributeChangeMessage(
- XFA_ATTRIBUTE eAttribute,
- bool bScriptModify) {
- JSNode()->Script_Attribute_SendAttributeChangeMessage(eAttribute,
- bScriptModify);
-}
-
void CXFA_Node::Script_Attribute_String(CFXJSE_Value* pValue,
bool bSetting,
XFA_ATTRIBUTE eAttribute) {
@@ -1738,23 +1724,6 @@ void CXFA_Node::OnRemoved(bool bNotify) {
pNotify->OnChildRemoved();
}
-void CXFA_Node::OnChanging(XFA_ATTRIBUTE eAttr, bool bNotify) {
- if (bNotify && IsInitialized()) {
- CXFA_FFNotify* pNotify = m_pDocument->GetNotify();
- if (pNotify) {
- pNotify->OnValueChanging(this, eAttr);
- }
- }
-}
-
-void CXFA_Node::OnChanged(XFA_ATTRIBUTE eAttr,
- bool bNotify,
- bool bScriptModify) {
- if (bNotify && IsInitialized()) {
- Script_Attribute_SendAttributeChangeMessage(eAttr, bScriptModify);
- }
-}
-
void CXFA_Node::UpdateNameHash() {
const XFA_NOTSUREATTRIBUTE* pNotsure =
XFA_GetNotsureAttribute(GetElementType(), XFA_ATTRIBUTE_Name);
diff --git a/xfa/fxfa/parser/cxfa_node.h b/xfa/fxfa/parser/cxfa_node.h
index e7eafe3a29..01f9b3df15 100644
--- a/xfa/fxfa/parser/cxfa_node.h
+++ b/xfa/fxfa/parser/cxfa_node.h
@@ -140,15 +140,8 @@ class CXFA_Node : public CXFA_Object {
CXFA_Node* GetOccurNode();
- void OnChanged(XFA_ATTRIBUTE eAttr, bool bNotify, bool bScriptModify);
- void OnChanging(XFA_ATTRIBUTE eAttr, bool bNotify);
-
void Script_TreeClass_ResolveNode(CFXJSE_Arguments* pArguments);
void Script_TreeClass_ResolveNodes(CFXJSE_Arguments* pArguments);
- void Script_Som_ResolveNodeList(CFXJSE_Value* pValue,
- WideString wsExpression,
- uint32_t dwFlag,
- CXFA_Node* refNode = nullptr);
void Script_TreeClass_All(CFXJSE_Value* pValue,
bool bSetting,
XFA_ATTRIBUTE eAttribute);
@@ -218,8 +211,6 @@ class CXFA_Node : public CXFA_Object {
void Script_Delta_Target(CFXJSE_Value* pValue,
bool bSetting,
XFA_ATTRIBUTE eAttribute);
- void Script_Attribute_SendAttributeChangeMessage(XFA_ATTRIBUTE eAttribute,
- bool bScriptModify);
void Script_Attribute_Integer(CFXJSE_Value* pValue,
bool bSetting,
XFA_ATTRIBUTE eAttribute);