summaryrefslogtreecommitdiff
path: root/xfa/fxfa
diff options
context:
space:
mode:
authorDan Sinclair <dsinclair@chromium.org>2017-11-02 18:15:50 +0000
committerChromium commit bot <commit-bot@chromium.org>2017-11-02 18:15:50 +0000
commit69cb91483879db27fd95e85d3d4ee7dc7093e126 (patch)
tree9bbb0d9d0d98640922f2e9e737c0d9eedb19af2d /xfa/fxfa
parent77fe069bd19ea8207664293f631c63dab330f825 (diff)
downloadpdfium-69cb91483879db27fd95e85d3d4ee7dc7093e126.tar.xz
Remove default value from CJX_Node::GetAttribute
This CL moves the default value to CJX_Node::GetAttribute to the call sites and removes the default. Change-Id: I2b875e3c612b91ca67af106e271b040cc51c56ef Reviewed-on: https://pdfium-review.googlesource.com/17470 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fxfa')
-rw-r--r--xfa/fxfa/cxfa_ffpageview.cpp2
-rw-r--r--xfa/fxfa/parser/cxfa_image.cpp2
-rw-r--r--xfa/fxfa/parser/cxfa_nodelocale.cpp2
3 files changed, 3 insertions, 3 deletions
diff --git a/xfa/fxfa/cxfa_ffpageview.cpp b/xfa/fxfa/cxfa_ffpageview.cpp
index 39115c7f5b..bd95ba916f 100644
--- a/xfa/fxfa/cxfa_ffpageview.cpp
+++ b/xfa/fxfa/cxfa_ffpageview.cpp
@@ -314,7 +314,7 @@ CXFA_FFWidget* CXFA_FFTabOrderPageWidgetIterator::GetTraverseWidget(
if (pTraverse) {
WideString wsTraverseWidgetName;
if (pTraverse->JSNode()->GetAttribute(XFA_ATTRIBUTE_Ref,
- wsTraverseWidgetName)) {
+ wsTraverseWidgetName, true)) {
return FindWidgetByName(wsTraverseWidgetName, pWidget);
}
}
diff --git a/xfa/fxfa/parser/cxfa_image.cpp b/xfa/fxfa/parser/cxfa_image.cpp
index 34072392f7..8a346e0f42 100644
--- a/xfa/fxfa/parser/cxfa_image.cpp
+++ b/xfa/fxfa/parser/cxfa_image.cpp
@@ -22,7 +22,7 @@ bool CXFA_Image::GetContentType(WideString& wsContentType) {
bool CXFA_Image::GetHref(WideString& wsHref) {
if (m_bDefValue)
return m_pNode->JSNode()->TryCData(XFA_ATTRIBUTE_Href, wsHref);
- return m_pNode->JSNode()->GetAttribute(L"href", wsHref);
+ return m_pNode->JSNode()->GetAttribute(L"href", wsHref, true);
}
int32_t CXFA_Image::GetTransferEncoding() {
diff --git a/xfa/fxfa/parser/cxfa_nodelocale.cpp b/xfa/fxfa/parser/cxfa_nodelocale.cpp
index 7aaec5aa19..5a3eb20887 100644
--- a/xfa/fxfa/parser/cxfa_nodelocale.cpp
+++ b/xfa/fxfa/parser/cxfa_nodelocale.cpp
@@ -136,7 +136,7 @@ CXFA_Node* CXFA_NodeLocale::GetNodeByName(CXFA_Node* pParent,
pParent ? pParent->GetNodeItem(XFA_NODEITEM_FirstChild) : nullptr;
while (pChild) {
WideString wsChild;
- if (pChild->JSNode()->GetAttribute(XFA_ATTRIBUTE_Name, wsChild)) {
+ if (pChild->JSNode()->GetAttribute(XFA_ATTRIBUTE_Name, wsChild, true)) {
if (wsChild == wsName)
return pChild;
}