diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-08-10 23:43:26 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-08-10 23:43:26 +0000 |
| commit | 6fdfe387645217cdd77e8e4230a0d8348d831e31 (patch) | |
| tree | 5c7e9340f3ef0a7cefdff19733a0c9fcad311cb4 /xfa/fxfa | |
| parent | 8ba9749e2f39287137a96ec5ceff2ac694566f48 (diff) | |
| download | pdfium-6fdfe387645217cdd77e8e4230a0d8348d831e31.tar.xz | |
Kill some optional parameters that are always supplied.
No need to even bring any .cpp files in line with these headers.
Change-Id: I934169d77ae09adc11f02e5ea92b1f8b078c9477
Reviewed-on: https://pdfium-review.googlesource.com/39876
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'xfa/fxfa')
| -rw-r--r-- | xfa/fxfa/cxfa_ffwidgethandler.h | 2 | ||||
| -rw-r--r-- | xfa/fxfa/fxfa.h | 12 | ||||
| -rw-r--r-- | xfa/fxfa/parser/cxfa_layoutpagemgr.h | 22 | ||||
| -rw-r--r-- | xfa/fxfa/parser/cxfa_nodehelper.h | 12 |
4 files changed, 24 insertions, 24 deletions
diff --git a/xfa/fxfa/cxfa_ffwidgethandler.h b/xfa/fxfa/cxfa_ffwidgethandler.h index f2b6ae0d1c..58e531f098 100644 --- a/xfa/fxfa/cxfa_ffwidgethandler.h +++ b/xfa/fxfa/cxfa_ffwidgethandler.h @@ -25,7 +25,7 @@ class CXFA_FFWidgetHandler { CXFA_FFWidget* CreateWidget(CXFA_FFWidget* hParent, XFA_WIDGETTYPE eType, - CXFA_FFWidget* hBefore = nullptr); + CXFA_FFWidget* hBefore); bool OnMouseEnter(CXFA_FFWidget* hWidget); bool OnMouseExit(CXFA_FFWidget* hWidget); diff --git a/xfa/fxfa/fxfa.h b/xfa/fxfa/fxfa.h index 6de20f0fbc..254d99f924 100644 --- a/xfa/fxfa/fxfa.h +++ b/xfa/fxfa/fxfa.h @@ -158,9 +158,9 @@ class IXFA_AppProvider { * user, refer to XFA_ID. */ virtual int32_t MsgBox(const WideString& wsMessage, - const WideString& wsTitle = L"", - uint32_t dwIconType = 0, - uint32_t dwButtonType = 0) = 0; + const WideString& wsTitle, + uint32_t dwIconType, + uint32_t dwButtonType) = 0; /** * Get a response from the user. @@ -171,9 +171,9 @@ class IXFA_AppProvider { * @return A string containing the user's response. */ virtual WideString Response(const WideString& wsQuestion, - const WideString& wsTitle = L"", - const WideString& wsDefaultAnswer = L"", - bool bMask = true) = 0; + const WideString& wsTitle, + const WideString& wsDefaultAnswer, + bool bMask) = 0; /** * Download something from somewhere. diff --git a/xfa/fxfa/parser/cxfa_layoutpagemgr.h b/xfa/fxfa/parser/cxfa_layoutpagemgr.h index 42fa4e6cd9..7c9055dcf8 100644 --- a/xfa/fxfa/parser/cxfa_layoutpagemgr.h +++ b/xfa/fxfa/parser/cxfa_layoutpagemgr.h @@ -45,8 +45,8 @@ class CXFA_LayoutPageMgr { bool ProcessOverflow(CXFA_Node* pFormNode, CXFA_Node*& pLeaderNode, CXFA_Node*& pTrailerNode, - bool bDataMerge = false, - bool bCreatePage = true); + bool bDataMerge, + bool bCreatePage); CXFA_Node* QueryOverflow(CXFA_Node* pFormNode); bool ProcessBookendLeaderOrTrailer(CXFA_Node* pBookendNode, bool bLeader, @@ -78,7 +78,7 @@ class CXFA_LayoutPageMgr { CXFA_Node* BreakOverflow(CXFA_Node* pOverflowNode, CXFA_Node*& pLeaderTemplate, CXFA_Node*& pTrailerTemplate, - bool bCreatePage = true); + bool bCreatePage); bool ResolveBookendLeaderOrTrailer(CXFA_Node* pBookendNode, bool bLeader, CXFA_Node*& pBookendAppendTemplate); @@ -94,16 +94,16 @@ class CXFA_LayoutPageMgr { void CreateNextMinRecord(CXFA_Node* pRecordNode); bool FindPageAreaFromPageSet(CXFA_Node* pPageSet, CXFA_Node* pStartChild, - CXFA_Node* pTargetPageArea = nullptr, - CXFA_Node* pTargetContentArea = nullptr, - bool bNewPage = false, - bool bQuery = false); + CXFA_Node* pTargetPageArea, + CXFA_Node* pTargetContentArea, + bool bNewPage, + bool bQuery); bool FindPageAreaFromPageSet_Ordered(CXFA_Node* pPageSet, CXFA_Node* pStartChild, - CXFA_Node* pTargetPageArea = nullptr, - CXFA_Node* pTargetContentArea = nullptr, - bool bNewPage = false, - bool bQuery = false); + CXFA_Node* pTargetPageArea, + CXFA_Node* pTargetContentArea, + bool bNewPage, + bool bQuery); bool FindPageAreaFromPageSet_SimplexDuplex( CXFA_Node* pPageSet, CXFA_Node* pStartChild, diff --git a/xfa/fxfa/parser/cxfa_nodehelper.h b/xfa/fxfa/parser/cxfa_nodehelper.h index b53e1f4063..49e537ccaa 100644 --- a/xfa/fxfa/parser/cxfa_nodehelper.h +++ b/xfa/fxfa/parser/cxfa_nodehelper.h @@ -25,7 +25,7 @@ class CXFA_NodeHelper { CXFA_Node* ResolveNodes_GetOneChild(CXFA_Node* parent, const wchar_t* pwsName, - bool bIsClassName = false); + bool bIsClassName); CXFA_Node* ResolveNodes_GetParent( CXFA_Node* pNode, XFA_LOGIC_TYPE eLogicType = XFA_LOGIC_NoTransparent); @@ -39,15 +39,15 @@ class CXFA_NodeHelper { int32_t NodeAcc_TraverseAnySiblings(CXFA_Node* parent, uint32_t dNameHash, std::vector<CXFA_Node*>* pSiblings, - bool bIsClassName = false); + bool bIsClassName); int32_t CountSiblings(CXFA_Node* pNode, XFA_LOGIC_TYPE eLogicType, std::vector<CXFA_Node*>* pSiblings, - bool bIsClassName = false); + bool bIsClassName); int32_t GetIndex(CXFA_Node* pNode, - XFA_LOGIC_TYPE eLogicType = XFA_LOGIC_NoTransparent, - bool bIsProperty = false, - bool bIsClassIndex = false); + XFA_LOGIC_TYPE eLogicType, + bool bIsProperty, + bool bIsClassIndex); WideString GetNameExpression( CXFA_Node* refNode, bool bIsAllPath, |