diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-10-04 23:33:30 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-04 23:33:30 +0000 |
| commit | 39cf6a765ae349242289ec3287eaf4d6c5fd57f8 (patch) | |
| tree | ec387ee09ee40a2628a27f4215cd836749644bd3 /xfa/fxfa | |
| parent | 57353fb32972af2254070bfb2f662c8add8b2efb (diff) | |
| download | pdfium-39cf6a765ae349242289ec3287eaf4d6c5fd57f8.tar.xz | |
Change |virtual ~Foo(){}| to |virtual ~Foo()=default;|chromium/3571
Otherwise code coverage flags the empty body as unreachable.
Change-Id: Iee1d9a876d68276529c70d9b8c7a28276f271767
Reviewed-on: https://pdfium-review.googlesource.com/c/43514
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'xfa/fxfa')
| -rw-r--r-- | xfa/fxfa/fm2js/cxfa_fmexpression.h | 2 | ||||
| -rw-r--r-- | xfa/fxfa/fm2js/cxfa_fmsimpleexpression.h | 2 | ||||
| -rw-r--r-- | xfa/fxfa/fxfa.h | 6 |
3 files changed, 5 insertions, 5 deletions
diff --git a/xfa/fxfa/fm2js/cxfa_fmexpression.h b/xfa/fxfa/fm2js/cxfa_fmexpression.h index c20d76b075..37999a17b3 100644 --- a/xfa/fxfa/fm2js/cxfa_fmexpression.h +++ b/xfa/fxfa/fm2js/cxfa_fmexpression.h @@ -16,7 +16,7 @@ class CFX_WideTextBuf; class CXFA_FMExpression { public: - virtual ~CXFA_FMExpression() {} + virtual ~CXFA_FMExpression() = default; virtual bool ToJavaScript(CFX_WideTextBuf* js, ReturnType type) = 0; protected: diff --git a/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.h b/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.h index 275d7d4fcb..ae8f38e6e6 100644 --- a/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.h +++ b/xfa/fxfa/fm2js/cxfa_fmsimpleexpression.h @@ -25,7 +25,7 @@ class CFX_WideTextBuf; class CXFA_FMSimpleExpression { public: - virtual ~CXFA_FMSimpleExpression() {} + virtual ~CXFA_FMSimpleExpression() = default; virtual bool ToJavaScript(CFX_WideTextBuf* js, ReturnType type) = 0; XFA_FM_TOKEN GetOperatorToken() const; diff --git a/xfa/fxfa/fxfa.h b/xfa/fxfa/fxfa.h index 5b51067c40..0796347506 100644 --- a/xfa/fxfa/fxfa.h +++ b/xfa/fxfa/fxfa.h @@ -118,7 +118,7 @@ enum XFA_WIDGETTYPE { // Probably should be called IXFA_AppDelegate. class IXFA_AppProvider { public: - virtual ~IXFA_AppProvider() {} + virtual ~IXFA_AppProvider() = default; /** * Returns the language of the running host application. Such as zh_CN @@ -221,7 +221,7 @@ class IXFA_AppProvider { class IXFA_DocEnvironment { public: - virtual ~IXFA_DocEnvironment() {} + virtual ~IXFA_DocEnvironment() = default; virtual void SetChangeMark(CXFA_FFDoc* hDoc) = 0; virtual void InvalidateRect(CXFA_FFPageView* pPageView, @@ -277,7 +277,7 @@ class IXFA_DocEnvironment { class IXFA_WidgetIterator { public: - virtual ~IXFA_WidgetIterator() {} + virtual ~IXFA_WidgetIterator() = default; virtual void Reset() = 0; virtual CXFA_FFWidget* MoveToFirst() = 0; |