summaryrefslogtreecommitdiff
path: root/xfa/fxjse/class.cpp
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2016-05-27 17:45:00 -0700
committerCommit bot <commit-bot@chromium.org>2016-05-27 17:45:00 -0700
commit3a005f22703b9303a306bf34cbd17c3729f763aa (patch)
tree9f640eaedbcbdf5b24641f33da1a110241feca82 /xfa/fxjse/class.cpp
parent2f109ab836682cb465270ed303d27955db97d98f (diff)
downloadpdfium-3a005f22703b9303a306bf34cbd17c3729f763aa.tar.xz
Workaround dubious casting between CXFA_Object and void* in FXJSE
This is just a crock to get things working until we fix the underlying issue. When there's single-inheritance, it may often work in practice to C-style (reinterpret) cast a Derived* ptr to void* and then back to a Base* ptr. One place where this blows up is if Derived has virtual functions but Base does not, in which case the world will be offset by the size of a vtable ptr. Because of the use of void* types in FXJSE, the above was happening when setting a CXFA_ThisProxy (Derived, virtual) to be a global object (void*). This would then be cast back to a CFXA_Object (Base, non-virtual) and chaos is ensured. Not sure how far back this goes. Along the way, pick up some tidying which was necessary for simplicity while tracking this down. BUG=613607 Review-Url: https://codereview.chromium.org/2015143005
Diffstat (limited to 'xfa/fxjse/class.cpp')
-rw-r--r--xfa/fxjse/class.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/xfa/fxjse/class.cpp b/xfa/fxjse/class.cpp
index dcc370306a..d49bafb986 100644
--- a/xfa/fxjse/class.cpp
+++ b/xfa/fxjse/class.cpp
@@ -9,7 +9,6 @@
#include "xfa/fxjse/cfxjse_arguments.h"
#include "xfa/fxjse/context.h"
#include "xfa/fxjse/scope_inline.h"
-#include "xfa/fxjse/util_inline.h"
#include "xfa/fxjse/value.h"
static void FXJSE_V8ConstructorCallback_Wrapper(