diff options
| author | tsepez <tsepez@chromium.org> | 2016-06-01 16:58:24 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-06-01 16:58:24 -0700 |
| commit | 4ee98cd67354a2ab26134c0688768d4aa92350a2 (patch) | |
| tree | 3b38b375a089eb0e02dfde75e0bec8871d79aec7 /xfa/fxjse/class.h | |
| parent | fb2a824f87f7096382681fd258906823ef93ebec (diff) | |
| download | pdfium-4ee98cd67354a2ab26134c0688768d4aa92350a2.tar.xz | |
Stop casting struct CFXJSE_ArgumentsImpl to unrelated class CFXJSE_Arguments
Remove the 'Impl entirely, and put the details into the class itself.
Review-Url: https://codereview.chromium.org/2036513002
Diffstat (limited to 'xfa/fxjse/class.h')
| -rw-r--r-- | xfa/fxjse/class.h | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/xfa/fxjse/class.h b/xfa/fxjse/class.h index 344adf4a47..a28d36801e 100644 --- a/xfa/fxjse/class.h +++ b/xfa/fxjse/class.h @@ -15,14 +15,6 @@ class CFXJSE_Context; class CFXJSE_Value; class CFXJSE_Class { - protected: - CFXJSE_Class(CFXJSE_Context* lpContext) - : m_lpClassDefinition(nullptr), m_pContext(lpContext) {} - - public: - inline CFXJSE_Context* GetContext() { return m_pContext; } - inline v8::Global<v8::FunctionTemplate>& GetTemplate() { return m_hTemplate; } - public: static CFXJSE_Class* Create(CFXJSE_Context* pContext, const FXJSE_CLASS_DESCRIPTOR* lpClassDefintion, @@ -34,7 +26,13 @@ class CFXJSE_Class { v8::Local<v8::ObjectTemplate>& hObjectTemplate, const FXJSE_CLASS_DESCRIPTOR* lpClassDefinition); + CFXJSE_Context* GetContext() { return m_pContext; } + v8::Global<v8::FunctionTemplate>& GetTemplate() { return m_hTemplate; } + protected: + explicit CFXJSE_Class(CFXJSE_Context* lpContext) + : m_lpClassDefinition(nullptr), m_pContext(lpContext) {} + CFX_ByteString m_szClassName; const FXJSE_CLASS_DESCRIPTOR* m_lpClassDefinition; CFXJSE_Context* m_pContext; @@ -42,9 +40,5 @@ class CFXJSE_Class { friend class CFXJSE_Context; friend class CFXJSE_Value; }; -struct CFXJSE_ArgumentsImpl { - const v8::FunctionCallbackInfo<v8::Value>* m_pInfo; - CFXJSE_Value* m_pRetValue; -}; #endif // XFA_FXJSE_CLASS_H_ |