summaryrefslogtreecommitdiff
path: root/xfa/fxjse/value.h
diff options
context:
space:
mode:
authordsinclair <dsinclair@chromium.org>2016-06-09 11:48:23 -0700
committerCommit bot <commit-bot@chromium.org>2016-06-09 11:48:23 -0700
commit2f5582f46dce2abfe9d75ea5f885a2ce0a4c10d2 (patch)
tree5e4d1dd72b8af7e887912e9f8bf764a9044eba89 /xfa/fxjse/value.h
parentbd136fb1ad8faa377bee0982ee9ef09d150ce6ca (diff)
downloadpdfium-2f5582f46dce2abfe9d75ea5f885a2ce0a4c10d2.tar.xz
Convert CFXJSE_Value::ToString to return.
ThiS Cl updates CFXJSE_Value::ToString() to return a CFX_ByteString instead of taking an out parameter. It also adds a ToStringC() and ToWideString() to hide the common conversions that are done on the string value. Review-Url: https://codereview.chromium.org/2044293004
Diffstat (limited to 'xfa/fxjse/value.h')
-rw-r--r--xfa/fxjse/value.h7
1 files changed, 5 insertions, 2 deletions
diff --git a/xfa/fxjse/value.h b/xfa/fxjse/value.h
index da4976b53c..d74fc325dd 100644
--- a/xfa/fxjse/value.h
+++ b/xfa/fxjse/value.h
@@ -172,14 +172,17 @@ class CFXJSE_Value {
v8::Local<v8::Value>::New(m_pIsolate, m_hValue);
return static_cast<int32_t>(hValue->NumberValue());
}
- V8_INLINE void ToString(CFX_ByteString& szStrOutput) const {
+ V8_INLINE CFX_ByteString ToString() const {
ASSERT(!m_hValue.IsEmpty());
CFXJSE_ScopeUtil_IsolateHandleRootContext scope(m_pIsolate);
v8::Local<v8::Value> hValue =
v8::Local<v8::Value>::New(m_pIsolate, m_hValue);
v8::Local<v8::String> hString = hValue->ToString();
v8::String::Utf8Value hStringVal(hString);
- szStrOutput = *hStringVal;
+ return CFX_ByteString(*hStringVal);
+ }
+ V8_INLINE CFX_WideString ToWideString() const {
+ return CFX_WideString::FromUTF8(ToString().AsStringC());
}
CFXJSE_HostObject* ToHostObject(CFXJSE_Class* lpClass) const;