FWL refcounts never incremented (part 2).

Re-introduce create methods that actually create the
corresponding impl so we don't have ifaces without impls.
Remove per-subclass Initialize() methods.
Remove unused ctors.

BUG=pdfium:282
R=jun_fang@foxitsoftware.com, thestig@chromium.org

Review URL: https://codereview.chromium.org/1453473002 .

1 files changed, 5 insertions, 3 deletions

diff --git a/xfa/include/fwl/basewidget/fwl_combobox.h b/xfa/include/fwl/basewidget/fwl_combobox.h
index 184d0107a4..7fa9bddc3d 100644
--- a/xfa/include/fwl/basewidget/fwl_combobox.h
+++ b/xfa/include/fwl/basewidget/fwl_combobox.h
@@ -97,9 +97,8 @@ class IFWL_ComboBoxDP : public IFWL_ListBoxDP {
 };

 class IFWL_ComboBox : public IFWL_Widget {

  public:

-  IFWL_ComboBox();

-  FWL_ERR Initialize(const CFWL_WidgetImpProperties& properties,

-                     IFWL_Widget* pOuter);

+  static IFWL_ComboBox* Create(const CFWL_WidgetImpProperties& properties);

+

   int32_t GetCurSel();

   FWL_ERR SetCurSel(int32_t iSel);

   FWL_ERR SetEditText(const CFX_WideString& wsText);

@@ -133,5 +132,8 @@ class IFWL_ComboBox : public IFWL_Widget {
   FWL_ERR GetBBox(CFX_RectF& rect);

   FWL_ERR EditModifyStylesEx(FX_DWORD dwStylesExAdded,

                              FX_DWORD dwStylesExRemoved);

+

+ protected:

+  IFWL_ComboBox();

 };

 #endif