FWL refcounts never incremented (part 2).

Re-introduce create methods that actually create the
corresponding impl so we don't have ifaces without impls.
Remove per-subclass Initialize() methods.
Remove unused ctors.

BUG=pdfium:282
R=jun_fang@foxitsoftware.com, thestig@chromium.org

Review URL: https://codereview.chromium.org/1453473002 .

1 files changed, 7 insertions, 3 deletions

diff --git a/xfa/include/fwl/basewidget/fwl_edit.h b/xfa/include/fwl/basewidget/fwl_edit.h
index 207e6ef614..da7398a2ca 100644
--- a/xfa/include/fwl/basewidget/fwl_edit.h
+++ b/xfa/include/fwl/basewidget/fwl_edit.h
@@ -112,10 +112,11 @@ class IFWL_EditDP : public IFWL_DataProvider {};
 typedef struct _FWL_HEDTFIND { void* pData; } * FWL_HEDTFIND;

 class IFWL_Edit : public IFWL_Widget {

  public:

-  IFWL_Edit();

+  static IFWL_Edit* Create(const CFWL_WidgetImpProperties& properties,

+                           IFWL_Widget* pOuter);

+  static IFWL_Edit* CreateComboEdit(const CFWL_WidgetImpProperties& properties,

+                                    IFWL_Widget* pOuter);

 

-  FWL_ERR Initialize(const CFWL_WidgetImpProperties& properties,

-                     IFWL_Widget* pOuter);

   FWL_ERR SetText(const CFX_WideString& wsText);

   int32_t GetTextLength() const;

   FWL_ERR GetText(CFX_WideString& wsText,

@@ -159,5 +160,8 @@ class IFWL_Edit : public IFWL_Widget {
   FX_BOOL GetSuggestWords(CFX_PointF pointf, CFX_ByteStringArray& sSuggest);

   FX_BOOL ReplaceSpellCheckWord(CFX_PointF pointf,

                                 const CFX_ByteStringC& bsReplace);

+

+ protected:

+  IFWL_Edit();

 };

 #endif