diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-12-09 16:16:19 -0800 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-12-09 16:16:19 -0800 |
| commit | 8ee79f8f2824d5b7058d49ebb10ced6b001c178e (patch) | |
| tree | 182737e505b0795a1a9365cc3f591df266d5a6ae /xfa/include/fwl/basewidget/fwl_listbox.h | |
| parent | b3e2d4ae6c0c9a32c4616acc71cad4751c210ae0 (diff) | |
| download | pdfium-8ee79f8f2824d5b7058d49ebb10ced6b001c178e.tar.xz | |
FWL refcounts never incremented (part 2).
Re-introduce create methods that actually create the
corresponding impl so we don't have ifaces without impls.
Remove per-subclass Initialize() methods.
Remove unused ctors.
BUG=pdfium:282
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1453473002 .
Diffstat (limited to 'xfa/include/fwl/basewidget/fwl_listbox.h')
| -rw-r--r-- | xfa/include/fwl/basewidget/fwl_listbox.h | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/xfa/include/fwl/basewidget/fwl_listbox.h b/xfa/include/fwl/basewidget/fwl_listbox.h index cc2fe91feb..1d585881d3 100644 --- a/xfa/include/fwl/basewidget/fwl_listbox.h +++ b/xfa/include/fwl/basewidget/fwl_listbox.h @@ -109,10 +109,12 @@ class IFWL_ListBoxCompare { };
class IFWL_ListBox : public IFWL_Widget {
public:
- IFWL_ListBox();
+ static IFWL_ListBox* Create(const CFWL_WidgetImpProperties& properties,
+ IFWL_Widget* pOuter);
+ static IFWL_ListBox* CreateComboList(
+ const CFWL_WidgetImpProperties& properties,
+ IFWL_Widget* pOuter);
- FWL_ERR Initialize(const CFWL_WidgetImpProperties& properties,
- IFWL_Widget* pOuter);
int32_t CountSelItems();
FWL_HLISTITEM GetSelItem(int32_t nIndexSel);
int32_t GetSelIndex(int32_t nIndex);
@@ -120,5 +122,8 @@ class IFWL_ListBox : public IFWL_Widget { FWL_ERR GetItemText(FWL_HLISTITEM hItem, CFX_WideString& wsText);
FWL_ERR GetScrollPos(FX_FLOAT& fPos, FX_BOOL bVert = TRUE);
FWL_ERR* Sort(IFWL_ListBoxCompare* pCom);
+
+ protected:
+ IFWL_ListBox();
};
#endif
|