summaryrefslogtreecommitdiff
path: root/xfa/include/fwl/basewidget/fwl_scrollbar.h
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2015-12-09 16:16:19 -0800
committerTom Sepez <tsepez@chromium.org>2015-12-09 16:16:19 -0800
commit8ee79f8f2824d5b7058d49ebb10ced6b001c178e (patch)
tree182737e505b0795a1a9365cc3f591df266d5a6ae /xfa/include/fwl/basewidget/fwl_scrollbar.h
parentb3e2d4ae6c0c9a32c4616acc71cad4751c210ae0 (diff)
downloadpdfium-8ee79f8f2824d5b7058d49ebb10ced6b001c178e.tar.xz
FWL refcounts never incremented (part 2).
Re-introduce create methods that actually create the corresponding impl so we don't have ifaces without impls. Remove per-subclass Initialize() methods. Remove unused ctors. BUG=pdfium:282 R=jun_fang@foxitsoftware.com, thestig@chromium.org Review URL: https://codereview.chromium.org/1453473002 .
Diffstat (limited to 'xfa/include/fwl/basewidget/fwl_scrollbar.h')
-rw-r--r--xfa/include/fwl/basewidget/fwl_scrollbar.h9
1 files changed, 6 insertions, 3 deletions
diff --git a/xfa/include/fwl/basewidget/fwl_scrollbar.h b/xfa/include/fwl/basewidget/fwl_scrollbar.h
index 10ce5f2688..04263a8967 100644
--- a/xfa/include/fwl/basewidget/fwl_scrollbar.h
+++ b/xfa/include/fwl/basewidget/fwl_scrollbar.h
@@ -47,9 +47,9 @@ enum FWL_SCBCODE {
class IFWL_ScrollBarDP : public IFWL_DataProvider {};
class IFWL_ScrollBar : public IFWL_Widget {
public:
- IFWL_ScrollBar();
- FWL_ERR Initialize(const CFWL_WidgetImpProperties& properties,
- IFWL_Widget* pOuter);
+ static IFWL_ScrollBar* Create(const CFWL_WidgetImpProperties& properties,
+ IFWL_Widget* pOuter);
+
FX_BOOL IsVertical();
FWL_ERR GetRange(FX_FLOAT& fMin, FX_FLOAT& fMax);
FWL_ERR SetRange(FX_FLOAT fMin, FX_FLOAT fMax);
@@ -62,5 +62,8 @@ class IFWL_ScrollBar : public IFWL_Widget {
FX_FLOAT GetTrackPos();
FWL_ERR SetTrackPos(FX_FLOAT fTrackPos);
FX_BOOL DoScroll(FX_DWORD dwCode, FX_FLOAT fPos = 0.0f);
+
+ protected:
+ IFWL_ScrollBar();
};
#endif