diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-12-08 11:20:08 -0800 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-12-08 11:20:08 -0800 |
| commit | 77221d4b4288ada80e34464ef4a402ea232b402b (patch) | |
| tree | 41b1d1d1e46fd6afd4607ed0d3fa3e6d0102caa5 /xfa/include/fwl/core/fwl_note.h | |
| parent | 4a28a7376367165404eeabdfb4274d30c2d6c040 (diff) | |
| download | pdfium-77221d4b4288ada80e34464ef4a402ea232b402b.tar.xz | |
FWL refcounts never incremented (part 1)
BUG=pdfium:282
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1509203002 .
Diffstat (limited to 'xfa/include/fwl/core/fwl_note.h')
| -rw-r--r-- | xfa/include/fwl/core/fwl_note.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/xfa/include/fwl/core/fwl_note.h b/xfa/include/fwl/core/fwl_note.h index 66366e92e4..e6579bff10 100644 --- a/xfa/include/fwl/core/fwl_note.h +++ b/xfa/include/fwl/core/fwl_note.h @@ -120,6 +120,9 @@ class IFWL_NoteLoop; #define FWL_KEYFLAG_LButton (1 << 4)
#define FWL_KEYFLAG_RButton (1 << 5)
#define FWL_KEYFLAG_MButton (1 << 6)
+
+// Separate hierarchy not related to IFWL_* hierarchy. These should not
+// get cast to IFWL_* types.
class CFWL_Note {
public:
virtual FX_DWORD Release() {
@@ -130,9 +133,9 @@ class CFWL_Note { }
return dwRefCount;
}
- virtual IFWL_Target* Retain() {
+ virtual CFWL_Note* Retain() {
m_dwRefCount++;
- return (IFWL_Target*)this;
+ return this;
}
virtual FWL_ERR GetClassName(CFX_WideString& wsClass) const {
wsClass = L"CFWL_Note";
|