FWL refcounts never incremented (part 1)

BUG=pdfium:282
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1509203002 .

1 files changed, 2 insertions, 7 deletions

diff --git a/xfa/include/fwl/core/fwl_target.h b/xfa/include/fwl/core/fwl_target.h
index bf5cf83f3a..dc10ca5399 100644
--- a/xfa/include/fwl/core/fwl_target.h
+++ b/xfa/include/fwl/core/fwl_target.h
@@ -16,7 +16,7 @@
 //      (nonesuch)              IFWL_Target ----------> CFWL_TargetImp

 //                                   |                       |

 //                                   A                       A

-//                   m_pIface         |                       |

+//                   m_pIface        |                       |

 //      CFWL_Widget ----------> IFWL_Widget             CFWL_WidgetImp

 //           |                       |                       |

 //           A                       A                       A

@@ -29,10 +29,8 @@ class CFWL_TargetImp;
 class IFWL_Target {

  public:

   IFWL_Target() : m_pImpl(nullptr) {}

+  virtual ~IFWL_Target();

 

-  FX_DWORD Release();

-  IFWL_Target* Retain();

-  FX_DWORD GetRefCount() const;

   FWL_ERR GetClassName(CFX_WideString& wsClass) const;

   FX_DWORD GetClassID() const;

   FX_BOOL IsInstance(const CFX_WideStringC& wsClass) const;

@@ -42,9 +40,6 @@ class IFWL_Target {
   CFWL_TargetImp* GetImpl() const { return m_pImpl; }

   void SetImpl(CFWL_TargetImp* pImpl) { m_pImpl = pImpl; }

 

- protected:

-  virtual ~IFWL_Target();

-

  private:

   CFWL_TargetImp* m_pImpl;

 };