diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-11-18 15:55:21 -0800 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-11-18 15:55:21 -0800 |
| commit | 3fc8c688374fc8f34f4b02debc5888e2775df91b (patch) | |
| tree | 7aae7dd9c916fb906ea3c495d9a8ad96f927b81f /xfa/include/fwl/core | |
| parent | 30035f410d7f533a53d669d73aaf03ae9ae27752 (diff) | |
| download | pdfium-3fc8c688374fc8f34f4b02debc5888e2775df91b.tar.xz | |
Make IFWL_Target::m_pImpl a private member.
Remove pointless subclass dtors since CFWL_TargetImpl
has a virtual dtor, and can be deleted by the base
class.
Kept pointless subclass ctors for the moment to hopefully
combine with Initialize someday, though they need not do
anything since the base class ctor nulls out m_pImpl.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1460883002 .
Diffstat (limited to 'xfa/include/fwl/core')
| -rw-r--r-- | xfa/include/fwl/core/fwl_content.h | 1 | ||||
| -rw-r--r-- | xfa/include/fwl/core/fwl_form.h | 1 | ||||
| -rw-r--r-- | xfa/include/fwl/core/fwl_grid.h | 1 | ||||
| -rw-r--r-- | xfa/include/fwl/core/fwl_panel.h | 2 | ||||
| -rw-r--r-- | xfa/include/fwl/core/fwl_target.h | 2 | ||||
| -rw-r--r-- | xfa/include/fwl/core/fwl_widget.h | 1 |
6 files changed, 2 insertions, 6 deletions
diff --git a/xfa/include/fwl/core/fwl_content.h b/xfa/include/fwl/core/fwl_content.h index 41b1af93b5..8669340343 100644 --- a/xfa/include/fwl/core/fwl_content.h +++ b/xfa/include/fwl/core/fwl_content.h @@ -22,6 +22,5 @@ class IFWL_Content : public IFWL_Widget { protected:
IFWL_Content();
- virtual ~IFWL_Content();
};
#endif
diff --git a/xfa/include/fwl/core/fwl_form.h b/xfa/include/fwl/core/fwl_form.h index 81c06c0591..b06d5742e9 100644 --- a/xfa/include/fwl/core/fwl_form.h +++ b/xfa/include/fwl/core/fwl_form.h @@ -81,6 +81,5 @@ class IFWL_Form : public IFWL_Panel { protected:
IFWL_Form();
- virtual ~IFWL_Form();
};
#endif
diff --git a/xfa/include/fwl/core/fwl_grid.h b/xfa/include/fwl/core/fwl_grid.h index fc97c9a841..7126024ba7 100644 --- a/xfa/include/fwl/core/fwl_grid.h +++ b/xfa/include/fwl/core/fwl_grid.h @@ -82,6 +82,5 @@ class IFWL_Grid : public IFWL_Content { protected:
IFWL_Grid();
- virtual ~IFWL_Grid();
};
#endif
diff --git a/xfa/include/fwl/core/fwl_panel.h b/xfa/include/fwl/core/fwl_panel.h index b2aa6f4799..51d1249d56 100644 --- a/xfa/include/fwl/core/fwl_panel.h +++ b/xfa/include/fwl/core/fwl_panel.h @@ -23,7 +23,6 @@ class IFWL_Panel : public IFWL_Widget { protected:
IFWL_Panel();
- virtual ~IFWL_Panel();
};
class IFWL_CustomPanel : public IFWL_Widget {
public:
@@ -37,6 +36,5 @@ class IFWL_CustomPanel : public IFWL_Widget { protected:
IFWL_CustomPanel();
- virtual ~IFWL_CustomPanel();
};
#endif
diff --git a/xfa/include/fwl/core/fwl_target.h b/xfa/include/fwl/core/fwl_target.h index 363ce30562..bf5cf83f3a 100644 --- a/xfa/include/fwl/core/fwl_target.h +++ b/xfa/include/fwl/core/fwl_target.h @@ -44,6 +44,8 @@ class IFWL_Target { protected:
virtual ~IFWL_Target();
+
+ private:
CFWL_TargetImp* m_pImpl;
};
diff --git a/xfa/include/fwl/core/fwl_widget.h b/xfa/include/fwl/core/fwl_widget.h index 10808bcac5..4a9c794d28 100644 --- a/xfa/include/fwl/core/fwl_widget.h +++ b/xfa/include/fwl/core/fwl_widget.h @@ -101,7 +101,6 @@ class IFWL_Custom : public IFWL_Widget { protected:
IFWL_Custom();
- virtual ~IFWL_Custom();
};
class IFWL_Proxy {
public:
|