diff options
| author | Tom Sepez <tsepez@chromium.org> | 2016-02-26 14:31:56 -0800 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2016-02-26 14:31:56 -0800 |
| commit | 007e6c0f9559412788b903bcb6a7601e220c3be8 (patch) | |
| tree | a2c6bb85eaa2b63fd24ed70fd3c6ddad54e219d5 /xfa/include/fxfa/fxfa_objectacc.h | |
| parent | 281a9eadff15b167e2ee3032e21b83190ad49125 (diff) | |
| download | pdfium-007e6c0f9559412788b903bcb6a7601e220c3be8.tar.xz | |
Remove some FX_BOOLs
Grepping for FX_BOOL and |==| on the same line gives
a very strong clue that the expression won't be out
of range of the |bool| type iteself.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1736323003 .
Diffstat (limited to 'xfa/include/fxfa/fxfa_objectacc.h')
| -rw-r--r-- | xfa/include/fxfa/fxfa_objectacc.h | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/xfa/include/fxfa/fxfa_objectacc.h b/xfa/include/fxfa/fxfa_objectacc.h index b471b5707b..f5cc5abf35 100644 --- a/xfa/include/fxfa/fxfa_objectacc.h +++ b/xfa/include/fxfa/fxfa_objectacc.h @@ -458,13 +458,10 @@ class CXFA_Stroke : public CXFA_Data { public: explicit CXFA_Stroke(CXFA_Node* pNode) : CXFA_Data(pNode) {} - FX_BOOL IsCorner() const { return GetClassID() == XFA_ELEMENT_Corner; } - FX_BOOL IsEdge() const { return GetClassID() == XFA_ELEMENT_Edge; } + bool IsCorner() const { return GetClassID() == XFA_ELEMENT_Corner; } + bool IsEdge() const { return GetClassID() == XFA_ELEMENT_Edge; } + bool IsVisible() const { return GetPresence() == XFA_ATTRIBUTEENUM_Visible; } int32_t GetPresence() const; - FX_BOOL IsVisible() const { - return GetPresence() == XFA_ATTRIBUTEENUM_Visible; - } - int32_t GetCapType() const; int32_t GetStrokeType() const; FX_FLOAT GetThickness() const; @@ -497,9 +494,9 @@ class CXFA_Box : public CXFA_Data { public: explicit CXFA_Box(CXFA_Node* pNode) : CXFA_Data(pNode) {} - FX_BOOL IsArc() const { return GetClassID() == XFA_ELEMENT_Arc; } - FX_BOOL IsBorder() const { return GetClassID() == XFA_ELEMENT_Border; } - FX_BOOL IsRectangle() const { return GetClassID() == XFA_ELEMENT_Rectangle; } + bool IsArc() const { return GetClassID() == XFA_ELEMENT_Arc; } + bool IsBorder() const { return GetClassID() == XFA_ELEMENT_Border; } + bool IsRectangle() const { return GetClassID() == XFA_ELEMENT_Rectangle; } int32_t GetBreak() const; int32_t GetHand() const; int32_t GetPresence() const; |