diff options
| author | Tom Sepez <tsepez@chromium.org> | 2016-03-09 13:24:25 -0800 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2016-03-09 13:24:25 -0800 |
| commit | 4f6fdbe6adf0d90886b9deb5666996603cf1207c (patch) | |
| tree | 4fee37f0d6711efbfdebbb72e0ba1746c95ad05e /xfa/src/fde/fde_iterator.h | |
| parent | 2e95951e06bd4d11459fb257c7c2b8fc881854e8 (diff) | |
| download | pdfium-4f6fdbe6adf0d90886b9deb5666996603cf1207c.tar.xz | |
Structs shouldn't inherit from CFX_Target.
There are some assumptions in the code that CAPS_NAMED
structs are POD, and can be memcpy'd, malloc'd, etc.
CFX_Target adds a virtual dtor, which is not what is
desired for many of these, so resolve by making each
a CAPS_Named class or by removing the inheritence.
In the process XFA_TextPiece was found to be malloc'd
despite having a ctor. Move this to |new|, noting that
the object is never freed (and goes out of existence
when the allocator's pool is destroyed).
BUG=pdfium:432
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1780753002 .
Diffstat (limited to 'xfa/src/fde/fde_iterator.h')
| -rw-r--r-- | xfa/src/fde/fde_iterator.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xfa/src/fde/fde_iterator.h b/xfa/src/fde/fde_iterator.h index eadff97508..2bb4c1a19f 100644 --- a/xfa/src/fde/fde_iterator.h +++ b/xfa/src/fde/fde_iterator.h @@ -10,7 +10,7 @@ #include "xfa/src/fde/fde_visualset.h" #include "xfa/src/fgas/crt/fgas_memory.h" -struct FDE_CANVASITEM : public CFX_Target { +struct FDE_CANVASITEM { IFDE_CanvasSet* pCanvas; FDE_HVISUALOBJ hCanvas; FX_POSITION hPos; |