Fix -Wnon-virtual-dtor warnings on the XFA branch.

R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1183483003.

4 files changed, 9 insertions, 1 deletions

diff --git a/xfa/src/fee/include/fx_wordbreak.h b/xfa/src/fee/include/fx_wordbreak.h
index 275930a8b7..5dc0b1b73b 100644
--- a/xfa/src/fee/include/fx_wordbreak.h
+++ b/xfa/src/fee/include/fx_wordbreak.h
@@ -7,9 +7,11 @@
 #ifndef _FX_WORDBREAK_H

 #define _FX_WORDBREAK_H

 class IFX_CharIter;

+

 class IFX_WordBreak

 {

 public:

+    virtual ~IFX_WordBreak() {}

     virtual void		Release() = 0;

     virtual void		Attach(IFX_CharIter * pIter) = 0;

     virtual void		Attach(const CFX_WideString & wsText) = 0;

diff --git a/xfa/src/fee/include/ifde_txtedtbuf.h b/xfa/src/fee/include/ifde_txtedtbuf.h
index 3aa24ffe69..b0706337c8 100644
--- a/xfa/src/fee/include/ifde_txtedtbuf.h
+++ b/xfa/src/fee/include/ifde_txtedtbuf.h
@@ -7,10 +7,11 @@
 #ifndef _IFDE_TXTEDTBUF_H

 #define _IFDE_TXTEDTBUF_H

 #define FDE_DEFCHUNKLENGTH	(1024)

-class IFDE_TxtEdtBuf;

+

 class IFDE_TxtEdtBuf

 {

 public:

+    virtual ~IFDE_TxtEdtBuf() {}

     virtual void		Release() = 0;

 

     virtual FX_BOOL		SetChunkSize(int32_t nChunkSize) = 0;

diff --git a/xfa/src/fee/include/ifde_txtedtengine.h b/xfa/src/fee/include/ifde_txtedtengine.h
index 0ee175380e..d11a1e9db1 100644
--- a/xfa/src/fee/include/ifde_txtedtengine.h
+++ b/xfa/src/fee/include/ifde_txtedtengine.h
@@ -140,6 +140,7 @@ typedef _FDE_TXTEDT_TEXTCHANGE_INFO*	FDE_LPTXTEDT_TEXTCHANGE_INFO;
 class IFDE_TxtEdtEventSink

 {

 public:

+    virtual ~IFDE_TxtEdtEventSink() {}

     virtual void	On_CaretChanged(IFDE_TxtEdtEngine * pEdit, int32_t nPage, FX_BOOL bVisible = TRUE) = 0;

     virtual void	On_TextChanged(IFDE_TxtEdtEngine * pEdit, FDE_TXTEDT_TEXTCHANGE_INFO &ChangeInfo) = 0;

     virtual void	On_PageCountChanged(IFDE_TxtEdtEngine * pEdit) = 0;

@@ -157,6 +158,7 @@ public:
 class IFX_CharIter

 {

 public:

+    virtual ~IFX_CharIter() {}

     virtual void		Release() = 0;

     virtual FX_BOOL		Next(FX_BOOL bPrev = FALSE) = 0;

     virtual FX_WCHAR	GetChar() = 0;

@@ -170,6 +172,7 @@ class IFDE_TxtEdtEngine
 public:

     static IFDE_TxtEdtEngine*		Create();

 

+    virtual ~IFDE_TxtEdtEngine() {}

     virtual void					Release() = 0;

     virtual void					SetEditParams(const FDE_TXTEDTPARAMS &params) = 0;

     virtual const FDE_TXTEDTPARAMS* GetEditParams() const = 0;

@@ -225,6 +228,7 @@ public:
 class IFDE_TxtEdtParag

 {

 public:

+    virtual ~IFDE_TxtEdtParag() {}

     virtual int32_t			GetTextLength() const = 0;

     virtual	int32_t			GetStartIndex() const = 0;

     virtual int32_t			CountLines() const = 0;

diff --git a/xfa/src/fee/src/fee/fde_txtedtengine.h b/xfa/src/fee/src/fee/fde_txtedtengine.h
index c482f5b52c..f039f1a72b 100644
--- a/xfa/src/fee/src/fee/fde_txtedtengine.h
+++ b/xfa/src/fee/src/fee/fde_txtedtengine.h
@@ -30,6 +30,7 @@ class IFDE_TxtEdtDoRecord
 {

 public:

     static IFDE_TxtEdtDoRecord * Create(const CFX_ByteStringC& bsDoRecord);

+    virtual ~IFDE_TxtEdtDoRecord() {}

     virtual void	Release() = 0;

     virtual FX_BOOL Redo() = 0;

     virtual FX_BOOL Undo() = 0;