diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-12-02 12:51:14 -0800 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-12-02 12:51:14 -0800 |
| commit | 9263e71cb259ab372d32722ee64e1a183b4b6088 (patch) | |
| tree | c0c54c523688119454e44a6e303596f4b9b300a9 /xfa/src/fwl/src/lightwidget/picturebox.cpp | |
| parent | 8677d53e8730efc20c80a1ad75be4e10a9db21d0 (diff) | |
| download | pdfium-9263e71cb259ab372d32722ee64e1a183b4b6088.tar.xz | |
Remove _FWL_RETURN_IF_ macros
These hide early returns from the casual reader, hide
the inversion of the condition under test from the reader,
prevent the folding of conditions into a single statement,
and take up more characters than the if() itself.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1494683002 .
Diffstat (limited to 'xfa/src/fwl/src/lightwidget/picturebox.cpp')
| -rw-r--r-- | xfa/src/fwl/src/lightwidget/picturebox.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xfa/src/fwl/src/lightwidget/picturebox.cpp b/xfa/src/fwl/src/lightwidget/picturebox.cpp index 4bc8a68d3b..5ccefa9076 100644 --- a/xfa/src/fwl/src/lightwidget/picturebox.cpp +++ b/xfa/src/fwl/src/lightwidget/picturebox.cpp @@ -9,7 +9,8 @@ CFWL_PictureBox* CFWL_PictureBox::Create() { return new CFWL_PictureBox;
}
FWL_ERR CFWL_PictureBox::Initialize(const CFWL_WidgetProperties* pProperties) {
- _FWL_RETURN_VALUE_IF_FAIL(!m_pIface, FWL_ERR_Indefinite);
+ if (m_pIface)
+ return FWL_ERR_Indefinite;
if (pProperties) {
*m_pProperties = *pProperties;
}
|