diff options
author | Tom Sepez <tsepez@chromium.org> | 2015-12-09 11:56:39 -0800 |
---|---|---|
committer | Tom Sepez <tsepez@chromium.org> | 2015-12-09 11:56:39 -0800 |
commit | df685030b73074e46d7eb789e13135c52775091f (patch) | |
tree | cfc7c0023d0f4e088876c991a3e37ec50e081285 /xfa/src/fwl/src | |
parent | 0f05b1c9c19e9f45135bb3dd21044b2e69fe086a (diff) | |
download | pdfium-df685030b73074e46d7eb789e13135c52775091f.tar.xz |
Re-land "Rename CFWL_Thread classes to ThreadImp"
This reverts commit 5e4f290e939ded90a518ff8eab1db59930655e11.
BUG=
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1502063005 .
Diffstat (limited to 'xfa/src/fwl/src')
-rw-r--r-- | xfa/src/fwl/src/core/fwl_appimp.cpp | 31 | ||||
-rw-r--r-- | xfa/src/fwl/src/core/fwl_noteimp.cpp | 2 | ||||
-rw-r--r-- | xfa/src/fwl/src/core/fwl_threadimp.cpp | 125 | ||||
-rw-r--r-- | xfa/src/fwl/src/core/fwl_widgetimp.cpp | 9 | ||||
-rw-r--r-- | xfa/src/fwl/src/core/include/fwl_appimp.h | 19 | ||||
-rw-r--r-- | xfa/src/fwl/src/core/include/fwl_noteimp.h | 2 | ||||
-rw-r--r-- | xfa/src/fwl/src/core/include/fwl_threadimp.h | 32 | ||||
-rw-r--r-- | xfa/src/fwl/src/core/include/fwl_widgetimp.h | 6 | ||||
-rw-r--r-- | xfa/src/fwl/src/lightwidget/app.cpp | 32 |
9 files changed, 98 insertions, 160 deletions
diff --git a/xfa/src/fwl/src/core/fwl_appimp.cpp b/xfa/src/fwl/src/core/fwl_appimp.cpp index 5df995c9bb..983219a683 100644 --- a/xfa/src/fwl/src/core/fwl_appimp.cpp +++ b/xfa/src/fwl/src/core/fwl_appimp.cpp @@ -10,11 +10,36 @@ #include "include/fwl_noteimp.h"
#include "include/fwl_widgetmgrimp.h"
#include "include/fwl_appimp.h"
+
IFWL_App* IFWL_App::Create(IFWL_AdapterNative* pAdapter) {
- return (IFWL_App*)new CFWL_AppImp(pAdapter);
+ IFWL_App* pApp = new IFWL_App;
+ pApp->SetImpl(new CFWL_AppImp(pApp, pAdapter));
+ return pApp;
+}
+FWL_ERR IFWL_App::Initialize() {
+ return static_cast<CFWL_AppImp*>(GetImpl())->Initialize();
+}
+FWL_ERR IFWL_App::Finalize() {
+ return static_cast<CFWL_AppImp*>(GetImpl())->Finalize();
+}
+IFWL_AdapterNative* IFWL_App::GetAdapterNative() {
+ return static_cast<CFWL_AppImp*>(GetImpl())->GetAdapterNative();
+}
+IFWL_WidgetMgr* IFWL_App::GetWidgetMgr() {
+ return static_cast<CFWL_AppImp*>(GetImpl())->GetWidgetMgr();
}
-CFWL_AppImp::CFWL_AppImp(IFWL_AdapterNative* pAdapter)
- : m_pWidgetMgr(NULL), m_pThemeProvider(NULL) {
+IFWL_ThemeProvider* IFWL_App::GetThemeProvider() {
+ return static_cast<CFWL_AppImp*>(GetImpl())->GetThemeProvider();
+}
+FWL_ERR IFWL_App::SetThemeProvider(IFWL_ThemeProvider* pThemeProvider) {
+ return static_cast<CFWL_AppImp*>(GetImpl())->SetThemeProvider(pThemeProvider);
+}
+FWL_ERR IFWL_App::Exit(int32_t iExitCode) {
+ return static_cast<CFWL_AppImp*>(GetImpl())->Exit(iExitCode);
+}
+
+CFWL_AppImp::CFWL_AppImp(IFWL_App* pIface, IFWL_AdapterNative* pAdapter)
+ : CFWL_NoteThreadImp(pIface), m_pWidgetMgr(NULL), m_pThemeProvider(NULL) {
if (!pAdapter) {
pAdapter = FWL_CreateFuelAdapterNative();
m_bFuelAdapter = TRUE;
diff --git a/xfa/src/fwl/src/core/fwl_noteimp.cpp b/xfa/src/fwl/src/core/fwl_noteimp.cpp index 4bc28b87dd..fbd90ecb7f 100644 --- a/xfa/src/fwl/src/core/fwl_noteimp.cpp +++ b/xfa/src/fwl/src/core/fwl_noteimp.cpp @@ -203,7 +203,7 @@ FWL_ERR CFWL_NoteDriver::SetQueueMaxSize(const int32_t size) { return FWL_ERR_Succeeded;
}
IFWL_NoteThread* CFWL_NoteDriver::GetOwnerThread() const {
- return (IFWL_NoteThread*)FWL_GetApp();
+ return FWL_GetApp();
}
FWL_ERR CFWL_NoteDriver::PushNoteLoop(IFWL_NoteLoop* pNoteLoop) {
m_noteLoopQueue.Add(pNoteLoop);
diff --git a/xfa/src/fwl/src/core/fwl_threadimp.cpp b/xfa/src/fwl/src/core/fwl_threadimp.cpp index 546f14ad74..6d399527b6 100644 --- a/xfa/src/fwl/src/core/fwl_threadimp.cpp +++ b/xfa/src/fwl/src/core/fwl_threadimp.cpp @@ -9,119 +9,30 @@ #include "include/fwl_noteimp.h"
#include "include/fwl_threadimp.h"
#include "include/fwl_appimp.h"
-IFWL_Thread* IFWL_Thread::Create() {
- return (IFWL_Thread*)new CFWL_Thread;
+
+void IFWL_Thread::Release() {
+ delete m_pImpl;
}
-CFWL_Thread::CFWL_Thread() {}
-CFWL_Thread::~CFWL_Thread() {}
-FWL_ERR CFWL_Thread::Run(FWL_HTHREAD hThread) {
- return FWL_ERR_Succeeded;
+FWL_ERR IFWL_Thread::Run(FWL_HTHREAD hThread) {
+ return m_pImpl->Run(hThread);
}
-IFWL_NoteThread* IFWL_NoteThread::Create() {
- return (IFWL_NoteThread*)new CFWL_NoteThread;
+IFWL_NoteDriver* IFWL_NoteThread::GetNoteDriver() {
+ return static_cast<CFWL_NoteThreadImp*>(GetImpl())->GetNoteDriver();
}
-CFWL_NoteThread::CFWL_NoteThread() : m_hThread(NULL) {
- m_pNoteDriver = new CFWL_NoteDriver;
+
+FWL_ERR CFWL_ThreadImp::Run(FWL_HTHREAD hThread) {
+ return FWL_ERR_Succeeded;
}
-CFWL_NoteThread::~CFWL_NoteThread() {
- if (m_hThread) {
- FWL_StopThread(m_hThread, 0);
- }
- if (m_pNoteDriver) {
- delete m_pNoteDriver;
- m_pNoteDriver = NULL;
- }
+CFWL_NoteThreadImp::CFWL_NoteThreadImp(IFWL_NoteThread* pIface)
+ : CFWL_ThreadImp(pIface), m_pNoteDriver(new CFWL_NoteDriver) {}
+CFWL_NoteThreadImp::~CFWL_NoteThreadImp() {
+ delete m_pNoteDriver;
}
-FWL_ERR CFWL_NoteThread::Run(FWL_HTHREAD hThread) {
+FWL_ERR CFWL_NoteThreadImp::Run(FWL_HTHREAD hThread) {
if (!m_pNoteDriver)
return FWL_ERR_Indefinite;
- FWL_ERR result = m_pNoteDriver->Run();
- return result;
-}
-IFWL_NoteDriver* CFWL_NoteThread::GetNoteDriver() {
- return (IFWL_NoteDriver*)m_pNoteDriver;
-}
-extern IFWL_AdapterNative* FWL_GetAdapterNative();
-FWL_HTHREAD FWL_StartThread(IFWL_Thread* pThread, FX_BOOL bSuspended) {
- IFWL_AdapterNative* pNative = FWL_GetAdapterNative();
- if (!pNative)
- return NULL;
- IFWL_AdapterThreadMgr* pThreadMgr = pNative->GetThreadMgr();
- if (!pThreadMgr)
- return NULL;
- FWL_HTHREAD hThread = NULL;
- pThreadMgr->Start(pThread, hThread, bSuspended);
- return hThread;
-}
-FWL_ERR FWL_ResumeThread(FWL_HTHREAD hThread) {
- IFWL_AdapterNative* Native = FWL_GetAdapterNative();
- if (!Native)
- return FWL_ERR_Indefinite;
- IFWL_AdapterThreadMgr* ThreadMgr = Native->GetThreadMgr();
- if (!ThreadMgr)
- return FWL_ERR_Indefinite;
- return ThreadMgr->Resume(hThread);
-}
-FWL_ERR FWL_SuspendThread(FWL_HTHREAD hThread) {
- IFWL_AdapterNative* Native = FWL_GetAdapterNative();
- if (!Native)
- return FWL_ERR_Indefinite;
- IFWL_AdapterThreadMgr* ThreadMgr = Native->GetThreadMgr();
- if (!ThreadMgr)
- return FWL_ERR_Indefinite;
- return ThreadMgr->Suspend(hThread);
-}
-FWL_ERR FWL_KillThread(FWL_HTHREAD hThread, int32_t iExitCode) {
- IFWL_AdapterNative* Native = FWL_GetAdapterNative();
- if (!Native)
- return FWL_ERR_Indefinite;
- IFWL_AdapterThreadMgr* ThreadMgr = Native->GetThreadMgr();
- if (!ThreadMgr)
- return FWL_ERR_Indefinite;
- return ThreadMgr->Kill(hThread, iExitCode);
-}
-FWL_ERR FWL_StopThread(FWL_HTHREAD hThread, int32_t iExitCode) {
- IFWL_AdapterNative* Native = FWL_GetAdapterNative();
- if (!Native)
- return FWL_ERR_Indefinite;
- IFWL_AdapterThreadMgr* ThreadMgr = Native->GetThreadMgr();
- if (!ThreadMgr)
- return FWL_ERR_Indefinite;
- return ThreadMgr->Stop(hThread, iExitCode);
-}
-FWL_HMUTEX FWL_CreateMutex() {
- return NULL;
-}
-FWL_ERR FWL_DestroyMutex(FWL_HMUTEX hMutex) {
- return FWL_ERR_Succeeded;
-}
-FWL_ERR FWL_LockMutex(FWL_HMUTEX hMutex) {
- return FWL_ERR_Succeeded;
-}
-FWL_ERR FWL_TryLockMutex(FWL_HMUTEX hMutex) {
- return FWL_ERR_Succeeded;
-}
-FWL_ERR FWL_UnlockMutex(FWL_HMUTEX hMutex) {
- return FWL_ERR_Succeeded;
-}
-FWL_ERR FWL_IsLockedMutex(FWL_HMUTEX hMutex, FX_BOOL& bLocked) {
- return FWL_ERR_Succeeded;
-}
-FWL_HSEMAPHORE FWL_CreateSemaphore() {
- return (FWL_HSEMAPHORE)IFWL_AdapterSemaphore::Create();
-}
-FWL_ERR FWL_DestroySemaphore(FWL_HSEMAPHORE hSemaphore) {
- return ((IFWL_AdapterSemaphore*)hSemaphore)->Destroy();
-}
-FWL_ERR FWL_WaitSemaphore(FWL_HSEMAPHORE hSemaphore) {
- return ((IFWL_AdapterSemaphore*)hSemaphore)->Wait();
-}
-FWL_ERR FWL_PostSemaphore(FWL_HSEMAPHORE hSemaphore, int32_t down) {
- return ((IFWL_AdapterSemaphore*)hSemaphore)->Post();
-}
-FWL_ERR FWL_GetSemaphoreValue(FWL_HSEMAPHORE hSemaphore, int32_t& value) {
- return ((IFWL_AdapterSemaphore*)hSemaphore)->Value((FX_DWORD&)value);
+ return m_pNoteDriver->Run();
}
-FWL_ERR FWL_ResetSemaphore(FWL_HSEMAPHORE hSemaphore, int32_t init) {
- return ((IFWL_AdapterSemaphore*)hSemaphore)->Reset(init);
+IFWL_NoteDriver* CFWL_NoteThreadImp::GetNoteDriver() {
+ return m_pNoteDriver;
}
diff --git a/xfa/src/fwl/src/core/fwl_widgetimp.cpp b/xfa/src/fwl/src/core/fwl_widgetimp.cpp index 92725ae3ff..4cba92a1cf 100644 --- a/xfa/src/fwl/src/core/fwl_widgetimp.cpp +++ b/xfa/src/fwl/src/core/fwl_widgetimp.cpp @@ -131,7 +131,8 @@ FWL_ERR CFWL_WidgetImp::Initialize() { IFWL_AdapterThreadMgr* pAdapterThread = pAdapter->GetThreadMgr();
if (!pAdapterThread)
return FWL_ERR_Indefinite;
- SetOwnerThread((CFWL_NoteThread*)pAdapterThread->GetCurrentThread());
+ SetOwnerThread(static_cast<CFWL_NoteThreadImp*>(
+ pAdapterThread->GetCurrentThread()->GetImpl()));
IFWL_Widget* pParent = m_pProperties->m_pParent;
m_pWidgetMgr->InsertWidget(pParent, m_pInterface);
if (!IsChild()) {
@@ -486,9 +487,9 @@ IFWL_WidgetDelegate* CFWL_WidgetImp::SetDelegate( return pOldDelegate;
}
IFWL_NoteThread* CFWL_WidgetImp::GetOwnerThread() const {
- return (IFWL_NoteThread*)m_pOwnerThread;
+ return static_cast<IFWL_NoteThread*>(m_pOwnerThread->GetInterface());
}
-FWL_ERR CFWL_WidgetImp::SetOwnerThread(CFWL_NoteThread* pOwnerThread) {
+FWL_ERR CFWL_WidgetImp::SetOwnerThread(CFWL_NoteThreadImp* pOwnerThread) {
m_pOwnerThread = pOwnerThread;
return FWL_ERR_Succeeded;
}
@@ -636,7 +637,7 @@ IFWL_ThemeProvider* CFWL_WidgetImp::GetAvailableTheme() { }
}
} while (pUp);
- return ((CFWL_AppImp*)FWL_GetApp())->GetThemeProvider();
+ return FWL_GetApp()->GetThemeProvider();
}
CFWL_WidgetImp* CFWL_WidgetImp::GetRootOuter() {
IFWL_Widget* pRet = m_pOuter;
diff --git a/xfa/src/fwl/src/core/include/fwl_appimp.h b/xfa/src/fwl/src/core/include/fwl_appimp.h index ec23febb32..53f0d3fe42 100644 --- a/xfa/src/fwl/src/core/include/fwl_appimp.h +++ b/xfa/src/fwl/src/core/include/fwl_appimp.h @@ -4,26 +4,28 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
-#ifndef _FWL_APP_IMP_H
-#define _FWL_APP_IMP_H
-class CFWL_NoteThread;
+#ifndef FWL_APPIMP_H_
+#define FWL_APPIMP_H_
+
+#include "xfa/src/fwl/src/core/include/fwl_threadimp.h"
+
class CFWL_WidgetMgr;
class IFWL_AdapterNative;
class IFWL_WidgetMgr;
class IFWL_ThemeProvider;
class IFWL_App;
-class CFWL_AppImp;
-class CFWL_AppImp : public CFWL_NoteThread {
+
+class CFWL_AppImp : public CFWL_NoteThreadImp {
public:
- CFWL_AppImp(IFWL_AdapterNative* pAdapter);
+ CFWL_AppImp(IFWL_App* pIface, IFWL_AdapterNative* pAdapter);
virtual ~CFWL_AppImp();
virtual FWL_ERR Initialize();
virtual FWL_ERR Finalize();
virtual IFWL_AdapterNative* GetAdapterNative();
virtual IFWL_WidgetMgr* GetWidgetMgr();
+ virtual IFWL_ThemeProvider* GetThemeProvider();
virtual FWL_ERR SetThemeProvider(IFWL_ThemeProvider* pThemeProvider);
virtual FWL_ERR Exit(int32_t iExitCode = 0);
- IFWL_ThemeProvider* GetThemeProvider();
protected:
CFWL_WidgetMgr* m_pWidgetMgr;
@@ -31,4 +33,5 @@ class CFWL_AppImp : public CFWL_NoteThread { IFWL_ThemeProvider* m_pThemeProvider;
FX_BOOL m_bFuelAdapter;
};
-#endif
+
+#endif // FWL_APPIMP_H_
diff --git a/xfa/src/fwl/src/core/include/fwl_noteimp.h b/xfa/src/fwl/src/core/include/fwl_noteimp.h index 413b0fd034..b846d20263 100644 --- a/xfa/src/fwl/src/core/include/fwl_noteimp.h +++ b/xfa/src/fwl/src/core/include/fwl_noteimp.h @@ -8,7 +8,7 @@ #define _FWL_NOTE_IMP_H
class CFWL_TargetImp;
class CFWL_WidgetImp;
-class CFWL_NoteThread;
+class CFWL_NoteThreadImp;
class CFWL_ToolTipImp;
class IFWL_ToolTipTarget;
class CFWL_CoreToopTipDP;
diff --git a/xfa/src/fwl/src/core/include/fwl_threadimp.h b/xfa/src/fwl/src/core/include/fwl_threadimp.h index eb3331f451..aa958770f4 100644 --- a/xfa/src/fwl/src/core/include/fwl_threadimp.h +++ b/xfa/src/fwl/src/core/include/fwl_threadimp.h @@ -4,31 +4,37 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
-#ifndef _FWL_THREAD_IMP_H
-#define _FWL_THREAD_IMP_H
+#ifndef FWL_THREADIMP_H_
+#define FWL_THREADIMP_H_
#include "xfa/include/fwl/core/fwl_thread.h" // For FWL_HTHREAD.
class CFWL_NoteDriver;
class IFWL_NoteDriver;
-class CFWL_Thread {
+class CFWL_ThreadImp {
public:
- CFWL_Thread();
- virtual ~CFWL_Thread();
- virtual void Release() { delete this; }
+ virtual ~CFWL_ThreadImp() {}
+ IFWL_Thread* GetInterface() const { return m_pIface; }
virtual FWL_ERR Run(FWL_HTHREAD hThread);
+
+ protected:
+ CFWL_ThreadImp(IFWL_Thread* pIface) : m_pIface(pIface) {}
+
+ private:
+ IFWL_Thread* const m_pIface;
};
-class CFWL_NoteThread : public CFWL_Thread {
+class CFWL_NoteThreadImp : public CFWL_ThreadImp {
public:
- CFWL_NoteThread();
- virtual ~CFWL_NoteThread();
- virtual FWL_ERR Run(FWL_HTHREAD hThread);
+ CFWL_NoteThreadImp(IFWL_NoteThread* pIface);
+ virtual ~CFWL_NoteThreadImp();
+
+ FWL_ERR Run(FWL_HTHREAD hThread) override;
virtual IFWL_NoteDriver* GetNoteDriver();
protected:
- CFWL_NoteDriver* m_pNoteDriver;
- FWL_HTHREAD m_hThread;
+ CFWL_NoteDriver* const m_pNoteDriver;
};
-#endif
+
+#endif // FWL_THREADIMP_H_
diff --git a/xfa/src/fwl/src/core/include/fwl_widgetimp.h b/xfa/src/fwl/src/core/include/fwl_widgetimp.h index 949738d6d2..109e575914 100644 --- a/xfa/src/fwl/src/core/include/fwl_widgetimp.h +++ b/xfa/src/fwl/src/core/include/fwl_widgetimp.h @@ -11,7 +11,7 @@ #include "xfa/src/fwl/src/core/include/fwl_targetimp.h"
class CFWL_NoteTarget;
-class CFWL_NoteThread;
+class CFWL_NoteThreadImp;
class CFWL_WidgetImpProperties;
class CFWL_WidgetMgr;
class IFWL_DataProvider;
@@ -60,7 +60,7 @@ class CFWL_WidgetImp : public CFWL_TargetImp { virtual FWL_ERR SetDataProvider(IFWL_DataProvider* pDataProvider);
virtual IFWL_WidgetDelegate* SetDelegate(IFWL_WidgetDelegate* pDelegate);
virtual IFWL_NoteThread* GetOwnerThread() const;
- FWL_ERR SetOwnerThread(CFWL_NoteThread* pOwnerThread);
+ FWL_ERR SetOwnerThread(CFWL_NoteThreadImp* pOwnerThread);
IFWL_Widget* GetInterface() const;
void SetInterface(IFWL_Widget* pInterface);
CFX_SizeF GetOffsetFromParent(IFWL_Widget* pParent);
@@ -137,7 +137,7 @@ class CFWL_WidgetImp : public CFWL_TargetImp { FX_BOOL IsParent(IFWL_Widget* pParent);
CFWL_WidgetMgr* m_pWidgetMgr;
- CFWL_NoteThread* m_pOwnerThread;
+ CFWL_NoteThreadImp* m_pOwnerThread;
CFWL_WidgetImpProperties* m_pProperties;
CFX_PrivateData* m_pPrivateData;
IFWL_WidgetDelegate* m_pDelegate;
diff --git a/xfa/src/fwl/src/lightwidget/app.cpp b/xfa/src/fwl/src/lightwidget/app.cpp index 3d49fab015..293a258f6b 100644 --- a/xfa/src/fwl/src/lightwidget/app.cpp +++ b/xfa/src/fwl/src/lightwidget/app.cpp @@ -5,31 +5,23 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
#include "../../../foxitlib.h"
-CFWL_App::CFWL_App() : m_pAppImp(NULL), m_pThemeProvider(NULL) {
- m_pAppImp = IFWL_App::Create(NULL);
-}
+CFWL_App::CFWL_App() : m_pIface(IFWL_App::Create(nullptr)), m_pTheme(nullptr) {}
CFWL_App::~CFWL_App() {
- if (m_pThemeProvider) {
- m_pThemeProvider->Finalize();
- delete m_pThemeProvider;
- m_pThemeProvider = NULL;
+ if (m_pTheme) {
+ m_pTheme->Finalize();
+ delete m_pTheme;
+ m_pTheme = NULL;
}
- m_pAppImp->Release();
+ m_pIface->Release();
}
FWL_ERR CFWL_App::Initialize() {
- m_pThemeProvider = new CFWL_Theme;
- m_pThemeProvider->Initialize();
- m_pAppImp->SetThemeProvider((IFWL_ThemeProvider*)m_pThemeProvider);
- return m_pAppImp->Initialize();
-}
-CFWL_Theme* CFWL_App::GetTheme() {
- return m_pThemeProvider;
+ m_pTheme = new CFWL_Theme;
+ m_pTheme->Initialize();
+ m_pIface->SetThemeProvider(m_pTheme);
+ return m_pIface->Initialize();
}
FWL_ERR CFWL_App::Exit(int32_t iExitCode) {
- if (!m_pAppImp)
+ if (!m_pIface)
return FWL_ERR_Indefinite;
- return m_pAppImp->Exit(iExitCode);
-}
-IFWL_App* CFWL_App::GetApp() {
- return m_pAppImp;
+ return m_pIface->Exit(iExitCode);
}
|