diff options
author | Tom Sepez <tsepez@chromium.org> | 2015-11-13 10:14:19 -0800 |
---|---|---|
committer | Tom Sepez <tsepez@chromium.org> | 2015-11-13 10:14:19 -0800 |
commit | e8131137dabd2e1dcf1bcdf49e81ee6c9ae26413 (patch) | |
tree | 77079a63e876439823e1b688be09218a40df4427 /xfa/src/fxbarcode/barcode.h | |
parent | 1f39a91b9a2f958fa2cd2e4314060b7dfe5d3bb3 (diff) | |
download | pdfium-e8131137dabd2e1dcf1bcdf49e81ee6c9ae26413.tar.xz |
Make CFWL_WidgetMgr{Delegate} inherit from IFWL_WidgetMgr{Delegate}.
C-style casting masked a fairly serious botch, where an
CFWL_ type would get cast to an IFWL_ type, and later we'd
invoke virtual methods against the IFWL_ type. Without the
proper inheritance, there's no reason to believe that the
vtables for each of these would line up with each other.
Fixing the inheritence allows us to remove the c-style casts.
I'm guessing these were added to make this compile without
having to understand the true nature of the flaw.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1439093003 .
Diffstat (limited to 'xfa/src/fxbarcode/barcode.h')
0 files changed, 0 insertions, 0 deletions