diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-06-18 12:47:11 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-06-18 12:47:11 -0700 |
| commit | 2c28619de8051661c7f66f2192c6fb9ef14ee905 (patch) | |
| tree | 4bd15bf0bb72e4127403548bf2f40230bbdd352b /xfa/src | |
| parent | 0c1bd7c6ad378ea97a2f54cb0c4761716f6d1057 (diff) | |
| download | pdfium-2c28619de8051661c7f66f2192c6fb9ef14ee905.tar.xz | |
Replace some Release() calls with virtual destructors.
Required fixing xfa-specific code.
Original Review URL: https://codereview.chromium.org/1192013002.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1176413004.
Diffstat (limited to 'xfa/src')
| -rw-r--r-- | xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp b/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp index 423d2c74aa..7a266a709f 100644 --- a/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp +++ b/xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp @@ -36,7 +36,7 @@ static CFX_DIBitmap* CreateDIBSource(IFX_FileRead* fileread) CFX_DIBitmap* bitmap = NULL;
CCodec_ModuleMgr* pCodecMgr = NULL;
ICodec_ProgressiveDecoder* pImageCodec = NULL;
- pCodecMgr = CCodec_ModuleMgr::Create();
+ pCodecMgr = new CCodec_ModuleMgr();
pImageCodec = pCodecMgr->CreateProgressiveDecoder();
FXCODEC_STATUS status = FXCODEC_STATUS_DECODE_FINISH;
status = pImageCodec->LoadImageInfo(fileread, FXCODEC_IMAGE_UNKNOWN);
@@ -78,20 +78,16 @@ static CFX_DIBitmap* CreateDIBSource(IFX_FileRead* fileread) delete pImageCodec;
pImageCodec = NULL;
}
- if (pCodecMgr) {
- pCodecMgr->Destroy();
- pCodecMgr = NULL;
- }
+ delete pCodecMgr;
+ pCodecMgr = NULL;
return bitmap;
except:
if (pImageCodec) {
delete pImageCodec;
pImageCodec = NULL;
}
- if (pCodecMgr) {
- pCodecMgr->Destroy();
- pCodecMgr = NULL;
- }
+ delete pCodecMgr;
+ pCodecMgr = NULL;
if (bitmap) {
delete bitmap;
}
|