summaryrefslogtreecommitdiff
path: root/xfa
diff options
context:
space:
mode:
authorNicolas Pena <npm@chromium.org>2017-06-29 17:02:48 -0400
committerChromium commit bot <commit-bot@chromium.org>2017-06-29 21:54:18 +0000
commitcaf6d61fbb38083f213a9d3441e12c5082d3ad3a (patch)
treeddfaf73e97af75ac862dddc34b47603d5492cfa1 /xfa
parentcd984752d05a58c0bd6f8ddd740d5cd4bfca20c6 (diff)
downloadpdfium-caf6d61fbb38083f213a9d3441e12c5082d3ad3a.tar.xz
Move Start to constructor in CFX_Image(Renderer|Transformer)chromium/3145
The bool returned by Start was not being used and the method was always called right after the constructor, so it should be in the constructor. Change-Id: I98abf9f7c11fbe42b3aa15ec5e46731198aa23d5 Reviewed-on: https://pdfium-review.googlesource.com/7151 Commit-Queue: Nicolás Peña <npm@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'xfa')
-rw-r--r--xfa/fxfa/cxfa_ffwidget.cpp7
1 files changed, 2 insertions, 5 deletions
diff --git a/xfa/fxfa/cxfa_ffwidget.cpp b/xfa/fxfa/cxfa_ffwidget.cpp
index f72b29127a..2437c53cd3 100644
--- a/xfa/fxfa/cxfa_ffwidget.cpp
+++ b/xfa/fxfa/cxfa_ffwidget.cpp
@@ -660,15 +660,12 @@ bool CXFA_ImageRenderer::StartDIBSource() {
m_Status = 2;
m_pTransformer = pdfium::MakeUnique<CFX_ImageTransformer>(
pDib, &m_ImageMatrix, m_Flags, &clip_box);
- m_pTransformer->Start();
return true;
}
- if (m_ImageMatrix.a < 0) {
+ if (m_ImageMatrix.a < 0)
dest_width = -dest_width;
- }
- if (m_ImageMatrix.d > 0) {
+ if (m_ImageMatrix.d > 0)
dest_height = -dest_height;
- }
int dest_left, dest_top;
dest_left = dest_width > 0 ? image_rect.left : image_rect.right;
dest_top = dest_height > 0 ? image_rect.top : image_rect.bottom;