diff options
| author | Ryan Harrison <rharrison@chromium.org> | 2017-08-01 16:20:40 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-08-01 20:42:42 +0000 |
| commit | 0186c1817bd1503051597dbcf0b032d4ff1277ab (patch) | |
| tree | d6fa77d9a14936838de8a54756dc2c27eed85bfe /xfa | |
| parent | da129ab38c3fb6ed3de85ffb6f8938eb31130a53 (diff) | |
| download | pdfium-0186c1817bd1503051597dbcf0b032d4ff1277ab.tar.xz | |
Remove support for negative params to ReleaseBuffer()
This CL removes the default param value for this method, which was
negative. It also adds in a method to get buffer lengths, so that the
callsites can explictly passing in the length of the buffer if they
were using the default value previously.
BUG=pdfium:828
Change-Id: I0170771ee81970b8b601631015ab3e6e39fea8ea
Reviewed-on: https://pdfium-review.googlesource.com/9790
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'xfa')
| -rw-r--r-- | xfa/fde/cfde_txtedtbuf.cpp | 2 | ||||
| -rw-r--r-- | xfa/fde/cfde_txtedtdorecord_insert.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/xfa/fde/cfde_txtedtbuf.cpp b/xfa/fde/cfde_txtedtbuf.cpp index 1ec3c9721a..f1c73a9529 100644 --- a/xfa/fde/cfde_txtedtbuf.cpp +++ b/xfa/fde/cfde_txtedtbuf.cpp @@ -118,7 +118,7 @@ CFX_WideString CFDE_TxtEdtBuf::GetRange(int32_t nBegin, int32_t nLength) const { lpDstBuf += nCopyLength; nCopyLength = chunkHeader->nUsed; } - wsText.ReleaseBuffer(); + wsText.ReleaseBuffer(wsText.GetStringLength()); return wsText; } diff --git a/xfa/fde/cfde_txtedtdorecord_insert.cpp b/xfa/fde/cfde_txtedtdorecord_insert.cpp index fe79960ebc..f752d911f6 100644 --- a/xfa/fde/cfde_txtedtdorecord_insert.cpp +++ b/xfa/fde/cfde_txtedtdorecord_insert.cpp @@ -18,7 +18,7 @@ CFDE_TxtEdtDoRecord_Insert::CFDE_TxtEdtDoRecord_Insert( ASSERT(pEngine); wchar_t* lpBuffer = m_wsInsert.GetBuffer(nLength); memcpy(lpBuffer, lpText, nLength * sizeof(wchar_t)); - m_wsInsert.ReleaseBuffer(); + m_wsInsert.ReleaseBuffer(m_wsInsert.GetStringLength()); } CFDE_TxtEdtDoRecord_Insert::~CFDE_TxtEdtDoRecord_Insert() {} |