Revert "Convert Origins to points"

This reverts commit da83d3a5cc09c4056310b3cf299dbbccd5c70d11.

Reason for revert: Reverting chain to see if fixes Chrome roll.

Original change's description:
> Convert Origins to points
>
> This CL converts various OriginX, OriginY pairs into CFX_PointF objects.
>
> Change-Id: I9141f7fc713c710b2014d4fdcdec7dc93501f844
> Reviewed-on: https://pdfium-review.googlesource.com/2575
> Commit-Queue: dsinclair <dsinclair@chromium.org>
> Reviewed-by: Nicolás Peña <npm@chromium.org>
>

TBR=tsepez@chromium.org,dsinclair@chromium.org,npm@chromium.org,pdfium-reviews@googlegroups.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Change-Id: I949fb4ec712e2587e7d0ef0191c34db198b61dcc
Reviewed-on: https://pdfium-review.googlesource.com/2696
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

6 files changed, 52 insertions, 46 deletions

diff --git a/xfa/fde/fde_visualset.h b/xfa/fde/fde_visualset.h
index 3260caee79..0c6341fead 100644
--- a/xfa/fde/fde_visualset.h
+++ b/xfa/fde/fde_visualset.h
@@ -17,7 +17,7 @@
 #include "xfa/fde/fde_object.h"
 #include "xfa/fgas/font/cfgas_fontmgr.h"
 
-class FXTEXT_CHARPOS;
+struct FXTEXT_CHARPOS;
 
 enum FDE_VISUALOBJTYPE {
   FDE_VISUALOBJ_Canvas = 0x00,
diff --git a/xfa/fgas/layout/fgas_rtfbreak.cpp b/xfa/fgas/layout/fgas_rtfbreak.cpp
index 293bbc6f5b..62e33fe9c2 100644
--- a/xfa/fgas/layout/fgas_rtfbreak.cpp
+++ b/xfa/fgas/layout/fgas_rtfbreak.cpp
@@ -1307,7 +1307,8 @@ int32_t CFX_RTFBreak::GetDisplayPos(const FX_RTFTEXTOBJ* pText,
               ptOffset.y = fFontSize * (1000 - rtBBox.height) / 2000.0f;
             }
           }
-          pCharPos->m_Origin = CFX_PointF(fX + ptOffset.x, fY - ptOffset.y);
+          pCharPos->m_OriginX = fX + ptOffset.x;
+          pCharPos->m_OriginY = fY - ptOffset.y;
         }
         if (!bRTLPiece && dwCharType != FX_CHARTYPE_Combination) {
           if (bVerticalDoc) {
@@ -1324,28 +1325,28 @@ int32_t CFX_RTFBreak::GetDisplayPos(const FX_RTFTEXTOBJ* pText,
               pCharPos->m_AdjustMatrix[1] = 0;
               pCharPos->m_AdjustMatrix[2] = 0;
               pCharPos->m_AdjustMatrix[3] = 1;
-              pCharPos->m_Origin.y += fAscent * iVerScale / 100.0f;
+              pCharPos->m_OriginY += fAscent * iVerScale / 100.0f;
             } else if (iCharRotation == 1) {
               pCharPos->m_AdjustMatrix[0] = 0;
               pCharPos->m_AdjustMatrix[1] = -1;
               pCharPos->m_AdjustMatrix[2] = -1;
               pCharPos->m_AdjustMatrix[3] = 0;
-              pCharPos->m_Origin.x -=
+              pCharPos->m_OriginX -=
                   fDescent + fAscent * iVerScale / 100.0f - fAscent;
             } else if (iCharRotation == 2) {
               pCharPos->m_AdjustMatrix[0] = 1;
               pCharPos->m_AdjustMatrix[1] = 0;
               pCharPos->m_AdjustMatrix[2] = 0;
               pCharPos->m_AdjustMatrix[3] = -1;
-              pCharPos->m_Origin.x += fCharWidth;
-              pCharPos->m_Origin.y += fAscent;
+              pCharPos->m_OriginX += fCharWidth;
+              pCharPos->m_OriginY += fAscent;
             } else {
               pCharPos->m_AdjustMatrix[0] = 0;
               pCharPos->m_AdjustMatrix[1] = 1;
               pCharPos->m_AdjustMatrix[2] = 1;
               pCharPos->m_AdjustMatrix[3] = 0;
-              pCharPos->m_Origin.x += fAscent;
-              pCharPos->m_Origin.y += fCharWidth;
+              pCharPos->m_OriginX += fAscent;
+              pCharPos->m_OriginY += fCharWidth;
             }
           } else {
             if (iCharRotation == 0) {
@@ -1353,27 +1354,27 @@ int32_t CFX_RTFBreak::GetDisplayPos(const FX_RTFTEXTOBJ* pText,
               pCharPos->m_AdjustMatrix[1] = 0;
               pCharPos->m_AdjustMatrix[2] = 0;
               pCharPos->m_AdjustMatrix[3] = 1;
-              pCharPos->m_Origin.y += fAscent * iVerScale / 100.0f - fAscent;
+              pCharPos->m_OriginY += fAscent * iVerScale / 100.0f - fAscent;
             } else if (iCharRotation == 1) {
               pCharPos->m_AdjustMatrix[0] = 0;
               pCharPos->m_AdjustMatrix[1] = -1;
               pCharPos->m_AdjustMatrix[2] = -1;
               pCharPos->m_AdjustMatrix[3] = 0;
-              pCharPos->m_Origin.x -= fDescent;
-              pCharPos->m_Origin.y -= fAscent + fDescent;
+              pCharPos->m_OriginX -= fDescent;
+              pCharPos->m_OriginY -= fAscent + fDescent;
             } else if (iCharRotation == 2) {
               pCharPos->m_AdjustMatrix[0] = 1;
               pCharPos->m_AdjustMatrix[1] = 0;
               pCharPos->m_AdjustMatrix[2] = 0;
               pCharPos->m_AdjustMatrix[3] = -1;
-              pCharPos->m_Origin.x += fCharWidth;
-              pCharPos->m_Origin.y -= fAscent;
+              pCharPos->m_OriginX += fCharWidth;
+              pCharPos->m_OriginY -= fAscent;
             } else {
               pCharPos->m_AdjustMatrix[0] = 0;
               pCharPos->m_AdjustMatrix[1] = 1;
               pCharPos->m_AdjustMatrix[2] = 1;
               pCharPos->m_AdjustMatrix[3] = 0;
-              pCharPos->m_Origin.x += fAscent * iVerScale / 100.0f;
+              pCharPos->m_OriginX += fAscent * iVerScale / 100.0f;
             }
           }
           if (iHorScale != 100 || iVerScale != 100) {
diff --git a/xfa/fgas/layout/fgas_textbreak.cpp b/xfa/fgas/layout/fgas_textbreak.cpp
index b8893b99ae..69773f8eb0 100644
--- a/xfa/fgas/layout/fgas_textbreak.cpp
+++ b/xfa/fgas/layout/fgas_textbreak.cpp
@@ -1447,21 +1447,22 @@ int32_t CFX_TxtBreak::GetDisplayPos(const FX_TXTRUN* pTxtRun,
         }
       }
       if (!bEmptyChar || (bEmptyChar && !bSkipSpace)) {
-        pCharPos->m_Origin = CFX_PointF(fX, fY);
+        pCharPos->m_OriginX = fX;
+        pCharPos->m_OriginY = fY;
         if ((dwStyles & FX_TXTLAYOUTSTYLE_CombText) != 0) {
           int32_t iFormWidth = iCharWidth;
           pFont->GetCharWidth(wForm, iFormWidth, false);
           FX_FLOAT fOffset = fFontSize * (iCharWidth - iFormWidth) / 2000.0f;
           if (bVerticalDoc) {
-            pCharPos->m_Origin.y += fOffset;
+            pCharPos->m_OriginY += fOffset;
           } else {
-            pCharPos->m_Origin.x += fOffset;
+            pCharPos->m_OriginX += fOffset;
           }
         }
         if (chartype == FX_CHARTYPE_Combination) {
           CFX_Rect rtBBox;
           if (pFont->GetCharBBox(wForm, &rtBBox, false)) {
-            pCharPos->m_Origin.y =
+            pCharPos->m_OriginY =
                 fYBase + fFontSize -
                 fFontSize * (FX_FLOAT)rtBBox.height / (FX_FLOAT)iMaxHeight;
           }
@@ -1471,7 +1472,7 @@ int32_t CFX_TxtBreak::GetDisplayPos(const FX_TXTRUN* pTxtRun,
                 FX_CHARTYPE_Combination) {
               CFX_Rect rtBox;
               if (pFont->GetCharBBox(wLast, &rtBox, false)) {
-                pCharPos->m_Origin.y -= fFontSize * rtBox.height / iMaxHeight;
+                pCharPos->m_OriginY -= fFontSize * rtBox.height / iMaxHeight;
               }
             }
           }
@@ -1489,8 +1490,8 @@ int32_t CFX_TxtBreak::GetDisplayPos(const FX_TXTRUN* pTxtRun,
             ptOffset.y = fFontSize * (iAscent - rtBBox.top - 150) / iMaxHeight;
           }
         }
-        pCharPos->m_Origin.x += ptOffset.x;
-        pCharPos->m_Origin.y -= ptOffset.y;
+        pCharPos->m_OriginX += ptOffset.x;
+        pCharPos->m_OriginY -= ptOffset.y;
       }
       if (!bRTLPiece && chartype != FX_CHARTYPE_Combination) {
         if (bVerticalDoc) {
@@ -1507,26 +1508,26 @@ int32_t CFX_TxtBreak::GetDisplayPos(const FX_TXTRUN* pTxtRun,
             pCharPos->m_AdjustMatrix[1] = 0;
             pCharPos->m_AdjustMatrix[2] = 0;
             pCharPos->m_AdjustMatrix[3] = 1;
-            pCharPos->m_Origin.y += fAscent;
+            pCharPos->m_OriginY += fAscent;
           } else if (iCharRotation == 1) {
             pCharPos->m_AdjustMatrix[0] = 0;
             pCharPos->m_AdjustMatrix[1] = -1;
             pCharPos->m_AdjustMatrix[2] = -1;
             pCharPos->m_AdjustMatrix[3] = 0;
-            pCharPos->m_Origin.x -= fDescent;
+            pCharPos->m_OriginX -= fDescent;
           } else if (iCharRotation == 2) {
             pCharPos->m_AdjustMatrix[0] = 1;
             pCharPos->m_AdjustMatrix[1] = 0;
             pCharPos->m_AdjustMatrix[2] = 0;
             pCharPos->m_AdjustMatrix[3] = -1;
-            pCharPos->m_Origin.x += fCharWidth;
-            pCharPos->m_Origin.y += fAscent;
+            pCharPos->m_OriginX += fCharWidth;
+            pCharPos->m_OriginY += fAscent;
           } else {
             pCharPos->m_AdjustMatrix[0] = 0;
             pCharPos->m_AdjustMatrix[1] = 1;
             pCharPos->m_AdjustMatrix[2] = 1;
             pCharPos->m_AdjustMatrix[3] = 0;
-            pCharPos->m_Origin.x += fAscent;
+            pCharPos->m_OriginX += fAscent;
           }
         } else {
           if (iCharRotation == 0) {
@@ -1539,21 +1540,21 @@ int32_t CFX_TxtBreak::GetDisplayPos(const FX_TXTRUN* pTxtRun,
             pCharPos->m_AdjustMatrix[1] = -1;
             pCharPos->m_AdjustMatrix[2] = -1;
             pCharPos->m_AdjustMatrix[3] = 0;
-            pCharPos->m_Origin.x -= fDescent;
-            pCharPos->m_Origin.y -= fAscent + fDescent;
+            pCharPos->m_OriginX -= fDescent;
+            pCharPos->m_OriginY -= fAscent + fDescent;
           } else if (iCharRotation == 2) {
             pCharPos->m_AdjustMatrix[0] = 1;
             pCharPos->m_AdjustMatrix[1] = 0;
             pCharPos->m_AdjustMatrix[2] = 0;
             pCharPos->m_AdjustMatrix[3] = -1;
-            pCharPos->m_Origin.x += fCharWidth;
-            pCharPos->m_Origin.y -= fAscent;
+            pCharPos->m_OriginX += fCharWidth;
+            pCharPos->m_OriginY -= fAscent;
           } else {
             pCharPos->m_AdjustMatrix[0] = 0;
             pCharPos->m_AdjustMatrix[1] = 1;
             pCharPos->m_AdjustMatrix[2] = 1;
             pCharPos->m_AdjustMatrix[3] = 0;
-            pCharPos->m_Origin.x += fAscent;
+            pCharPos->m_OriginX += fAscent;
           }
         }
         if (iHorScale != 100 || iVerScale != 100) {
diff --git a/xfa/fxbarcode/oned/BC_OneDimWriter.cpp b/xfa/fxbarcode/oned/BC_OneDimWriter.cpp
index bc0d61fd25..93a53a88a1 100644
--- a/xfa/fxbarcode/oned/BC_OneDimWriter.cpp
+++ b/xfa/fxbarcode/oned/BC_OneDimWriter.cpp
@@ -177,7 +177,8 @@ void CBC_OneDimWriter::CalcTextInfo(const CFX_ByteString& text,
       (FX_FLOAT)FXSYS_abs(cFont->GetDescent()) * (FX_FLOAT)fontSize / 1000.0f;
   FX_FLOAT left = leftPositon;
   FX_FLOAT top = 0.0;
-  charPos[0].m_Origin = CFX_PointF(penX + left, penY + top);
+  charPos[0].m_OriginX = penX + left;
+  charPos[0].m_OriginY = penY + top;
   charPos[0].m_GlyphIndex = encoding->GlyphFromCharCode(pCharCode[0]);
   charPos[0].m_FontCharWidth = cFont->GetGlyphWidth(charPos[0].m_GlyphIndex);
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_
@@ -185,7 +186,8 @@ void CBC_OneDimWriter::CalcTextInfo(const CFX_ByteString& text,
 #endif
   penX += (FX_FLOAT)(charPos[0].m_FontCharWidth) * (FX_FLOAT)fontSize / 1000.0f;
   for (int32_t i = 1; i < length; i++) {
-    charPos[i].m_Origin = CFX_PointF(penX + left, penY + top);
+    charPos[i].m_OriginX = penX + left;
+    charPos[i].m_OriginY = penY + top;
     charPos[i].m_GlyphIndex = encoding->GlyphFromCharCode(pCharCode[i]);
     charPos[i].m_FontCharWidth = cFont->GetGlyphWidth(charPos[i].m_GlyphIndex);
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_
diff --git a/xfa/fxfa/app/cxfa_textlayout.cpp b/xfa/fxfa/app/cxfa_textlayout.cpp
index 17aa1a40ab..ad0fc057e2 100644
--- a/xfa/fxfa/app/cxfa_textlayout.cpp
+++ b/xfa/fxfa/app/cxfa_textlayout.cpp
@@ -1187,11 +1187,11 @@ void CXFA_TextLayout::RenderPath(CFDE_RenderDevice* pDevice,
   int32_t iChars = GetDisplayPos(pPiece, pCharPos);
   if (iChars > 0) {
     CFX_PointF pt1, pt2;
-    FX_FLOAT fEndY = pCharPos[0].m_Origin.y + 1.05f;
+    FX_FLOAT fEndY = pCharPos[0].m_OriginY + 1.05f;
     if (pPiece->iPeriod == XFA_ATTRIBUTEENUM_Word) {
       for (int32_t i = 0; i < pPiece->iUnderline; i++) {
         for (int32_t j = 0; j < iChars; j++) {
-          pt1.x = pCharPos[j].m_Origin.x;
+          pt1.x = pCharPos[j].m_OriginX;
           pt2.x =
               pt1.x + pCharPos[j].m_FontCharWidth * pPiece->fFontSize / 1000.0f;
           pt1.y = pt2.y = fEndY;
@@ -1200,9 +1200,9 @@ void CXFA_TextLayout::RenderPath(CFDE_RenderDevice* pDevice,
         fEndY += 2.0f;
       }
     } else {
-      pt1.x = pCharPos[0].m_Origin.x;
+      pt1.x = pCharPos[0].m_OriginX;
       pt2.x =
-          pCharPos[iChars - 1].m_Origin.x +
+          pCharPos[iChars - 1].m_OriginX +
           pCharPos[iChars - 1].m_FontCharWidth * pPiece->fFontSize / 1000.0f;
       for (int32_t i = 0; i < pPiece->iUnderline; i++) {
         pt1.y = pt2.y = fEndY;
@@ -1210,9 +1210,9 @@ void CXFA_TextLayout::RenderPath(CFDE_RenderDevice* pDevice,
         fEndY += 2.0f;
       }
     }
-    fEndY = pCharPos[0].m_Origin.y - pPiece->rtPiece.height * 0.25f;
-    pt1.x = pCharPos[0].m_Origin.x;
-    pt2.x = pCharPos[iChars - 1].m_Origin.x +
+    fEndY = pCharPos[0].m_OriginY - pPiece->rtPiece.height * 0.25f;
+    pt1.x = pCharPos[0].m_OriginX;
+    pt2.x = pCharPos[iChars - 1].m_OriginX +
             pCharPos[iChars - 1].m_FontCharWidth * pPiece->fFontSize / 1000.0f;
     for (int32_t i = 0; i < pPiece->iLineThrough; i++) {
       pt1.y = pt2.y = fEndY;
@@ -1253,23 +1253,23 @@ void CXFA_TextLayout::RenderPath(CFDE_RenderDevice* pDevice,
     if (iChars < 1)
       return;
 
-    fOrgX = pCharPos[iChars - 1].m_Origin.x +
+    fOrgX = pCharPos[iChars - 1].m_OriginX +
             pCharPos[iChars - 1].m_FontCharWidth * pPiece->fFontSize / 1000.0f;
     pPiece = pPieceLine->m_textPieces[iPieceNext].get();
     iChars = GetDisplayPos(pPiece, pCharPos);
     if (iChars < 1)
       return;
 
-    fEndX = pCharPos[0].m_Origin.x;
+    fEndX = pCharPos[0].m_OriginX;
     CFX_PointF pt1, pt2;
     pt1.x = fOrgX, pt2.x = fEndX;
-    FX_FLOAT fEndY = pCharPos[0].m_Origin.y + 1.05f;
+    FX_FLOAT fEndY = pCharPos[0].m_OriginY + 1.05f;
     for (int32_t i = 0; i < pPiece->iUnderline; i++) {
       pt1.y = pt2.y = fEndY;
       pPath->AddLine(pt1, pt2);
       fEndY += 2.0f;
     }
-    fEndY = pCharPos[0].m_Origin.y - pPiece->rtPiece.height * 0.25f;
+    fEndY = pCharPos[0].m_OriginY - pPiece->rtPiece.height * 0.25f;
     for (int32_t i = 0; i < pPiece->iLineThrough; i++) {
       pt1.y = pt2.y = fEndY;
       pPath->AddLine(pt1, pt2);
diff --git a/xfa/fxgraphics/cfx_graphics.cpp b/xfa/fxgraphics/cfx_graphics.cpp
index 2b8bd17aad..f1abfb7cb5 100644
--- a/xfa/fxgraphics/cfx_graphics.cpp
+++ b/xfa/fxgraphics/cfx_graphics.cpp
@@ -1484,7 +1484,8 @@ FWL_Error CFX_Graphics::CalcTextInfo(const CFX_WideString& text,
   FX_FLOAT left = (FX_FLOAT)(0);
   FX_FLOAT top = (FX_FLOAT)(0);
   charCodes[0] = text.GetAt(0);
-  charPos[0].m_Origin = CFX_PointF(penX + left, penY + top);
+  charPos[0].m_OriginX = penX + left;
+  charPos[0].m_OriginY = penY + top;
   charPos[0].m_GlyphIndex = encoding->GlyphFromCharCode(charCodes[0]);
   charPos[0].m_FontCharWidth = FXSYS_round(
       m_info.font->GetGlyphWidth(charPos[0].m_GlyphIndex) * m_info.fontHScale);
@@ -1497,7 +1498,8 @@ FWL_Error CFX_Graphics::CalcTextInfo(const CFX_WideString& text,
           m_info.fontSpacing;
   for (int32_t i = 1; i < length; i++) {
     charCodes[i] = text.GetAt(i);
-    charPos[i].m_Origin = CFX_PointF(penX + left, penY + top);
+    charPos[i].m_OriginX = penX + left;
+    charPos[i].m_OriginY = penY + top;
     charPos[i].m_GlyphIndex = encoding->GlyphFromCharCode(charCodes[i]);
     charPos[i].m_FontCharWidth =
         FXSYS_round(m_info.font->GetGlyphWidth(charPos[i].m_GlyphIndex) *