summaryrefslogtreecommitdiff
path: root/xfa
diff options
context:
space:
mode:
authorRyan Harrison <rharrison@chromium.org>2018-04-18 21:20:32 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-04-18 21:20:32 +0000
commitfbecb9a5150d2c5391581933c8089e7249292171 (patch)
tree0e6323bd2e4d8d2de4368cdcdc3d4dcce1ffd169 /xfa
parent7439517516a0bb3833ee95ddb9d71051f981347c (diff)
downloadpdfium-fbecb9a5150d2c5391581933c8089e7249292171.tar.xz
Do not show validation errors if PDF not yet loadedchromium/3400
This prevents display of confusing popups during the loading/initialization of the XFA document. The spec explicitly states that validation should be run at this point, but other viewers like Acrobat do not fire this spurious pop ups. BUG=pdfium:975 Change-Id: Ic00d8c767ae94f95c7455a58b77e0b7283e3307c Reviewed-on: https://pdfium-review.googlesource.com/30930 Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'xfa')
-rw-r--r--xfa/fwl/cfwl_edit_embeddertest.cpp6
1 files changed, 1 insertions, 5 deletions
diff --git a/xfa/fwl/cfwl_edit_embeddertest.cpp b/xfa/fwl/cfwl_edit_embeddertest.cpp
index 59a4ca5947..7415e05845 100644
--- a/xfa/fwl/cfwl_edit_embeddertest.cpp
+++ b/xfa/fwl/cfwl_edit_embeddertest.cpp
@@ -37,11 +37,7 @@ class CFWLEditEmbeddertest : public EmbedderTest {
};
TEST_F(CFWLEditEmbeddertest, Trivial) {
- ASSERT_EQ(1u, delegate().GetAlerts().size());
- auto alert = delegate().GetAlerts()[0];
- EXPECT_STREQ(L"PDFium", alert.title.c_str());
- EXPECT_STREQ(L"The value you entered for Text Field is invalid.",
- alert.message.c_str());
+ ASSERT_EQ(0u, delegate().GetAlerts().size());
}
TEST_F(CFWLEditEmbeddertest, LeftClickMouseSelection) {