diff options
| author | tsepez <tsepez@chromium.org> | 2016-06-01 13:35:28 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-06-01 13:35:28 -0700 |
| commit | 8abd7a2bbfef51ca6dc8a3462c067e5d2c46200e (patch) | |
| tree | be8c84b695efe5e653d881a6f3194df981e76edb /xfa | |
| parent | f6be145f54bf44810974e43e9554c756c9730bb6 (diff) | |
| download | pdfium-8abd7a2bbfef51ca6dc8a3462c067e5d2c46200e.tar.xz | |
Remove use of v8:Lockers
The entire code base is single-threaded, hence the lockers
ought not be required.
Review-Url: https://codereview.chromium.org/2026933002
Diffstat (limited to 'xfa')
| -rw-r--r-- | xfa/fxjse/runtime.cpp | 9 | ||||
| -rw-r--r-- | xfa/fxjse/scope_inline.h | 2 |
2 files changed, 3 insertions, 8 deletions
diff --git a/xfa/fxjse/runtime.cpp b/xfa/fxjse/runtime.cpp index 64d685bd5f..70d90c44fa 100644 --- a/xfa/fxjse/runtime.cpp +++ b/xfa/fxjse/runtime.cpp @@ -36,12 +36,9 @@ void FXJSE_Initialize() { } static void FXJSE_Runtime_DisposeCallback(v8::Isolate* pIsolate) { - { - v8::Locker locker(pIsolate); - if (FXJS_PerIsolateData* pData = FXJS_PerIsolateData::Get(pIsolate)) { - delete pData->m_pFXJSERuntimeData; - pData->m_pFXJSERuntimeData = nullptr; - } + if (FXJS_PerIsolateData* pData = FXJS_PerIsolateData::Get(pIsolate)) { + delete pData->m_pFXJSERuntimeData; + pData->m_pFXJSERuntimeData = nullptr; } pIsolate->Dispose(); } diff --git a/xfa/fxjse/scope_inline.h b/xfa/fxjse/scope_inline.h index 90b20fc3d0..8ef9c85530 100644 --- a/xfa/fxjse/scope_inline.h +++ b/xfa/fxjse/scope_inline.h @@ -14,7 +14,6 @@ class CFXJSE_ScopeUtil_IsolateHandle { public: explicit CFXJSE_ScopeUtil_IsolateHandle(v8::Isolate* pIsolate) : m_isolate(pIsolate), - m_locker(pIsolate), m_iscope(pIsolate), m_hscope(pIsolate) {} v8::Isolate* GetIsolate() { return m_isolate; } @@ -27,7 +26,6 @@ class CFXJSE_ScopeUtil_IsolateHandle { void operator delete(void*, size_t) = delete; v8::Isolate* m_isolate; - v8::Locker m_locker; v8::Isolate::Scope m_iscope; v8::HandleScope m_hscope; }; |