summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--fpdfsdk/fpdf_transformpage.cpp3
-rw-r--r--fpdfsdk/fpdf_transformpage_embeddertest.cpp10
2 files changed, 13 insertions, 0 deletions
diff --git a/fpdfsdk/fpdf_transformpage.cpp b/fpdfsdk/fpdf_transformpage.cpp
index a3ba7ca7a9..210c6b6fde 100644
--- a/fpdfsdk/fpdf_transformpage.cpp
+++ b/fpdfsdk/fpdf_transformpage.cpp
@@ -36,6 +36,9 @@ bool GetBoundingBox(CPDF_Page* page,
float* bottom,
float* right,
float* top) {
+ if (!left || !bottom || !right || !top)
+ return false;
+
CPDF_Array* pArray = page->GetDict()->GetArrayFor(key);
if (!pArray)
return false;
diff --git a/fpdfsdk/fpdf_transformpage_embeddertest.cpp b/fpdfsdk/fpdf_transformpage_embeddertest.cpp
index d064efee0b..1ebd0f054c 100644
--- a/fpdfsdk/fpdf_transformpage_embeddertest.cpp
+++ b/fpdfsdk/fpdf_transformpage_embeddertest.cpp
@@ -66,6 +66,16 @@ TEST_F(FPDFTransformEmbedderTest, GetBoundingBoxes) {
EXPECT_EQ(60, cropbox_right);
EXPECT_EQ(60, cropbox_top);
+ EXPECT_FALSE(FPDFPage_GetCropBox(page, nullptr, &cropbox_bottom,
+ &cropbox_right, &cropbox_top));
+ EXPECT_FALSE(FPDFPage_GetCropBox(page, &cropbox_left, nullptr,
+ &cropbox_right, &cropbox_top));
+ EXPECT_FALSE(FPDFPage_GetCropBox(page, &cropbox_left, &cropbox_bottom,
+ nullptr, &cropbox_top));
+ EXPECT_FALSE(FPDFPage_GetCropBox(page, &cropbox_left, &cropbox_bottom,
+ &cropbox_right, nullptr));
+ EXPECT_FALSE(FPDFPage_GetCropBox(page, nullptr, nullptr, nullptr, nullptr));
+
UnloadPage(page);
}
}