diff options
-rw-r--r-- | AUTHORS | 3 | ||||
-rw-r--r-- | fpdfsdk/formfiller/cffl_checkbox.cpp | 6 | ||||
-rw-r--r-- | fpdfsdk/formfiller/cffl_combobox.cpp | 7 | ||||
-rw-r--r-- | fpdfsdk/formfiller/cffl_formfiller.cpp | 5 | ||||
-rw-r--r-- | fpdfsdk/formfiller/cffl_listbox.cpp | 9 | ||||
-rw-r--r-- | fpdfsdk/formfiller/cffl_radiobutton.cpp | 6 | ||||
-rw-r--r-- | fpdfsdk/formfiller/cffl_textfield.cpp | 16 |
7 files changed, 43 insertions, 9 deletions
@@ -27,13 +27,14 @@ Ke Liu <stackexploit@gmail.com> Kostya Serebryany <kcc@chromium.org> Lei Zhang <thestig@chromium.org> Lucas Nihlen <luken@chromium.org> +Luật Nguyễn <manhluat93.php@gmail.com> Matt Giuca <mgiuca@chromium.org> Michael Doppler <m.doppler@gmail.com> Miklos Vajna <vmiklos@vmiklos.hu> Nico Weber <thakis@chromium.org> Peter Kasting <pkasting@chromium.org> Raymes Khoury <raymes@chromium.org> -Reid Kleckner <rnk@chromium.org>
+Reid Kleckner <rnk@chromium.org> Ryan Wiley <wileyrr@gmail.com> Robert Sesek <rsesek@chromium.org> Sam Clegg <sbc@chromium.org> diff --git a/fpdfsdk/formfiller/cffl_checkbox.cpp b/fpdfsdk/formfiller/cffl_checkbox.cpp index 2863a56001..e9c72efd39 100644 --- a/fpdfsdk/formfiller/cffl_checkbox.cpp +++ b/fpdfsdk/formfiller/cffl_checkbox.cpp @@ -111,9 +111,15 @@ void CFFL_CheckBox::SaveData(CPDFSDK_PageView* pPageView) { } } } + CPDFSDK_Widget::ObservedPtr observed_widget(m_pWidget.Get()); + CFFL_CheckBox::ObservedPtr observed_this(this); m_pWidget->SetCheck(bNewChecked, false); + if (!observed_widget) + return; m_pWidget->UpdateField(); + if (!observed_widget || !observed_this) + return; SetChangeMark(); } diff --git a/fpdfsdk/formfiller/cffl_combobox.cpp b/fpdfsdk/formfiller/cffl_combobox.cpp index ab34a650c5..d9b12f5d3c 100644 --- a/fpdfsdk/formfiller/cffl_combobox.cpp +++ b/fpdfsdk/formfiller/cffl_combobox.cpp @@ -108,11 +108,16 @@ void CFFL_ComboBox::SaveData(CPDFSDK_PageView* pPageView) { m_pWidget->GetSelectedIndex(0); m_pWidget->SetOptionSelection(nCurSel, true, false); } + CPDFSDK_Widget::ObservedPtr observed_widget(m_pWidget.Get()); + CFFL_ComboBox::ObservedPtr observed_this(this); m_pWidget->ResetFieldAppearance(true); + if (!observed_widget) + return; m_pWidget->UpdateField(); + if (!observed_widget || !observed_this) + return; SetChangeMark(); - m_pWidget->GetPDFPage(); } diff --git a/fpdfsdk/formfiller/cffl_formfiller.cpp b/fpdfsdk/formfiller/cffl_formfiller.cpp index 1ed7ffa420..8f48c029da 100644 --- a/fpdfsdk/formfiller/cffl_formfiller.cpp +++ b/fpdfsdk/formfiller/cffl_formfiller.cpp @@ -491,7 +491,10 @@ bool CFFL_FormFiller::CommitData(CPDFSDK_PageView* pPageView, uint32_t nFlag) { if (!pObserved) return false; - SaveData(pPageView); + SaveData(pPageView); // may invoking JS to delete this widget. + if (!pObserved) + return false; + pFormFiller->OnCalculate(&pObserved, pPageView, nFlag); if (!pObserved) return false; diff --git a/fpdfsdk/formfiller/cffl_listbox.cpp b/fpdfsdk/formfiller/cffl_listbox.cpp index 9dad11d3a0..e628e59cb8 100644 --- a/fpdfsdk/formfiller/cffl_listbox.cpp +++ b/fpdfsdk/formfiller/cffl_listbox.cpp @@ -117,9 +117,18 @@ void CFFL_ListBox::SaveData(CPDFSDK_PageView* pPageView) { } else { m_pWidget->SetOptionSelection(pListBox->GetCurSel(), true, false); } + CPDFSDK_Widget::ObservedPtr observed_widget(m_pWidget.Get()); + CFFL_ListBox::ObservedPtr observed_this(this); + m_pWidget->SetTopVisibleIndex(nNewTopIndex); + if (!observed_widget) + return; m_pWidget->ResetFieldAppearance(true); + if (!observed_widget) + return; m_pWidget->UpdateField(); + if (!observed_widget || !observed_this) + return; SetChangeMark(); } diff --git a/fpdfsdk/formfiller/cffl_radiobutton.cpp b/fpdfsdk/formfiller/cffl_radiobutton.cpp index f8ada67ff3..73ac44de46 100644 --- a/fpdfsdk/formfiller/cffl_radiobutton.cpp +++ b/fpdfsdk/formfiller/cffl_radiobutton.cpp @@ -102,9 +102,15 @@ void CFFL_RadioButton::SaveData(CPDFSDK_PageView* pPageView) { } } } + CPDFSDK_Widget::ObservedPtr observed_widget(m_pWidget.Get()); + CFFL_RadioButton::ObservedPtr observed_this(this); m_pWidget->SetCheck(bNewChecked, false); + if (!observed_widget) + return; m_pWidget->UpdateField(); + if (!observed_widget || !observed_this) + return; SetChangeMark(); } diff --git a/fpdfsdk/formfiller/cffl_textfield.cpp b/fpdfsdk/formfiller/cffl_textfield.cpp index 4174ae4179..ad8d27c916 100644 --- a/fpdfsdk/formfiller/cffl_textfield.cpp +++ b/fpdfsdk/formfiller/cffl_textfield.cpp @@ -141,13 +141,17 @@ void CFFL_TextField::SaveData(CPDFSDK_PageView* pPageView) { CPDFSDK_Widget::ObservedPtr observed_widget(m_pWidget.Get()); CFFL_TextField::ObservedPtr observed_this(this); + m_pWidget->SetValue(sNewValue, false); - if (observed_widget) - m_pWidget->ResetFieldAppearance(true); - if (observed_widget) - m_pWidget->UpdateField(); - if (observed_this) - SetChangeMark(); + if (!observed_widget) + return; + m_pWidget->ResetFieldAppearance(true); + if (!observed_widget) + return; + m_pWidget->UpdateField(); + if (!observed_widget || !observed_this) + return; + SetChangeMark(); } void CFFL_TextField::GetActionData(CPDFSDK_PageView* pPageView, |