Age | Commit message (Collapse) | Author |
|
Fixes a warning.
BUG=
TBR=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/395293002
|
|
C++11 makes uninitialized const PODs an error, because they contain
uninitialized memory (they're uninitialized that can never be initialized
(because they're const).
In this case, the memory was only used by _GetSubFontName() if the lang
parameter was 1, but _GetSubFontName() is only called from one place, with
a lang parameter of 0. So remove _GetSubFontName()'s lang parameter too.
(Using bsearch for searching an array that always has exactly 2 entries is
overkill too, but I'm trying to keep the diff small.)
No intended behavior change. Fixes this error on the clang/win bot:
..\..\third_party\pdfium\core\src\fxge\win32\fx_win32_device.cpp(207,20) : error(clang): default initialization of an object of const type 'const _FontNameMap [1]'
const _FontNameMap g_GbFontNameMap[1];
^
BUG=chromium:82385
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/369343003
|
|
BUG=386728
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/397803002
|
|
BUG=391470
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/384593002
|
|
BUG=387809
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/379283003
|
|
BUG=386730
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/379923012
|
|
BUG=387826
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/387273002
|
|
This change adds the support to extract "NumCopies", "PrintPageRange", "Duplex" viewer preferences for printing.
BUG=169120
R=bo_xu@foxitsoftware.com, vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/345123002
|
|
BUG=381521
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/383563002
|
|
BUG=387843
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/380293002
|
|
BUG=387011
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/382603003
|
|
BUG=387835
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/381173002
|
|
BUG=387834
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/386663003
|
|
BUG=387975
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/379273002
|
|
This contains fixes for the following sorts of issues:
* Nonstandard extension: unnamed struct/union
This also changes the signature of FPDF_FillRect() to enable the cleanest
possible changes in https://codereview.chromium.org/372273005 .
BUG=81439
TEST=none
Original patch by Peter Kasting <pkasting@chromium.org>
Original code review: https://codereview.chromium.org/376003003/
R=pkasting@chromium.org
Review URL: https://codereview.chromium.org/377353002
|
|
BUG=390615
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/378293005
|
|
TBR=palmer@chromium.org
Review URL: https://codereview.chromium.org/378073002
|
|
Fixes for re-enabling more MSVC level 4 warnings: pdfium/ edition
BUG=81439
TBR=pkasting@chromium.org
Review URL: https://codereview.chromium.org/376043003
|
|
This contains fixes for the following sorts of issues:
* Nonstandard extension: unnamed struct/union
This also changes the signature of FPDF_FillRect() to enable the cleanest
possible changes in https://codereview.chromium.org/372273005 .
BUG=81439
TEST=none
Original patch by Peter Kasting <pkasting@chromium.org>
Original code review: https://codereview.chromium.org/376003003/
R=pkasting@chromium.org
Review URL: https://codereview.chromium.org/372383004
|
|
BUG=
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/372473003
|
|
BUG=387822
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/367383002
|
|
BUG=382601
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/336003004
|
|
BUG=382820
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/349853003
|
|
BUG=382242
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/341333004
|
|
BUG=387785
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/362403002
|
|
BUG=387783
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/368783004
|
|
BUG=386729
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/366803003
|
|
BUG=387841
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/354363003
|
|
BUG=382656
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/334573007
|
|
BUG=387506
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/361103002
|
|
BUG=387840
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/354413002
|
|
|
|
|
|
BUG=
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/361553002
|
|
BUG=20
R=jschuh@chromium.org
Review URL: https://codereview.chromium.org/349033008
|
|
We'll use this for integer overflows going forward.
BUG=382606
R=jam@chromium.org
Review URL: https://codereview.chromium.org/349363005
|
|
This patch adds the 'b' (binary mode) flag to the fopen calls.
Before the fix the PPM images written with --write_images were corrupted
under Windows because on this platform in text mode all occurrences of
the byte 0xa (line feed) are replaced with the bytes 0x0d (carriage
return) and 0x0a (line feed).
On UNIX platforms the 'b' flag is supported but ignored, because no
translation of the line feed character takes place.
BUG=18
R=jam@chromium.org
Original patch by Michael Doppler <m.doppler@gmail.com>
Review URL: https://codereview.chromium.org/343303004
|
|
BUG=382639
R=mdempsky@chromium.org
Review URL: https://codereview.chromium.org/354673002
|
|
This reverts commit d9713f05fdcecab8428d39034c6b84cd0bbd2920.
This is breaking compile.
|
|
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/331123002
|
|
BUG=382243
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/333213002
|
|
BUG=382240
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/332143002
|
|
We'll use this for integer overflows going forward.
BUG=382606
R=bo_xu@foxitsoftware.com, jschuh@chromium.org
Review URL: https://codereview.chromium.org/341533007
|
|
MSVC lexes L#macro_arg as a single wide string literal token, but
Clang and other C/C++ compliant lexers do not. There was already
a workaround to use implicit string concatenation for GCC, but there's
a simpler solution of token pasting the L onto the stringized macro
argument with 'L###macro_arg'. This works with Clang, GCC, and MSVC.
R=jun_fang@foxitsoftware.com, jam@chromium.org
BUG=82385
Original patch by Reid Kleckner <rnk@chromium.org>
Review URL: https://codereview.chromium.org/345643002
|
|
R=jam@chromium.org
Review URL: https://codereview.chromium.org/330023004
|
|
R=jam@chromium.org
Review URL: https://codereview.chromium.org/336563004
|
|
R=jam@chromium.org
Review URL: https://codereview.chromium.org/333753002
|
|
BUG=11
|
|
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/320223003
|
|
BUG=381031
Original patch by Chris Palmer <palmer@chromium.org>
Review URL: https://codereview.chromium.org/322453002
|