Age | Commit message (Collapse) | Author |
|
(I've been doing this by hand for far too long).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1264873005 .
|
|
If you want to check the number of bytes read, you need to
change the order of arguments.
TEST=testing/corpus/fx/mulobj/1/1_10_watermark.pdf.0.png
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1262453006 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1258203005 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1255933006 .
|
|
But use platform freetype for library itself according to the rules
for the platform.
This should greatly reduce per-platform diffs in the corpus tests, but
requires that the corpus be rolled at the same time.
When this rolls into chromium, its src/BUILD.gn will need to be updated
to say third_party:fx_freetype instead of third_party:freetype.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1267493005 .
|
|
This is the cause of the mac embeddertest failure when fx_bool is
replaced by bool (an incorrect overload). The types still
match on master, prior to the conversion, so it's not noticed.
Find other instances as well.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1262683003 .
|
|
The refactoring at fb07e28 removed a null handle check.
BUG=514690
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1261923003 .
|
|
- Bool functions should not return -1 for error.
- Bool variables should not be assigned 2
- Bool / int32_t prototypes should match.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1254973004 .
|
|
It is never defined, and the declspec()s based on it appear
inconsistently used.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1257163002 .
|
|
These are unused until we get to XFA.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1255113003 .
|
|
This reverts commit ff46aaf499edcf153ee2f57c7016587aa96dcfa0.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1255293002 .
|
|
Try to reland this patch after fixing underlying issues that
caused it to be reverted.
fx_system.h is the only manual edit.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1258093002 .
|
|
This is the javascript test failure at 320b2313d198.
The spec says they are booleans, not ints, so correct the behaviour now.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1242263010 .
|
|
This fixes part of the failure encountered at 320b2313d198.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1257503002 .
|
|
This reverts commit 320b2313d19869333ed453af546e61a9fc2b81c9.
Reason for revert: build failure.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1255693002 .
|
|
Fully automatic change, execpt for cleanup in fx_system.h
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1254703002 .
|
|
Extracted from https://codereview.chromium.org/1252613002/
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1253603002 .
|
|
Revert "Revert "Fix else-after-returns throughout pdfium.""
This reverts commit 4eb4d7f6c707cc2c23c806aa540d055c8832b55d.
Fix one naming conflict.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1243953004 .
|
|
This reverts commit 7cc97521db1e52d5927f5605de5f9a7102f8af40.
|
|
Driven by CS search for
pcre:yes file:third_party/pdfium/ -file:pdfium/third_party/
\breturn\b[^;]*;\s*\n*\s*\}*\s*\n*\r*else
Note: Care is required to ensure the preceding block is not an else-if.
As usual, removed any tabs I saw.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1243883003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1249643003 .
|
|
(cherry picked from commit 8a0a834d2aea61fc92590839b86471ac73daa967)
Original Review URL: https://codereview.chromium.org/1247213002 .
Note: inadvertantly landed on XFA first.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1252013002 .
|
|
Make others static while we're at it.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1241173004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1233453014 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1195363002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1242493003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1232203003 .
|
|
- untabify as encountered.
- Only put single-statement method in .h file, move more
complex methods to .cpp (counting an if without braces as
a single statement, killing braces as needed).
- Move invariant arguments to constructor and make
corresponding members const.
- Make all members private and add accessor methods.
- Make existing accessor methods const where possible.
- Kill meaningless asserts.
- Add helper functions in place of duplicate code.
- Rename GetCurrentDoc() to GetSDKDocument(), since the class
has two document members, one of CPDF_Document and one of
CPDFSDK_Document, making it clear which one you get.
- Simplify some logic with early returns.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1235393002 .
|
|
Chrome already uses 0 and 1.
BUG=none
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1235303003 .
|
|
This matches the Chromium PDF plugin changes in
https://codereview.chromium.org/1230313006/
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1237233006 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1219683007 .
|
|
BUG=492055
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1241923005 .
|
|
Kill some unused macros along the way, and put prototypes
in header files.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1233203004 .
|
|
This reverts commit 5bd88ec07e79215400777f3095c6843e0627cade.
|
|
There is no assurance that the expected result files are consistent
with other readers. Jun will have to verify that after making his
parser changes for bug 493126.
BUG=493126
R=thestig@chromium.org, jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1232803005 .
|
|
BUG=none
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1241863003 .
|
|
This reverts commit 304578020122cc4d2a4a8c1598694ef2b9be92b5.
Turns out that in both cases v8 is already destructed at those points,
and we can't pump the message loops.
TBR=tsepez@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1236603003 .
|
|
In Chrome, all Isolates must be created by gin
R=tsepez@chromium.org, ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1234053003 .
|
|
R=tsepez@chromium.org, ulan@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/1230393006 .
|
|
That way, the compiler can check them against the definitions rather
than just relying on the linker to line things up.
Make the types of the declarations and definitions match exactly,
instead of being synonym typedefs of each other.
Fix some IWYU and use FX_ArraySize where possible.
BUG=https://code.google.com/p/pdfium/issues/detail?id=178
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1221503005 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1240713004 .
|
|
Allows the following command to return only legitimate
warnings:
buildtools/checkdeps/checkdeps.py --resolve-dotdot
The remaining warnings consist of:
- fx_parser_filters.cpp, due to inclusion of
third_party/zlib_v128/zlib.h, showing the lack
of a header and some prototypes in that .cpp file.
- third_party/*, due to inclusion of fx_system.h and
the like, indicating adulterated libraries that should
be restored to their pristine state.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1233583004 .
|
|
Fixing this issue for an urgent request. It should be fixed in OpenJPEG side.
BUG=506763
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1231933008 .
|
|
BUG=issue179
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1217093006 .
|
|
Standard delete operator should do noting for nullptr.
Overloaded CJBig2_Object::operator delete de-referenced
provided pointer causing crashes after
https://codereview.chromium.org/1192743004/
TBR=thestig
BUG=508197
Review URL: https://codereview.chromium.org/1230763007 .
|
|
BUG=505296
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1221673007.
|
|
BUG=504699
R=raymes@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1213433005.
|
|
This reverts commit 327080bacabb3d90094144e66ae57037d4a8d8e6.
This re-lands the patch, but removes the tests which would require
512MB buffers to be reliably allocatable on small bots. It
also adds
small fixes accumulated while diagnosing it.
R=sanqingsong@gmail.com
Review URL: https://codereview.chromium.org/1214403002.
|
|
Clang warns if there are missing braces around a subobject
initializer. The most common idiom that triggers this is:
STRUCT s = {0};
if the first field of STRUCT is itself a struct. This can
be more simply written as:
STRUCT s = {};
which also prevents the warning from firing.
Other instances of the warning have been fixed by adding
braces where appropriate.
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1213523004.
|
|
BUG=none
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1223433002.
|