Age | Commit message (Collapse) | Author |
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1296753003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1290383003 .
|
|
They look too much like locals; use JSGlobalData and JSGlobalAlternate
instead. Kill some commented out code.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1289903004 .
|
|
BUG=pdfium:188
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1301473003 .
|
|
BUG=505316
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1293033002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1288053005 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1284193005 .
|
|
- Implement FPDFLink_GetLinkZOrderAtPoint().
- Implement FPDFPage_FormFieldZOrderAtPoint().
- Mark FPDPage_HasFormFieldAtPoint() as deprecated.
- Modify CPDF_LinkList and CPDF_InterForm to support new APIs.
- Clean up dead code in CPDF_LinkList and CPDF_InterForm.
BUG=chromium:515837
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1278053004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1297713003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1287193005 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1292613003 .
|
|
Also remove unused kAddinNameCJK variable.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1296513003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1289693008 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1294723002 .
|
|
BUG=pdfium:46
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1294693002 .
|
|
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1294713002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1291213003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1293673003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1286383004 .
|
|
Cloning a CPDF_Stream actually happens via CPDF_Object::Clone().
Transitively, remove:
- GetStreamFilter()
-- all the filters.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1288543002 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1297453002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1287863002 .
|
|
Also add a missing header file.
BUG=505316
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1285123003 .
|
|
R=thestig@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/d8b5e73d8609b74e6a995ee1768d20d47bd4b089
Review URL: https://codereview.chromium.org/1268323004 .
|
|
This reverts commit d8b5e73d8609b74e6a995ee1768d20d47bd4b089.
Broke corpus tests
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1292153002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1268323004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1278713003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1279493003 .
|
|
BUG=pdfium:117
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1282653002 .
|
|
- Delete unneeded CFFL_ComboBox::CanCopy() and friends.
- Delete unneeded CFFL_FormFiller::CanCopy() and friends.
- Delete unneeded CFFL_TextField::CanCopy() and friends.
- Delete unneeded FormFiller::DoCopy() and friends.
- Rename CFFL_FormFiller::On{Set,Kill}Focus to avoid conflicts.
BUG=pdfium:185
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1283493004 .
|
|
Stub out failing platform entirely
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1276333006 .
|
|
Stub out failing platform.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1280043005 .
|
|
Windows uses the system implementation of itoa which goes
to 36.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1285433002 .
|
|
I thought about removing it, but decided to fix it instead until c++11
hits and there may be better alternatives.
Remove unused variants.
BUG=517854
R=brucedawson@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1274423003 .
|
|
Luckily, it's just one file.
BUG=none
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1281923004 .
|
|
Also add a presubmit that checks for this so I don't have to keep doing it.
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163' | \
xargs ../../buildtools/mac/clang-format -i
BUG=none
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1272653005 .
|
|
(Having renamed CFontFaceInfo to follow naming pattern).
Also cleanup some initialization-order noise in CFX_FontMapper.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1277883004 .
|
|
Adobe acrobat defines keywords "\nendstream\n" and "\nendobj\n" in object's stream.
However, Pdfium searches "endstream" and "endobj" as the keywords in the streams of objects.
Some words like "(endstream)" are wrongly treated as keywords in pdfium.
This fix follows Adobe's solution.
BUG=493126
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1219133005 .
|
|
This, in turn make m_bUseRange always false, so remove it.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1274883002 .
|
|
Move that operation closer to the embedder's call.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1269073003 .
|
|
Hence, some of the routines taking filename strings are unused. This,
in turn allows us to get rid of some other fopen-ishy looking things
inside the library.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1264423003 .
|
|
BUG=chromium:515718
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1269783005 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1259963005 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1256283005 .
|
|
This is the .clang-format file I used to format everything.
BUG=none
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1260183009 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1269223002 .
|
|
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163' | \
xargs ../../buildtools/mac/clang-format -i
See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion.
BUG=none
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1265503005 .
|
|
FX_HFILE, and the routines that operate on it, are unused.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1259123008 .
|
|
Nearly a naming-only change, but add one argument to constructor.
grep now shows:
class CFX_AndroidFontInfo : public IFX_SystemFontInfo
class CFX_Win32FontInfo final : public IFX_SystemFontInfo
class CFX_ExternalFontInfo final : public IFX_SystemFontInfo
class CFX_FolderFontInfo : public IFX_SystemFontInfo
class CFX_MacFontInfo : public CFX_FolderFontInfo
class CFX_LinuxFontInfo : public CFX_FolderFontInfo
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1257743005 .
|
|
The design envisioned two kinds of font mappers: internal
(of type CFX_FontMapper), and external, both of which
implement a common interface. But there isn't any means of
making an external one, so the interface is redundant.
IFX_FontMapper also appears in an apple-specific struct,
but was never non-null or used in any way.
The CFX_FontMapper class provides its own mechanism to
include platform-specific features, as it turns out.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1259123005 .
|