summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-12-06fix for stream object readingWei Li
Loosen a check for earlier version of PDF files. When the bytes with specified length are followed by 'endstream' keyword, even if there is no EOL marker before the keyword, it signals the end of stream. BUG=551258 R=jun_fang@foxitsoftware.com, tsepez@chromium.org Review URL: https://codereview.chromium.org/1499433002 .
2015-12-04Fix an incorrect check in CPDF_DataAvail::CheckHintTables.Oliver Chang
R=tsepez@chromium.org, jun_fang@foxitsoftware.com BUG=566179 Review URL: https://codereview.chromium.org/1504513002 .
2015-12-03Revert downstream patch to libopenjpeg2000Nico Weber
This reverts https://codereview.chromium.org/1405553003/ clang-cl now understands __emul. BUG=543182 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1491933006 .
2015-12-02Increase default timeout in valgrind_test.py for running corpus tests with ↵Qin Zhao
Dr. Memory TBR=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1486413005 .
2015-12-01Add basic checking for RebuildCrossRefWei Li
RebuildCrossRef function returns false when we can not find file trailer or any indirect object. This serves as a basic file format checking. BUG=pdfium:215 R=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1476163002 .
2015-11-30Add README in tools/drmemory for using Dr. MemoryQin Zhao
R=tsepez@chromium.org BUG=PDFium:238 Review URL: https://codereview.chromium.org/1471073011 .
2015-11-26Android: look for OTF files as well as TTF and TTC.Andrew Olsen
BUG=pdfium:288 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1476173003 .
2015-11-25Merge to master: Take Jun's UTF16LE patches.Tom Sepez
(cherry picked from commit 8d89e65897d8b6cf7899e7a82d9d381c3ad327cb) (cherry picked from commit c70b19aad245fb1ed39bf8c264d991555f4c5a58) BUG=pdfium:275 TBR=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1473753004 .
2015-11-25master: more underlying typesTom Sepez
Precursor to https://codereview.chromium.org/1477583002/ Also: merge where possible. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1481523004 .
2015-11-25Re-order methods to make xfa diff sanerTom Sepez
Precursor to making fpdf_text_int.cpp match cleanly. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1477433006 .
2015-11-25CFXJS_ObjDefinition's lifetime must match isolate.chromium/2585chromium/2584chromium/2583chromium/2582chromium/2581chromium/2580chromium/2579chromium/2578chromium/2577chromium/2576Tom Sepez
Introduced at https://codereview.chromium.org/1424933013/ The v8 objects are 1:1 with the context being destroyed in FXJS_ReleaseRuntime, but the CFXJS_ObjDefinitions are still 1:1 with the isolate, so they can't be destroyed until the refcounts hit zero. BUG=561184 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1468423004 .
2015-11-25Suppress invalid-heap-arg error in pdfium_unittestsQin Zhao
Visual Studio sometimes uses new instead of new[] for array allocation, which causes Dr. Memory report invalid-heap-arg errors. Suppress such errors since it is not developers' problems. TBR=tsepez@chromium.org BUG=pdfium:287 Review URL: https://codereview.chromium.org/1473913002 .
2015-11-25Fix two memory leaks from pdfium_unittestsQin Zhao
- remove redundant alloc in fx_codec_jpx_unittest.cpp - free memory allocated by HexDecode calls in fpdf_parser_decode_unittest.cpp BUG=PDFium:239 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1467183006 .
2015-11-24make master samples/ and public/ look more like XFATom Sepez
BUG= R=thestig@chromium.org Review URL: https://codereview.chromium.org/1477603002 .
2015-11-24Re-virtualize CFX_UnicodeEncoding.Tom Sepez
It's not required on master, but it costs very little and makes XFA line up more closely. Also make InitFTLibrary() public for the same reasons. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1475643003 .
2015-11-24Add "Underlying types" to master.Tom Sepez
Change some master code to line up better with XFA, so that the XFA changes are additive when possible, rather than replacements. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1468253005 .
2015-11-24Update pdfium_tests.py to run pdfium tests with Dr. Memory on buildbotsQin Zhao
- update pdfium_tests.py to setup Dr. Memory so it can be used directly without pdfium_tests.bat on buildbots R=thestig@chromium.org BUG=PDFium:238 Review URL: https://codereview.chromium.org/1478453002 .
2015-11-24Fix a NULL pointer crash in the CJBig2_Image copy constructor.Lei Zhang
Also change the copy ctor to take a const ref. BUG=560520 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1472113002 .
2015-11-23Adjust Dr. Memory suppressionQin Zhao
- widening suppression for DrM-i#471 TBR=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1467373003 .
2015-11-23Enable Dr. Memory to run javascript, pixel, and corpus testschromium/2575chromium/2574Qin Zhao
- add DrMemoryWrapper in common.py to adjust Dr. Memory wrapper - add --wrapper option to run_*_tests.py for Dr. Mempry wrapper - update run_*_tests.py to handle Dr. Memory wrapper - add TestPDFiumTest in pdfium_tests.py to support run_*_tests.py - remove ValgrindTool in valgrind_tests.py R=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1464453003 .
2015-11-20Add constant CPDFSDK_InterForm::kNumFieldTypesTom Sepez
Bumping this one line from 6 to 7 in XFA saves a bunch of diffs. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1458363005 .
2015-11-20Replace |CPWL_ComboBox::operator CPWL_Edit()| with explicit method.Tom Sepez
More casts go away. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1467653002 .
2015-11-20Roll DEPS for V8 to cf7614d.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1466033002 .
2015-11-20Change |CCodec_ScanlineDecoder::m_Pitch| to FX_DWORDOliver Chang
This matches the type of the corresponding |CFX_DIBSource::m_Pitch|, where integer overflow is checked for FX_DWORD. This change is propagated to many other places. Also, check for integer overflow in |CCodec_RLScanlineDecoder::Create| during the calculation of |m_Pitch| since it aligns to 4 bytes while overflow was was previously checked without this alignment. R=tsepez@chromium.org, thestig@chromium.org BUG=555784 Review URL: https://codereview.chromium.org/1460033002 .
2015-11-20Update master fpdfsdk to match XFATom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1458853005 .
2015-11-20Initialize V8 before starting embedder testsJochen Eisinger
BUG=none R=thestig@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1462313002 .
2015-11-19Cache object numbers in CPDF_Parser::ParseIndirectObject().Lei Zhang
R=jun_fang@foxitsoftware.com, tsepez@chromium.org Review URL: https://codereview.chromium.org/1458633004 .
2015-11-19Add more overrides.Lei Zhang
Using Chromium's clang + build options, there's more override warnings. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1453643002 .
2015-11-19During presubmit, look in parent directories for buildtools/checkdeps.Lei Zhang
This may be useful when PDFium is not a standalone checkout. R=hans@chromium.org Review URL: https://codereview.chromium.org/1464733002 .
2015-11-19Add a missing setjmp() to CCodec_JpegDecoder::v_GetNextLine().Oliver Chang
If jpeg_read_scanlines() ends up calling the error callback, we longjmp into some undefined state. BUG=558840 R=thestig@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1463563003 .
2015-11-19Remove CFX_Matrix::Reset()Tom Sepez
It's unused on master, and on XFA, directly calling SetIdentity() is clearer to the reader anyways. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1459243002 .
2015-11-19Make core in master match XFA.Tom Sepez
This weeks version, mostly whitespace. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1466503002 .
2015-11-19Remove unused functionchromium/2573chromium/2572chromium/2571chromium/2570chromium/2569Hans Wennborg
It was breaking the Windows Clang build. BUG=82385 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1459723005 .
2015-11-18Add Dr. Memory suppression file for pdfium testschromium/2568Qin Zhao
- add suppressions.txt in tools/drmemory/ - update pdfium_tests.py to read suppression file R=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1454193002 .
2015-11-18Fix ASan gn build (chromium).Oliver Chang
R=thestig@chromium.org, thakis@chromium.org BUG=556808 Review URL: https://codereview.chromium.org/1452013004 .
2015-11-18Add Dr. Memory toolQin Zhao
This CL adds DrMemory-Windows-sfx.exe into tools/drmemory. It also adds a set of scripts from chromium/src/tools/valgrind for running Dr. Memory. Now we can run pdfium tests with Dr. Memory: $ .\tools\drmemory\scripts\pdfium_tests.bat -b out\Debug -t pdfium_unittests More update on scripts is required, but this should be a good start. Changes from chromium/src/tools/valgrind - rename chrome_tests.py to pdfium_tests.py - update pdfium_tests.bat - remove chrome tests in pdfium_tests.py - remove memcheck code in valgrind_test.py R=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1452293002 .
2015-11-17Fix typo from commit r447946588d6b.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1452843005 .
2015-11-17Fix Windows build after commit 9c62cadff466.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1456823002 .
2015-11-17Make CPDF_InterForm::AddStandardFont take a non-const document pointer.Lei Zhang
Instead of taking a const pointer, and then casting away the const-ness. Also remove similar, but dead CPDF_InterForm methods. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1456763003 .
2015-11-17Add more fxcrt string sanity tests.Lei Zhang
Sadly I've gotten these to fail with Chromium debug builds. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1447163004 .
2015-11-16Reland "Cleanup some numeric code.""chromium/2567Dan Sinclair
This reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1. This changes the various comparisons of char >= '0' && char <= '9' and char < '0' || char > '9' to use std::isdigit checks. It also cleans up a handful of hex to digit conversions to call one common method. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1449873003 .
2015-11-13Check DEPS during presubmit before uploads.Lei Zhang
Also run presubmit checks before committing. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1434393003 .
2015-11-12Fix another typo in BUILD.gnOliver Chang
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1438253004 .
2015-11-12Remove relative includes.Lei Zhang
That refer to parent directories. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1434223002 .
2015-11-12Fix typos in BUILD.gn.chromium/2566chromium/2565Oliver Chang
Accidentally reverted this while rebasing another CL. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1441473004 .
2015-11-12Clear decoders after the image decoder in the /Filter array.Oliver Chang
During decoding, when an image decoder is encountered, any subsequent decoders are ignored, but remain in the array. However, later on CPDF_DIBSource::ValidateDictParam expects the image decoder to be the last in the array, causing issues. A check is also added in CPDF_DIBSource::GetScanline to ensure that the calculated pitch value is <= the (4-aligned) pitch value in the cached bitmap to prevent future issues. Also cleans up some NULL usages. BUG=552046 R=jun_fang@foxitsoftware.com, tsepez@chromium.org Review URL: https://codereview.chromium.org/1406943005 .
2015-11-11Revert "Roll DEPS for v8 to ab1165f. Regular weekly roll."Lei Zhang
This reverts commit 44a4de0b4bd5148396b2b0de1353dafee6a4c418. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1440513004 .
2015-11-11Roll DEPS for v8 to ab1165f. Regular weekly roll.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1437043002 .
2015-11-11Fix / simplify CFX_FolderFontInfo::GetFontData() behavior.Lei Zhang
The GetFontData() behavior in FPDF_SYSFONTINFO seems reasonable. Also do some code cleanup. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1425023003 .
2015-11-11(Reland) Fix extraction of colour components in ↵Oliver Chang
CPDF_DIBSource::DownSampleScanline32Bit Previously, if |m_bpc| was < 8 (e.g. 4), this function may still try to access the source components as if |m_bpc| == 8. Even when it fell into the codepath that tried to do the right thing in this case, it was wrong. BUG=554151 R=tsepez@chromium.org, thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9b99615806e358fdb396d1cb162ee2e69c2a20ec Review URL: https://codereview.chromium.org/1433423002 .