Age | Commit message (Collapse) | Author |
|
I'm trying to disallow this since it's confusing. It looks like it provides
scoping for the inner config, but it is actually no different than declaring
the config at the top level. For clarify, all configs and targets should be
declared at the top level.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1328443003 .
|
|
BUG=pdfium:193
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1306793002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1321883002 .
|
|
Based on an earlier patch by jun_fang@foxitsoftware.com.
BUG=450844
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1320443003 .
|
|
- Break up CPDF_DIBSource::DownSampleScanline() into smaller functions.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1287843004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1293393002 .
|
|
Fixes the remaining issues, except for JBIG2/Skia ...
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1298393003 .
|
|
Part 1. Move to headers so compiler can type check against
the definitions.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1299963002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1297303002 .
|
|
- Make methods const.
- Make variables non-public.
- Remove LoadFile() method.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1293973002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1297593005 .
|
|
Lookups are log(n), but random insertions could result in n^2
behaviour. Replace with maps and sets.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1289703003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1294683003 .
|
|
- Replace IFX_BidiChar with just CFX_BidiChar
- Document implementation
- Change out parameters to pointers
- Remove dead code
- Add an enum for bidi directions
- Move several externs to a header
- Add unit tests
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1197643002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1296383004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1296403002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1293153003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1287053006 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1297723002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1296753003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1290383003 .
|
|
They look too much like locals; use JSGlobalData and JSGlobalAlternate
instead. Kill some commented out code.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1289903004 .
|
|
BUG=pdfium:188
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1301473003 .
|
|
BUG=505316
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1293033002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1288053005 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1284193005 .
|
|
- Implement FPDFLink_GetLinkZOrderAtPoint().
- Implement FPDFPage_FormFieldZOrderAtPoint().
- Mark FPDPage_HasFormFieldAtPoint() as deprecated.
- Modify CPDF_LinkList and CPDF_InterForm to support new APIs.
- Clean up dead code in CPDF_LinkList and CPDF_InterForm.
BUG=chromium:515837
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1278053004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1297713003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1287193005 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1292613003 .
|
|
Also remove unused kAddinNameCJK variable.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1296513003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1289693008 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1294723002 .
|
|
BUG=pdfium:46
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1294693002 .
|
|
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1294713002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1291213003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1293673003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1286383004 .
|
|
Cloning a CPDF_Stream actually happens via CPDF_Object::Clone().
Transitively, remove:
- GetStreamFilter()
-- all the filters.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1288543002 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1297453002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1287863002 .
|
|
Also add a missing header file.
BUG=505316
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1285123003 .
|
|
R=thestig@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/d8b5e73d8609b74e6a995ee1768d20d47bd4b089
Review URL: https://codereview.chromium.org/1268323004 .
|
|
This reverts commit d8b5e73d8609b74e6a995ee1768d20d47bd4b089.
Broke corpus tests
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1292153002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1268323004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1278713003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1279493003 .
|
|
BUG=pdfium:117
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1282653002 .
|
|
- Delete unneeded CFFL_ComboBox::CanCopy() and friends.
- Delete unneeded CFFL_FormFiller::CanCopy() and friends.
- Delete unneeded CFFL_TextField::CanCopy() and friends.
- Delete unneeded FormFiller::DoCopy() and friends.
- Rename CFFL_FormFiller::On{Set,Kill}Focus to avoid conflicts.
BUG=pdfium:185
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1283493004 .
|
|
Stub out failing platform entirely
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1276333006 .
|