summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-10-20Revert "Revert "Add type cast definitions for CPDF_Dictionary.""Dan Sinclair
This reverts commit 937840e1722d1f2b77d80575d6e710d760662c9c. Add type cast definitions for CPDF_Dictionary. This CL adds ToCPDFDictionary type definitions and updates one file to use instead of straight casts. I had to fix two places where we'd casted off the constness of the original pointer. BUG=pdfium:201 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1420583003 .
2015-10-20Minor documentation updates for fpdfview.h.Dan Sinclair
This does some minor copy editing and formatting of the documentation in the fpdfview.h header. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1411863004 .
2015-10-20Revert "Make CFX_FontMgr member variables private."Lei Zhang
This reverts commit c29bee029cd5fe3f8a4ceb580235ac2d0e5ce8fd. because it broke corpus tests. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1410733005 .
2015-10-20Revert "Add type cast definitions for CPDF_Dictionary."Dan Sinclair
This reverts commit 4816432671eef6467354aa252f22bb80acc315b7. Reason, broke the javascript_test Rendering PDF file /mnt/data/b/build/slave/linux/build/pdfium/out/Debug/gen/pdfium/testing/javascript/document_methods.pdf. Non-linearized path... FAILURE: document_methods.in; Command '['/mnt/data/b/build/slave/linux/build/pdfium/out/Debug/pdfium_test', '/mnt/data/b/build/slave/linux/build/pdfium/out/Debug/gen/pdfium/testing/javascript/document_methods.pdf']' returned non-zero exit status -11 BUG=pdfium:201 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1412413002 .
2015-10-20Make CFX_FontMgr member variables private.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1405213003 .
2015-10-20Add type cast definitions for CPDF_Dictionary.Dan Sinclair
This CL adds ToCPDFDictionary type definitions and updates one file to use instead of straight casts. I had to fix two places where we'd casted off the constness of the original pointer. BUG=pdfium:201 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1399233003 .
2015-10-19Remove unused CFFL_Notify.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1411963002 .
2015-10-19Fix some override warnings in fpdfview.cpp.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1410733004 .
2015-10-19Remove duplicate core/include/thirdparties headers.Tom Sepez
These are unused in favor of the ones under the top-level third_party/ directory. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1417483004 .
2015-10-19Remove dead code that was reactivated when fixing overrides.chromium/2545chromium/2544chromium/2543chromium/2542chromium/2541Lei Zhang
BUG=pdfium:205 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1409743004 .
2015-10-19Consolidate test support code.Tom Sepez
Removes duplication between pdfium_test and pdfium_embeddertest R=thestig@chromium.org Review URL: https://codereview.chromium.org/1416713002 .
2015-10-19Sanity check the values of TRUE and FALSE.Lei Zhang
Get rid of cond ? TRUE : FALSE. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1405723003 .
2015-10-19Remove some checks for object creation failures. They cannot fail.Lei Zhang
Also reduce nesting in if statements, remove CFX_SmartPointer, and use more unique_ptrs. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1393303004 .
2015-10-19Add FPDFAPIJPEG_ prefix to more libjpeg functionsTom Sepez
Original patch by Evangelos Foutras. Chromium built with use_system_libjpeg=1 can mistakenly try to use symbols exported by the libjpeg library that's bundled with pdfium. These name conflicts result in failure to encode the contents of a canvas element using toDataURL('image/jpeg'). BUG=505226 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1409243004 .
2015-10-19Unrevert commit a398ca6 and apply the proper fix.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1401493002 .
2015-10-19Revert "Switch builds to clang by default for Linux and OS X."Oliver Chang
This reverts commit 5478df43a8970257e9644ae6f57a6fe7513029c6. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1413193002 .
2015-10-19Switch builds to clang by default for Linux and OS X.Oliver Chang
Also adds support for ASan and sanitizer coverage. BUG=pdfium:1,pdfium:171 R=thakis@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1406843002 .
2015-10-16Don't bother passing -1 as the length to the CFX_ByteString ctor.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1406363002 .
2015-10-16Declare PDF_GetStandardFontName() in the header.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1410043003 .
2015-10-16fxcrt convergence - master sideTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1410933002 .
2015-10-16Fix stray backslashes in README.mdTom Sepez
TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1414463002 .
2015-10-16Update link to chromium src.dan sinclair
This CL updates the documentation link to the Chromium PDF plugin to point to Gitiles instead of the SVN repo. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1407313002 .
2015-10-16DEPS include_rules no longer allows core/ -> fpsdfsk/ inclusion.Tom Sepez
Adds the following new violations: ERROR in core/include/fpdfapi/fpdf_parser.h Illegal include: "public/fpdfview.h" ERROR in core/include/fpdfapi/fpdf_render.h Illegal include: "public/fpdf_progressive.h" ERROR in core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp Illegal include: "public/fpdfview.h" BUG=pdfium:217 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1411493002 .
2015-10-16Loosen checking on the bytes following 'stream'chromium/2540chromium/2539chromium/2538Jun Fang
PDF specs say that end of line markers shall follow the keyword "stream". But a white space before end of line markers follows this keyword in the test pdf files. BUG=543018 R=thestig@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1401923005 .
2015-10-15Move conditionals inside target_defaults.dan sinclair
This CL moves the conditionals inside the target_defaults configuration. This causes the -fPIC to get picked up and allows component=shared_library to build correctly. BUG=pdfium:218 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1407903002 .
2015-10-15Add some community and testing info to README.md.dan sinclair
This CL adds some more context to the README on the various test suites and community mailing lists which are available. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1412453004 .
2015-10-15Plug a leak in CPDF_StreamParser::ReadInlineStreamOliver Chang
R=thestig@chromium.org, tsepez@chromium.org BUG=pdfium:212 Review URL: https://codereview.chromium.org/1405203002 .
2015-10-15Introduce CPDFPageFromFPFDPage()Tom Sepez
Abstracts the way that pages are passed to the embedder between XFA and master. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1406543004 .
2015-10-15Return result of GetRBG instead of TRUEdan sinclair
Propagate the return value of GetRBG to the callers instead of forcing the return of TRUE. BUG=pdfium:44 R=thestig@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1398633008 .
2015-10-15Add steps for Contributing Code to README.mdTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1413493002 .
2015-10-15Fix layering violation in CPDF_Document::FromFPDFDocument().Tom Sepez
Make this a function in the fpdfsdk/ layer, rather than a method in the core/ layer. Nothing in core should know about public FPDF types. BUG=pdfium:217 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1396283006 .
2015-10-14Introduce CPDF_Document::FromFPDFDocument().Tom Sepez
This will be used to abstract one major difference between master and XFA, namely that the CPDF_Document is not a direct cast in XFA. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1395493007 .
2015-10-14Next round of master changes to match XFATom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1401423004 .
2015-10-14Land temporary workaround for clang-cl not yet understanding __emulchromium/2537chromium/2536Nico Weber
BUG=543182 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1405553003 .
2015-10-14Add unit test for top-level bookmarks.Tom Sepez
Null FPDF_BOOKMARK represents the "root" bookmark, and must not segv when asking about titles or children. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1404723002 .
2015-10-13Roll DEPS for v8 to d3f97a9. Regular weekly roll.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1407643002 .
2015-10-13Revert "Remove IPDFSDK_AnnotHandler interface."chromium/2535Tom Sepez
This reverts commit 633f1e436e1cced874a44a797f02c452eb3cf958. This restores IPDFSDK_AnnotHandler, which is pointless on master but useful on XFA. The small gain on master isn't worth the noise when diffing to XFA. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1408513002 .
2015-10-13Changes to master to more closely match XFA.Tom Sepez
These files should change in master in order to reduce the number of "noise diffs" between master and XFA as seen in https://codereview.chromium.org/1399273003/ This includes: whitespace, matching header ordering, and implementing a GetPageFromFPDFPage() from XFA. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1407583004 .
2015-10-13wstring allocations waste up to 7 wasted bytes.Tom Sepez
Consequence of having the same code in two places; fx_basic_bstring.cpp is correct, but fx_basic_wstring.cpp is missing one small change. Noticed while working on 542403, but this will not fix that issue. It is just a space savings. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1399983003 .
2015-10-13upgrade openjpeg to commit# cf352afJun Fang
BUG=457480,497355 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1338973005 .
2015-10-09Sanitize CJBig2_SymbolDict's memory usage.chromium/2534chromium/2533chromium/2532Lei Zhang
- Use std::vector<JBig2ArithCtx> instead of storing pointers to arrays. - Make CJBig2_SymbolDict's members private with accessors. - Use std::vector<JBig2ArithCtx> in related places. - Steal Chromium's vector_as_array() and use it as an adaptor as needed. BUG=514891 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1388203003 .
2015-10-09Parallelize run_corpus_tests.py.Lei Zhang
- Use the number of cores as the default -j value - Fall back to old code for -j 1 R=nparker@chromium.org Review URL: https://codereview.chromium.org/1398793003 .
2015-10-09Pass IJS_Runtime, not IJS_Context, to native object constructors.Tom Sepez
This better separates the two IJS_ classes, with the IJS_Context taking on its proper role of describing an event. There's no need for the event details for object creation, so this gets much cleaner. Move some JS error reporting code from CJS_Context to CJS_Runtime. Make InitInstance() and ExitInstance() voids, they always return TRUE and we never check the result anyways. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1389163007 .
2015-10-09Allow compiling PDFium without V8.Tom Sepez
Original patch from issue 1391843004 at patchset 1 (http://crrev.com/1391843004#ps1) Introduce a pdf_enable_v8 GYP variable, which controls a corresponding PDF_ENABLE_V8 #define, and bring in the real JS library when set. Otherwise, link against a stub JS runtime. BUG=pdfium:211 R=dml@google.com, jochen@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1395733006 .
2015-10-09Fix a bad refactoring error from commit 8a9ce57.Lei Zhang
BUG=541323 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1400773002 .
2015-10-09Fix a compiling error on MacJun Fang
BUG=497357 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1395493003 .
2015-10-09Fix heap-buffer-overflow in color_sycc_to_rgbJun Fang
It's a bug existing in the conversion from YUV420 to RGB. For YUV 420 format, four pixels have 4 Y but only one U and one V. In some cases, there are odd columns or lines in some images. The pixels on last line or column may have Y but no U or V data. For this case, We shall extend U or V using the data on previous column or line. BUG=497357 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1342683002 .
2015-10-08Minimal revert from commit d03ba8d.Lei Zhang
The values that were changed to size_t can go negative. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1400723002 .
2015-10-08Fix a bunch of sign mismatch warnings.Lei Zhang
Also remove some gotos and move code into an anonymous namespace. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1356373003 .
2015-10-08Fix a malloc/delete mismatch introduced in commit 8a9ce57.Lei Zhang
Just get rid of the malloc altogether and use CJBig2_List instead. BUG=540873 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1394933002 .