Age | Commit message (Collapse) | Author |
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1543413002 .
|
|
This reverts commit 054fc955c153eb5c581fd14946848b8b2a77136a.
Additionally, this rolls DEPS for the testing corpus to update test
expectations.
BUG=pdfium:336
TBR=jun_fang@foxitsoftware.com
Original Review URL: https://codereview.chromium.org/1555773003
Review URL: https://codereview.chromium.org/1555833002 .
|
|
This reverts commit 84f6a5616be0a1988d361a4b54eb83fff8b8c59f.
BUG=pdfium:336
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1554883002 .
|
|
This reverts commit e67f618a7c31c1746cba590482e59d5a8849ff73.
BUG=pdfium:336
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1553893002 .
|
|
BUG=pdfium:336
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1554773004 .
|
|
BUG=pdfium:336
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1555773003 .
|
|
BUG=482206
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1551563002 .
|
|
cross-reference table
BUG=pdfium:342
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1550753002 .
|
|
Found with Clang's -Wimplicit-fallthrough option by tzik@chromium.org.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1549283002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1546133002 .
|
|
Matches https://crrev.com/366832
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1546103002 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1548963004 .
|
|
BUG=546744
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1542373002 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
|
|
Otherwise CheckLinearizedFirstPage() has no other callers.
BUG=pdfium:330
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1543193002 .
|
|
BUG=571752
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1549073002 .
|
|
BUG=pdfium:338
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1549043003 .
|
|
BUG=pdfium:277
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1548583002 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1542353002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1549063002 .
|
|
BUG=pdfium:335
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1549863002 .
|
|
BUG=pdfium:335
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1549013002 .
|
|
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1544953002 .
|
|
This reverts commit 302199492ef6260010310002bb2280433fd2a194.
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1547843002 .
|
|
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1543063002 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1545823002 .
|
|
R=dml@google.com, thakis@chromium.org
Review URL: https://codereview.chromium.org/1544923002 .
|
|
This reverts commit 2d63eaaa39bb3d402c658b2a6e0eae50a30f1d89.
Broke the Windows build, though it is likely the code is unused on
Windows too.
Review URL: https://codereview.chromium.org/1540993004 .
|
|
- Simplify remaining encoders.
- Hook up more of the encoding paths so failures get returned.
- Clean up code to not pass by non-const ref, use bools, etc.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1545563003 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540263003 .
|
|
This improvements memory usage in case PDFs have sparse object numbers.
The map holds a struct that currently has only one member. The struct
will contain more members as other internal data structures get
converted.
BUG=pdfium:111
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1539573003 .
|
|
- Use FXSYS_iswdigit() instead of CJS_PublicMethods::IsDigit().
- Ditto for FXSYS_iswalpha() and FXSYS_iswalnum().
- Change CJS_PublicMethods::ParseNormalDate() and
CJS_PublicMethods::MakeRegularDate() to take an out parameter by ptr.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1539113002 .
|
|
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1544493003 .
|
|
BUG=515137,564736
R=ochang@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1533233002 .
|
|
BUG=514514
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1536223002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1536923002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540693002 .
|
|
BUG=566063
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1534323002 .
|
|
Also defines ADDRESS_SANITIZER and LEAK_SANITIZER for ASan builds.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1540433004 .
|
|
Rename a few other things along the way:
CPDF_ProgressiveImageLoaderHandle becomes ImageLoaderHandle,
since its the only kind, and stop casting it to void*.
CPDF_ImageLoader::StartLoadImage() becomes Start(), since
the rest is redundant.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1535243002 .
|
|
Orignal Review URL: https://codereview.chromium.org/1539983002 .
(cherry picked from commit 0fa6fee0e48af8681f0cd50f6a9471ecc0a46c11)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1536123002 .
|
|
Apart from it never being initialized, note that m_status
is never set to 1, so the only path that references this
class can't be reached.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1537103002 .
|
|
R=thestig@chromium.org, dml@google.com
BUG=pdfium:327
Review URL: https://codereview.chromium.org/1536113002 .
|
|
BUG=pdfium:329
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1529173005 .
|
|
An email address contains user name part and host name part.
User name allows dash or underscore, but not leading/ending/double
period. Host name doesn't allow leading/ending/double
period either.
BUG=489107
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1530763005 .
|
|
It looks like an key length of 0 was incorrectly assumed to
denote an free entry.
Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.
R=tsepez@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1534953002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1534003002 .
|
|
- Remove unused Clear() method.
- Replace Create() with actual ctors.
- Avoid const casts.
- Protect members.
- Add missing const in adjacent code.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1536623004 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1533763002 .
|
|
Also fix a newly introduced override warning.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1532723003 .
|