Age | Commit message (Collapse) | Author |
|
The root cause is that FXFONT_SUBST_EXACT is wrongly
set even no any subset font was found. It causes
m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load().
BUG=534945
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1502083002 .
|
|
Loosen a check for earlier version of PDF files. When the bytes with
specified length are followed by 'endstream' keyword, even if there is
no EOL marker before the keyword, it signals the end of stream.
BUG=551258
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1499433002 .
|
|
R=tsepez@chromium.org, jun_fang@foxitsoftware.com
BUG=566179
Review URL: https://codereview.chromium.org/1504513002 .
|
|
This reverts https://codereview.chromium.org/1405553003/
clang-cl now understands __emul.
BUG=543182
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1491933006 .
|
|
Dr. Memory
TBR=thestig@chromium.org
BUG=pdfium:238
Review URL: https://codereview.chromium.org/1486413005 .
|
|
RebuildCrossRef function returns false when we can not find file trailer
or any indirect object. This serves as a basic file format checking.
BUG=pdfium:215
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1476163002 .
|
|
R=tsepez@chromium.org
BUG=PDFium:238
Review URL: https://codereview.chromium.org/1471073011 .
|
|
BUG=pdfium:288
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1476173003 .
|
|
(cherry picked from commit 8d89e65897d8b6cf7899e7a82d9d381c3ad327cb)
(cherry picked from commit c70b19aad245fb1ed39bf8c264d991555f4c5a58)
BUG=pdfium:275
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1473753004 .
|
|
Precursor to https://codereview.chromium.org/1477583002/
Also:
merge where possible.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1481523004 .
|
|
Precursor to making fpdf_text_int.cpp match cleanly.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477433006 .
|
|
Introduced at https://codereview.chromium.org/1424933013/
The v8 objects are 1:1 with the context being destroyed in
FXJS_ReleaseRuntime, but the CFXJS_ObjDefinitions are still
1:1 with the isolate, so they can't be destroyed until the
refcounts hit zero.
BUG=561184
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1468423004 .
|
|
Visual Studio sometimes uses new instead of new[] for array allocation,
which causes Dr. Memory report invalid-heap-arg errors.
Suppress such errors since it is not developers' problems.
TBR=tsepez@chromium.org
BUG=pdfium:287
Review URL: https://codereview.chromium.org/1473913002 .
|
|
- remove redundant alloc in fx_codec_jpx_unittest.cpp
- free memory allocated by HexDecode calls in fpdf_parser_decode_unittest.cpp
BUG=PDFium:239
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1467183006 .
|
|
BUG=
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477603002 .
|
|
It's not required on master, but it costs very little and
makes XFA line up more closely. Also make InitFTLibrary()
public for the same reasons.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1475643003 .
|
|
Change some master code to line up better with XFA, so
that the XFA changes are additive when possible, rather
than replacements.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1468253005 .
|
|
- update pdfium_tests.py to setup Dr. Memory so it can be used directly without
pdfium_tests.bat on buildbots
R=thestig@chromium.org
BUG=PDFium:238
Review URL: https://codereview.chromium.org/1478453002 .
|
|
Also change the copy ctor to take a const ref.
BUG=560520
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1472113002 .
|
|
- widening suppression for DrM-i#471
TBR=thestig@chromium.org
BUG=pdfium:238
Review URL: https://codereview.chromium.org/1467373003 .
|
|
- add DrMemoryWrapper in common.py to adjust Dr. Memory wrapper
- add --wrapper option to run_*_tests.py for Dr. Mempry wrapper
- update run_*_tests.py to handle Dr. Memory wrapper
- add TestPDFiumTest in pdfium_tests.py to support run_*_tests.py
- remove ValgrindTool in valgrind_tests.py
R=thestig@chromium.org
BUG=pdfium:238
Review URL: https://codereview.chromium.org/1464453003 .
|
|
Bumping this one line from 6 to 7 in XFA saves a bunch of diffs.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1458363005 .
|
|
More casts go away.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1467653002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1466033002 .
|
|
This matches the type of the corresponding |CFX_DIBSource::m_Pitch|,
where integer overflow is checked for FX_DWORD. This change is
propagated to many other places.
Also, check for integer overflow in |CCodec_RLScanlineDecoder::Create|
during the calculation of |m_Pitch| since it aligns to 4 bytes while
overflow was was previously checked without this alignment.
R=tsepez@chromium.org, thestig@chromium.org
BUG=555784
Review URL: https://codereview.chromium.org/1460033002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1458853005 .
|
|
BUG=none
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1462313002 .
|
|
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1458633004 .
|
|
Using Chromium's clang + build options, there's more override warnings.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1453643002 .
|
|
This may be useful when PDFium is not a standalone checkout.
R=hans@chromium.org
Review URL: https://codereview.chromium.org/1464733002 .
|
|
If jpeg_read_scanlines() ends up calling the error callback, we longjmp
into some undefined state.
BUG=558840
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1463563003 .
|
|
It's unused on master, and on XFA, directly calling
SetIdentity() is clearer to the reader anyways.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1459243002 .
|
|
This weeks version, mostly whitespace.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1466503002 .
|
|
It was breaking the Windows Clang build.
BUG=82385
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1459723005 .
|
|
- add suppressions.txt in tools/drmemory/
- update pdfium_tests.py to read suppression file
R=thestig@chromium.org
BUG=pdfium:238
Review URL: https://codereview.chromium.org/1454193002 .
|
|
R=thestig@chromium.org, thakis@chromium.org
BUG=556808
Review URL: https://codereview.chromium.org/1452013004 .
|
|
This CL adds DrMemory-Windows-sfx.exe into tools/drmemory.
It also adds a set of scripts from chromium/src/tools/valgrind for
running Dr. Memory. Now we can run pdfium tests with Dr. Memory:
$ .\tools\drmemory\scripts\pdfium_tests.bat -b out\Debug -t pdfium_unittests
More update on scripts is required, but this should be a good start.
Changes from chromium/src/tools/valgrind
- rename chrome_tests.py to pdfium_tests.py
- update pdfium_tests.bat
- remove chrome tests in pdfium_tests.py
- remove memcheck code in valgrind_test.py
R=thestig@chromium.org
BUG=pdfium:238
Review URL: https://codereview.chromium.org/1452293002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1452843005 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1456823002 .
|
|
Instead of taking a const pointer, and then casting away the const-ness.
Also remove similar, but dead CPDF_InterForm methods.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1456763003 .
|
|
Sadly I've gotten these to fail with Chromium debug builds.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1447163004 .
|
|
This reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1449873003 .
|
|
Also run presubmit checks before committing.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1434393003 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1438253004 .
|
|
That refer to parent directories.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1434223002 .
|
|
Accidentally reverted this while rebasing another CL.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1441473004 .
|
|
During decoding, when an image decoder is encountered, any
subsequent decoders are ignored, but remain in the array. However,
later on CPDF_DIBSource::ValidateDictParam expects the image
decoder to be the last in the array, causing issues.
A check is also added in CPDF_DIBSource::GetScanline to ensure
that the calculated pitch value is <= the (4-aligned) pitch value in the
cached bitmap to prevent future issues.
Also cleans up some NULL usages.
BUG=552046
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1406943005 .
|
|
This reverts commit 44a4de0b4bd5148396b2b0de1353dafee6a4c418.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1440513004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1437043002 .
|
|
The GetFontData() behavior in FPDF_SYSFONTINFO seems reasonable.
Also do some code cleanup.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425023003 .
|