Age | Commit message (Collapse) | Author |
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540263003 .
|
|
This improvements memory usage in case PDFs have sparse object numbers.
The map holds a struct that currently has only one member. The struct
will contain more members as other internal data structures get
converted.
BUG=pdfium:111
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1539573003 .
|
|
- Use FXSYS_iswdigit() instead of CJS_PublicMethods::IsDigit().
- Ditto for FXSYS_iswalpha() and FXSYS_iswalnum().
- Change CJS_PublicMethods::ParseNormalDate() and
CJS_PublicMethods::MakeRegularDate() to take an out parameter by ptr.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1539113002 .
|
|
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1544493003 .
|
|
BUG=515137,564736
R=ochang@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1533233002 .
|
|
BUG=514514
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1536223002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1536923002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540693002 .
|
|
BUG=566063
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1534323002 .
|
|
Also defines ADDRESS_SANITIZER and LEAK_SANITIZER for ASan builds.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1540433004 .
|
|
Rename a few other things along the way:
CPDF_ProgressiveImageLoaderHandle becomes ImageLoaderHandle,
since its the only kind, and stop casting it to void*.
CPDF_ImageLoader::StartLoadImage() becomes Start(), since
the rest is redundant.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1535243002 .
|
|
Orignal Review URL: https://codereview.chromium.org/1539983002 .
(cherry picked from commit 0fa6fee0e48af8681f0cd50f6a9471ecc0a46c11)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1536123002 .
|
|
Apart from it never being initialized, note that m_status
is never set to 1, so the only path that references this
class can't be reached.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1537103002 .
|
|
R=thestig@chromium.org, dml@google.com
BUG=pdfium:327
Review URL: https://codereview.chromium.org/1536113002 .
|
|
BUG=pdfium:329
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1529173005 .
|
|
An email address contains user name part and host name part.
User name allows dash or underscore, but not leading/ending/double
period. Host name doesn't allow leading/ending/double
period either.
BUG=489107
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1530763005 .
|
|
It looks like an key length of 0 was incorrectly assumed to
denote an free entry.
Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.
R=tsepez@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1534953002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1534003002 .
|
|
- Remove unused Clear() method.
- Replace Create() with actual ctors.
- Avoid const casts.
- Protect members.
- Add missing const in adjacent code.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1536623004 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1533763002 .
|
|
Also fix a newly introduced override warning.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1532723003 .
|
|
While reading free entries in v4 cross reference table, changing the
start_objnum caused crossref table built wrong.
BUG=569795
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1527823003 .
|
|
BUG=541446
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520203002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1525853003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520063002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512763013 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1522283002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1528743002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1514283002 .
|
|
R=tsepez@chromium.org, antonin@gmail.com, mathieu.malaterre@gmail.com
BUG=554172
Review URL: https://codereview.chromium.org/1492693003 .
|
|
TBR=thestig@chromium.org
BUG=566179
Review URL: https://codereview.chromium.org/1524983002 .
|
|
BUG=566179
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1523523002 .
|
|
BUG=447331
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1514093002 .
|
|
BUG=pdfium:326
R=dml@google.com
Review URL: https://codereview.chromium.org/1521543002 .
|
|
R=tsepez@chromium.org, antonin@gmail.com, mathieu.malaterre@gmail.com
BUG=554129
Review URL: https://codereview.chromium.org/1488303004 .
|
|
Also clean up while we're here.
BUG=557223
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512833008 .
|
|
Missed some conversions in an ifdef mac block.
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1511413008 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1520643002 .
|
|
These are synonyms for CFX_Matrix.
Nothing but sed and manual deletion of 2 #defines in
fpdf_parser.h and fx_coordinates.h
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1513363002 .
|
|
BUG=pdfium:299
R=kcc@chromium.org
Review URL: https://codereview.chromium.org/1520443002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1507043004 .
|
|
BUG=pdfium:298
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1496703005 .
|
|
BUG=452793, 561478
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1511613005 .
|
|
BUG=452793,561478
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512873002 .
Review URL: https://codereview.chromium.org/1508343004 .
|
|
I didn't go whole hog and replace these with std::vector,
but in the mean time, it is silly to cast a typedef for
a template instantiated against void* when we can just
instantiate the template against the actual type.
The ones that remain are actual heterogeneous arrays with
wacky casting.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1518593002 .
|
|
which was being caused by including <iostream> instead of <ostream>.
Since GN uses source_sets instead of static_libraries by default,
the static initializer was making its way into Chrome, which was bad.
R=tsepez@chromium.org
BUG=559766
Review URL: https://codereview.chromium.org/1510353003 .
|
|
That way, pdf/BUILD.gn can test it no matter which branch
of PDFium is pulled under a chrome checkout.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1511183004 .
|
|
Broke chrome bindings.
This reverts commit c3e4ae5fe5067723b58a2029a95c6411c92bed15.
R=thestig@chromium.org, tsepez@chromium.org
BUG=567485
Review URL: https://codereview.chromium.org/1511773002 .
|
|
Master side change for https://codereview.chromium.org/1504413002
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508133003 .
|