summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-12-07Remove C-Style casts in severl other fwl_...imp.cpp filesTom Sepez
Uncovered bad casts in a couple of places, replaced with correct objects. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1503583003 .
2015-12-06Merge to XFA: fix for stream object readingWei Li
Loosen a check for earlier version of PDF files. When the bytes with specified length are followed by 'endstream' keyword, even if there is no EOL marker before the keyword, it signals the end of stream. BUG=551258 TBR=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1499433002 . (cherry picked from commit 0ff66089c87ab6e3adaaff0ec69728ce7a8d8299) Review URL: https://codereview.chromium.org/1504723002 .
2015-12-04Merge to XFA: Fix an incorrect check in CPDF_DataAvail::CheckHintTables.Oliver Chang
R=tsepez@chromium.org TBR=tsepez@chromium.org BUG=566179 Original Review URL: https://codereview.chromium.org/1504513002 . (cherry picked from commit 2d16308298f236ae81aa11a53f2d4e25b502dfac) Review URL: https://codereview.chromium.org/1501123002 .
2015-12-04Remove C-Style casts in fwl_{barcode,caret,checkbox,combobox}imp.cppTom Sepez
In the process, found two CFWL_ classes that didn't inherit from the virtual inteface they were allegedly supporting. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1499853003 .
2015-12-04Remove unused Thread class and static members.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1500023003 .
2015-12-04Tidy fwl_widgetimp.cpp.Tom Sepez
Remove some dead code. Add missing consts. Convert some integer expressions to bools for return. Remove expression (with bad cast) that can't happen. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1496323004 .
2015-12-04Fix dubious casting in fwl_widgetimp.cpp.Tom Sepez
Remove dead code along the way. BUG=pdfium:300 R=jun_fang@foxitsoftware.com, thestig@chromium.org Review URL: https://codereview.chromium.org/1490093006 .
2015-12-02Fix XFA build under chromium checkoutTom Sepez
Add () to suppress gcc-style error about assignment in conditionals. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1491403002 .
2015-12-02Remove _FWL_RETURN_IF_ macrosTom Sepez
These hide early returns from the casual reader, hide the inversion of the condition under test from the reader, prevent the folding of conditions into a single statement, and take up more characters than the if() itself. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1494683002 .
2015-12-02Add MakeWidgetImpProperties() helper method.Tom Sepez
Remove duplicate code from 10 places. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1486283002 .
2015-12-02Merge to XFA: Increase default timeout in valgrind_test.py for running ↵Qin Zhao
corpus tests with Dr. Memory TBR=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1486413005 . (cherry picked from commit be3ad4b56b38221b40e2a1f0ee56e371738a752a) Review URL: https://codereview.chromium.org/1495443005 .
2015-12-02Fix overlapped focus widgetJun Fang
BUG=pdfium:294 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1487573002 .
2015-12-02Fix the issue that no response from the call back function of FFI_GetPlatform()Jun Fang
BUG=pdfium:293 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1486583002 .
2015-12-02Fix an issue that no response from the call back function of FFI_GetLanguage()Jun Fang
BUG=pdfium:295 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1482253002 .
2015-12-01Merge to XFA: Add basic checking for RebuildCrossRefWei Li
RebuildCrossRef function returns false when we can not find file trailer or any indirect object. This serves as a basic file format checking. BUG=pdfium:215 TBR=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1476163002 . (cherry picked from commit f14da1d58e8e12633c7a47e6efd5ffe43bb37b4b) Review URL: https://codereview.chromium.org/1486383002 .
2015-12-01Make CFWL_Custom consistenly named.Tom Sepez
It's part of the CFWL_*Imp hierarchy, and hence should be named CFWL_CustomImp. CFWL_Custom would belong to a differnt hierarchy according to naming conventions. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1491723002 .
2015-12-01Fix an assertion failure in CPDFSDK_Widget* Field::GetWidget()Jun Fang
BUG=pdfium:291 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1487553003 .
2015-12-01Fix a crasher due to recursion in CXFA_WidgetAcc::ExecuteScript()Jun Fang
BUG=pdfium:292 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1486573002 .
2015-12-01Use c++ style casts in CPWL_Color::CPWL_Color()Jun Fang
BUG=pdfium:281 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1481503002 .
2015-11-30Allow building non-XFA (master) on the XFA branch.Tom Sepez
This first pass is GYP-only, will do GN in the next CL. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1480403002 .
2015-11-30Tidy PDF_ENABLE_XFA #ifdefs in fpdfsdk.Tom Sepez
-- label matching #endifs -- prefer #ifdef over #ifndef -- consolidate some blocks. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1484843002 .
2015-11-30Merge to XFA: Add README in tools/drmemory for using Dr. MemoryQin Zhao
R=tsepez@chromium.org BUG=PDFium:238 Review URL: https://codereview.chromium.org/1471073011 . (cherry picked from commit 7e413d168beba325078aa4b484729ad22919a2c3) Review URL: https://codereview.chromium.org/1482953003 .
2015-11-27Fix a crasher in LoadFont() when non-standard font is used in XFA filesJun Fang
This CL includes the following changes: 1. Add return value for InitFont(). It can indicate a failure in the initialization of non-standard fonts. 2. Change NULL to nullptr. 3. Rewrite several pointer checking. BUG=pdfium:279, pdfium:286 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1465423002 .
2015-11-27Fix a crasher caused by an invalid index in CXFA_LayoutPageMgr::GetPage()Jun Fang
BUG=pdfium:289 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1472383003 .
2015-11-25Inflict PDF_ENABLE_XFA ifdefs on XFA fpdfsdk/Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1477583002 .
2015-11-25Remove unused include from fsdk_actionhandler.cppTom Sepez
Review URL: https://codereview.chromium.org/1465183009 .
2015-11-25Manual fixups to PDF_ENABLE_XFA in core/Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1477663003 .
2015-11-25XFA: Needless include in pdfppo.cppTom Sepez
R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1477983002 .
2015-11-25XFA: More underlying typesTom Sepez
Precursor to https://codereview.chromium.org/1477583002/ Also: whitespace in fxjs_v8.h Merge where possible. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1472363003 .
2015-11-25Inflict PPDF_ENABLE_XFA ifdefs on XFA core/Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1471323004 .
2015-11-25Merge to XFA: CFXJS_ObjDefinition's lifetime must match isolate.Tom Sepez
Review URL: https://codereview.chromium.org/1468423004 . (cherry picked from commit 628f7053cc646c58c61add247c75bc65ac135327) BUG=561184 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/1473943002 .
2015-11-25Merge to XFA: Suppress invalid-heap-arg error in pdfium_unittestsQin Zhao
Visual Studio sometimes uses new instead of new[] for array allocation, which causes Dr. Memory report invalid-heap-arg errors. Suppress such errors since it is not developers' problems. TBR=tsepez@chromium.org BUG=pdfium:287 Review URL: https://codereview.chromium.org/1473913002 . (cherry picked from commit 1fb4bc47e216c9caebdf7bc8479d45285ee7693b) Review URL: https://codereview.chromium.org/1475023003 .
2015-11-25Merge to XFA: Fix two memory leaks from pdfium_unittestsQin Zhao
- remove redundant alloc in fx_codec_jpx_unittest.cpp - free memory allocated by HexDecode calls in fpdf_parser_decode_unittest.cpp BUG=PDFium:239 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1467183006 . (cherry picked from commit 6c2d736011c09266015d3e2a0b9c08aeba1bbf31) Review URL: https://codereview.chromium.org/1477833002 .
2015-11-25Fix a crasher in rendering rich text in XFA filesJun Fang
Increase ref number of pStyle when it's being used. In this way, it won't be released when it's being used. BUG=pdfium:267 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1468123003 .
2015-11-25Fix embedder test failures introduced by commit c70b19aad245Jun Fang
BUG=pdfium:275 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1443603002. Review URL: https://codereview.chromium.org/1477693002 .
2015-11-25Fix invalid buffer length set in CFX_WideString::UTF16LE_Encode()Jun Fang
BUG=pdfium:275 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1443603002 .
2015-11-25Fix a issue that FFI_GetCurrentPageIndex always returns -1Jun Fang
The incorrect page index may cause a crasher in the following procedure. BUG=pdfium:285 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1466423004 .
2015-11-25Refactor CXFA_FFPageView::GetWidgetByPosJun Fang
BUG=pdfium:276 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1438333005 .
2015-11-24XFA: DYNIMIC is spelled DYNAMICTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1473053003 .
2015-11-24Make xfa samples/ look more like masterTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1476683002 .
2015-11-24XFA: more underlying type changes to match masterTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1474663004 .
2015-11-24Merge to XFA: Update pdfium_tests.py to run pdfium tests with Dr. Memory on ↵Qin Zhao
buildbots - update pdfium_tests.py to setup Dr. Memory so it can be used directly without pdfium_tests.bat on buildbots R=thestig@chromium.org BUG=PDFium:238 Review URL: https://codereview.chromium.org/1478453002 . (cherry picked from commit abea9d857e8e197d0095940f882b0db6a785d825) Review URL: https://codereview.chromium.org/1467183005 .
2015-11-24Merge to XFA: Fix a NULL pointer crash in the CJBig2_Image copy constructor.Lei Zhang
Also change the copy ctor to take a const ref. BUG=560520 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1472113002 . (cherry picked from commit d03bc01003ae2603dafdc07b901ffef0a509a2b9) Review URL: https://codereview.chromium.org/1478473002 .
2015-11-24XFA: add underlying document type commentTom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1469413002 .
2015-11-24Fix build broken at 50d12ad.Tom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1477483002 .
2015-11-24Introduce "underlying types" to abstract XFA differences.Tom Sepez
See the comment in fsdk_define.h. Also tidy up a bit, and remove dead DeletePages(). This should help us match master more closely (given corresponding changes on the master side). R=thestig@chromium.org Review URL: https://codereview.chromium.org/1473503002 .
2015-11-24Fix wrong page count returned in FPDF_GetPageCount() for dynamic XFA filesTom Sepez
In FPDF_GetPageCount(), 'document' is converted to a non-XFA document pointer (CPDF_Document*). So it only returns non-XFA or static XFA page count. If XFA files include dynamic XFA fields on some pages, the returned value doesn't reflect these pages. BUG=pdfium:278 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1442753005 .
2015-11-23Merge to XFA: Adjust Dr. Memory suppressionQin Zhao
- widening suppression for DrM-i#471 TBR=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1467373003 . (cherry picked from commit 3b1bd5cbbcc1a606275fe98e813a37531572f374) Review URL: https://codereview.chromium.org/1465373002 .
2015-11-23Merge to XFA: Enable Dr. Memory to run javascript, pixel, and corpus testsQin Zhao
- add DrMemoryWrapper in common.py to adjust Dr. Memory wrapper - add --wrapper option to run_*_tests.py for Dr. Mempry wrapper - update run_*_tests.py to handle Dr. Memory wrapper - add TestPDFiumTest in pdfium_tests.py to support run_*_tests.py - remove ValgrindTool in valgrind_tests.py R=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1464453003 . (cherry picked from commit 36476923ae5eb8e9283e605f3c85ee8811c86014) Review URL: https://codereview.chromium.org/1465333002 .
2015-11-23Make CXFA_ContainerLayoutItem inherit from IXFA_LayoutPage.Tom Sepez
IFXA_LayoutPage now a pure virtual interface, with its code moving to CXFA_ContainerLayoutItem's implementaton of it. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1466103002 .
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-29 21:52:29 +0000