summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-02-01Tidy up CPDF_DocEnvironment::JS_* methodsTom Sepez
Remove code from header. Put related declarations together. Add convenience function for widestrings. Avoid pointless releases. Use early returns in all cases for consistency. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1658853002 .
2016-02-01Remove the m_ObjVersion member variable from CPDF_Parser.Lei Zhang
Use the gennum field in the m_ObjectInfo map instead. BUG=pdfium:111 R=weili@chromium.org Review URL: https://codereview.chromium.org/1654303002 .
2016-02-01Remove CGW_ArrayTemplate and its O(n^2 log n) sort.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1652613002 .
2016-02-01Remove the m_V5Type member variable from CPDF_Parser.Lei Zhang
Use the type field in the m_ObjectInfo map instead. BUG=pdfium:111 R=weili@chromium.org Review URL: https://codereview.chromium.org/1650793002 .
2016-02-01Use JS_ExpandKeywordParams() in app.response()Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1654523002 .
2016-02-01Add Test for field.getArray() sort-order.Tom Sepez
One more test before replacing the old sort() mechanism. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1650623004 .
2016-01-29Some cleanup of fpdf_render_loadimage.cppOliver Chang
- Generalise GetBits8() - Get rid of C-style casts. - Make CFX_DIBSource::SetDownSampleSize() non const. It's only overriden once and called in one place and it doesn't make sense for it to be const. - Get rid of a macro - Make public member vars of CPDF_DIBSource private - And others... R=thestig@chromium.org Review URL: https://codereview.chromium.org/1644403003 .
2016-01-29Another round of cleanup in CPDF_Parser and friends.Lei Zhang
- Remove dead code. - Add more public methods and remove friends. R=weili@chromium.org Review URL: https://codereview.chromium.org/1566133002 .
2016-01-29Refactor CPDF_Object and its subclasses.Wei Li
Mainly use virtual functions to replace functions with switch statements. Also remove a few unused functions and make some format changes. BUG=pdfium:63 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1634373003 .
2016-01-29Fix botched "CC:" parameter passing in JS_DocmailForm().Tom Sepez
Moved onto JS_ExpandKeywordParams(), and added a test which showed the failure to pass all the data back to the embedder. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1645413002 .
2016-01-29Add tests for CBA_AnnotIterator.Tom Sepez
I'm about to replace the sort() that underlies this class, so I first want to be sure I don't disrupt the order. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1652533002 .
2016-01-29Roll DEPS for V8 to 43be969.Lei Zhang
BUG=581960 R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1648283003 .
2016-01-29Fix behaviour of app.alert() with a single object argument.Tom Sepez
Centralize the "arguments in an object" logic. See the section "Method Arguments" in the js_api_reference.pdf. Add some tests to hit the ambiguous cases this section implies, and test that all parameters are passed end-to-end to our callbacks. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1641693003 .
2016-01-28Member function name refactoringWei Li
This is needed by Cl 1634373003 as the name collision with virtual functions will be shown as warnings on Linux. Also, it is better to use different names for different cases. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1644633003 .
2016-01-26Merge to Master: War on #defines - part 2Tom Sepez
Original Review URL: https://codereview.chromium.org/1634123004 . (cherry picked from commit f10ae634e7b198b18942baaf9f111f07cc8ce818) R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1640473002 .
2016-01-26Move struct ContentParam off of CPDF_Object's enumsTom Sepez
They mean different things. The goal is that only usage of the CPDF_Object type enums outside of the class should be for switch() statements, so remove one other comparison. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1635173003 .
2016-01-26War on #defines, part 1.Tom Sepez
Make the two fundamental "object" types be enums. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1632143002 .
2016-01-25Fix a bunch of pointless returns.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1637693002 .
2016-01-25Remove CFX_SegmentedArray use from master.Tom Sepez
Replace with std::deque. Make member naming more consistent. R=ochang@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1618273004 .
2016-01-25Merge to Master: Remove several more unused parser values.Tom Sepez
Review URL: https://codereview.chromium.org/1634683003 . (cherry picked from commit e24ea22700c9fc534d40cc510d59c453aa9d0ddb) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1632843004 .
2016-01-25Merge to Master: Remove struct PARSE_OPTIONS.Tom Sepez
Orignal Review URL: https://codereview.chromium.org/1630973002 . (cherry picked from commit 0f68785be6af2b15109bb8a8f3bb7ebc040500d5) R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1624343004 .
2016-01-25Merge to Master: Remove unused IsContentUsedElsewhere()Tom Sepez
Original Review URL: https://codereview.chromium.org/1638493002 . (cherry picked from commit 02056fae83c8136195c8eb2a00c3606f600a8b6a) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1632863002 .
2016-01-22Fixed object references in CPDF_ObjectWei Li
This is a regression from commit 90853cb. BUG=pdfium:365 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1617043004 .
2016-01-22CPDFText_ParseOptions never change from default.Tom Sepez
m_bGetCharCodeOnly and m_bOutputHyphen are never re-assigned. m_bNormalizeObjs is assigned in a method that is never called. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1618693009 .
2016-01-22Change _PDF_RenderItem to CPDF_RenderContext::Layer.Tom Sepez
The _CAPS class naming convention violates reserved identifier rules. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1620523002 .
2016-01-21Rename CPDF_PageObjects to CPDF_PageObjectListTom Sepez
Prefer class names to be singular. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1612113003 .
2016-01-21Redo CPDF_PageObjects - part 1Tom Sepez
Remove default args. Remove unreachable code. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1601093009 .
2016-01-21Rename CPDF_PageContentGenerate to CPDF_PageContentGenerator.Tom Sepez
Classes should be named after nouns, not verbs. Also mark methods private, not protected. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1611193003 .
2016-01-20Use std::set to track visited dictionaries in fsdk_actionhandler.Tom Sepez
Find() in a list isn't the best idea. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1610303002 .
2016-01-20Replace more CFX_MapPtrToPtr and remove it.Tom Sepez
Still used by XFA, so the merge will make this XFA only. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1580573002 .
2016-01-20Remove CFX_CMapByteStringToPtrTom Sepez
R=ochang@chromium.org Review URL: https://codereview.chromium.org/1580493002 .
2016-01-20Bugs in CJS_PublicMethods::ParseNumber().Tom Sepez
Fix the bugs by removing ParseNumber() entirely. For PDFium's JavaScript bindings, we want to get out of the numeric conversion business and inflict that on V8 as possible, avoiding platform-specific issue in strtod(). For other uses, there is a FX_atof() which is similarly buggy, but we can consolidate the use. Add an overloaded FX_atof() to handle wide strings more simply. BUG=pdfium:361 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1586203006 .
2016-01-19Remove an extra "const" in fpdf_objects.Oliver Chang
TBR=weili@chromium.org Review URL: https://codereview.chromium.org/1602323002 .
2016-01-19Hook up show-config to testing scripts.Tom Sepez
R=ochang@chromium.org Review URL: https://codereview.chromium.org/1607923004 .
2016-01-19Keep all member functions of one class in a single file.Wei Li
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1581393011 .
2016-01-19Fix infinite loops caused by calling circular indirect objectsWei Li
There are multiple functions in CPDF_Object class which can cause infinite loop due to recursively calling circular indirect objects. Fix them by deference indirect object first. BUG=pdfium:355 R=jun_fang@foxitsoftware.com, thestig@chromium.org Review URL: https://codereview.chromium.org/1585533002 .
2016-01-15Unify suppressions files and add matcher syntax.Tom Sepez
We need more powerful tools for exclusion in light of the XFA merge. This stops short of integrating the matcher with the pdfium_test --show-config option. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1586043006 .
2016-01-15Make pdfium_test report build options.Tom Sepez
Prerequisite for suppressing tests based on build options. We explicitly delimit everything with [x] so as to make substring matching trivial in the .py down the road. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1587023005 .
2016-01-15Fix the way FT headers are includedLei Zhang
FreeType headers have to be included with macros defined in ftheaders.h. Not doing so breaks when the FreeType header location changes as was the case between FreeType 2.6.0 and 2.6.2. Patch by jshin@chromium.org BUG=pdfium:362 R=jshin@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1587333002 .
2016-01-15openjpeg: Set proper upper bound for an array in opj_pi_update_decode_poc().Oliver Chang
R=tsepez@chromium.org BUG=571480 Review URL: https://codereview.chromium.org/1583233008 .
2016-01-15Remove ifdefs for _FX_MANAGED_CODE_.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1589223002 .
2016-01-15Make the bug 361 test case work in Acrobat.Lei Zhang
BUG=pdfium:361 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1586983005 .
2016-01-14Revert "Cleanup CJS_PublicMethods::ParseNumber"Tom Sepez
This reverts commit 4cd5b80e70e5fc50d8bd805cfa3c7b54878a0a35. Reason for revert: broke tests on windows TBR=tombergan@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1573243016 .
2016-01-14Cleanup CJS_PublicMethods::ParseNumberTom Sepez
Original patch by tombergan. The old version of this function was basically strtod with a few quirks: 1. It always interpreted ',' as '.' independent of locale. I kept this behavior, to be conservative. 2. It interpreted the first non-number character as a decimal point, unless there was a prior decimal point, in which case all characters up to that point are ignored. This would parse "123z4" as "123.4" and "123xy6" as "6". I did not keep this behavior -- in the new code, these examples all fail to parse. The new ParseNumber was inlined into ConvertStringToNumber, which returns true on success and (false, 0) on failure. BUG=pdfium:361 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1582013002 .
2016-01-14Disable use of missing arm neon function in libpngSam Clegg
This was causing pdfium_diff to fail to link on ARM/linux due to missing neon-specifc symbols. Ideally we could add the missing symbols (and update the latest version of libpng), but that can happen in a separate CL. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1581193007 .
2016-01-14Loose checking for trailer's size fieldWei Li
Although trailer's size value is required by spec, other readers such as Acrobat or libpoppler can handle without it. Loose up the check to be more tolerant. BUG=pdfium:213 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1582193002 .
2016-01-14Additional test cases for bug_361Tom Sepez
These cover some corner cases discussed from the CL at https://codereview.chromium.org/1582013002/ R=thestig@chromium.org, tombergan@chromium.org Review URL: https://codereview.chromium.org/1582383002 .
2016-01-14Correct the way to count pages and to avoid infinite loopWei Li
BUG=pdfium:360 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1585823003 .
2016-01-14openjpeg: Fix potential bad precno value in opj_pi_next* functions.Oliver Chang
R=thestig@chromium.org BUG=571479 Review URL: https://codereview.chromium.org/1585243003 .
2016-01-13Fix another invalidated iterator issue while traversing CPDF_Dictionary.Oliver Chang
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1582903004 .
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-19 00:48:00 +0000