Age | Commit message (Collapse) | Author |
|
Prerequisite for suppressing tests based on build options.
We explicitly delimit everything with [x] so as to make
substring matching trivial in the .py down the road.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1587023005 .
|
|
FreeType headers have to be included with macros defined in ftheaders.h.
Not doing so breaks when the FreeType header location changes as was the
case between FreeType 2.6.0 and 2.6.2.
Patch by jshin@chromium.org
BUG=pdfium:362
R=jshin@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1587333002 .
|
|
R=tsepez@chromium.org
BUG=571480
Review URL: https://codereview.chromium.org/1583233008 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1589223002 .
|
|
BUG=pdfium:361
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1586983005 .
|
|
This reverts commit 4cd5b80e70e5fc50d8bd805cfa3c7b54878a0a35.
Reason for revert: broke tests on windows
TBR=tombergan@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1573243016 .
|
|
Original patch by tombergan.
The old version of this function was basically strtod with a few quirks:
1. It always interpreted ',' as '.' independent of locale. I kept this
behavior, to be conservative.
2. It interpreted the first non-number character as a decimal point,
unless there was a prior decimal point, in which case all characters
up to that point are ignored. This would parse "123z4" as "123.4"
and "123xy6" as "6". I did not keep this behavior -- in the new code,
these examples all fail to parse.
The new ParseNumber was inlined into ConvertStringToNumber, which
returns true on success and (false, 0) on failure.
BUG=pdfium:361
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1582013002 .
|
|
This was causing pdfium_diff to fail to link on ARM/linux
due to missing neon-specifc symbols. Ideally we could
add the missing symbols (and update the latest version
of libpng), but that can happen in a separate CL.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1581193007 .
|
|
Although trailer's size value is required by spec, other readers such as
Acrobat or libpoppler can handle without it. Loose up the check to be
more tolerant.
BUG=pdfium:213
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1582193002 .
|
|
These cover some corner cases discussed from the CL at
https://codereview.chromium.org/1582013002/
R=thestig@chromium.org, tombergan@chromium.org
Review URL: https://codereview.chromium.org/1582383002 .
|
|
BUG=pdfium:360
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1585823003 .
|
|
R=thestig@chromium.org
BUG=571479
Review URL: https://codereview.chromium.org/1585243003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1582903004 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1588643003 .
|
|
Also fixes a potential issue in CPDF_Dictionary::ReplaceKey.
R=thestig@chromium.org
BUG=577030
Review URL: https://codereview.chromium.org/1582963003 .
|
|
Avoid invalidating iterators by deferring the std::map operations.
Also remove unused PDF_ReplaceFull().
BUG=577030
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1581963004 .
|
|
R=thestig@chromium.org, tombergan@chromium.org
Review URL: https://codereview.chromium.org/1588733003 .
|
|
This regressed in commit f6dafc9.
BUG=576915
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1582763002 .
|
|
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1575363007 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1579353002 .
|
|
Rename to CPDF_IndirectObjectHolder
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1576113003 .
|
|
CPDF_SyntaxParser::GetObject() may enter into an infinite loop when a
signature dictionary doesn't have 'Contents' field. Add a check to
avoid that.
BUG=pdfium:344
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1575833004 .
|
|
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1544943002 .
|
|
BUG=pdfium:346
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1578543002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1570873005 .
|
|
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr
so it's not completely removed just yet.
Adds begin()/end() to CPDF_Dictionary and removes the
GetStartPos()/GetNextElement() functions to traverse the dictionary.
Callers are changed accordingly. AddValue() is also removed.
R=tsepez@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1541703003 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1572733002 .
|
|
Make m_InternalStage an enum.
Use safe types to detect overflow.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1568373003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567333003 .
|
|
BUG=pdfium:343
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1569343002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570973002 .
|
|
Remove unused enum.
Don't begin struct names with underscore.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1570133004 .
|
|
Some bits regressed in commit 338805f.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1544963002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1561303002 .
|
|
Remove unused m_pContrastRamps.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1564783003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1563673002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1568763003 .
|
|
Also remove a bunch of dead code.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1565803003 .
|
|
BUG=572871
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1564773003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1563513002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1554133003 .
|
|
Change the internal version to GetNextWordInternal().
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1558083002 .
|
|
This reverts most of https://codereview.chromium.org/1557923004/
Doesn't build on the chromeos bots yet.
BUG=pdfium:29
TBR=thestig
Review URL: https://codereview.chromium.org/1561013002 .
|
|
Now that Chromium's build/common.gypi no longer does weird things
with -Wsign-compare, this should work.
BUG=pdfium:29
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1557923004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1565613002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1566553002 .
|
|
Also do some cleanups in affected files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1552583002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1555293002 .
|
|
Remove some O(n^2) behaviour when iterating across the thing.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1566433003 .
|