Age | Commit message (Collapse) | Author |
|
Review URL: https://codereview.chromium.org/1634683003 .
(cherry picked from commit e24ea22700c9fc534d40cc510d59c453aa9d0ddb)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1632843004 .
|
|
Orignal Review URL: https://codereview.chromium.org/1630973002 .
(cherry picked from commit 0f68785be6af2b15109bb8a8f3bb7ebc040500d5)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1624343004 .
|
|
Original Review URL: https://codereview.chromium.org/1638493002 .
(cherry picked from commit 02056fae83c8136195c8eb2a00c3606f600a8b6a)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1632863002 .
|
|
This is a regression from commit 90853cb.
BUG=pdfium:365
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1617043004 .
|
|
m_bGetCharCodeOnly and m_bOutputHyphen are never re-assigned.
m_bNormalizeObjs is assigned in a method that is never called.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1618693009 .
|
|
The _CAPS class naming convention violates reserved
identifier rules.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1620523002 .
|
|
Prefer class names to be singular.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1612113003 .
|
|
Remove default args.
Remove unreachable code.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1601093009 .
|
|
Classes should be named after nouns, not verbs.
Also mark methods private, not protected.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1611193003 .
|
|
Find() in a list isn't the best idea.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1610303002 .
|
|
Still used by XFA, so the merge will make this XFA only.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1580573002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1580493002 .
|
|
Fix the bugs by removing ParseNumber() entirely.
For PDFium's JavaScript bindings, we want to get out of the
numeric conversion business and inflict that on V8 as
possible, avoiding platform-specific issue in strtod().
For other uses, there is a FX_atof() which is similarly
buggy, but we can consolidate the use. Add an overloaded
FX_atof() to handle wide strings more simply.
BUG=pdfium:361
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1586203006 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1602323002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1607923004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1581393011 .
|
|
There are multiple functions in CPDF_Object class which can cause infinite loop due to recursively calling circular indirect objects. Fix them by deference indirect object first.
BUG=pdfium:355
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1585533002 .
|
|
We need more powerful tools for exclusion in light of
the XFA merge.
This stops short of integrating the matcher with the
pdfium_test --show-config option.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1586043006 .
|
|
Prerequisite for suppressing tests based on build options.
We explicitly delimit everything with [x] so as to make
substring matching trivial in the .py down the road.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1587023005 .
|
|
FreeType headers have to be included with macros defined in ftheaders.h.
Not doing so breaks when the FreeType header location changes as was the
case between FreeType 2.6.0 and 2.6.2.
Patch by jshin@chromium.org
BUG=pdfium:362
R=jshin@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1587333002 .
|
|
R=tsepez@chromium.org
BUG=571480
Review URL: https://codereview.chromium.org/1583233008 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1589223002 .
|
|
BUG=pdfium:361
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1586983005 .
|
|
This reverts commit 4cd5b80e70e5fc50d8bd805cfa3c7b54878a0a35.
Reason for revert: broke tests on windows
TBR=tombergan@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1573243016 .
|
|
Original patch by tombergan.
The old version of this function was basically strtod with a few quirks:
1. It always interpreted ',' as '.' independent of locale. I kept this
behavior, to be conservative.
2. It interpreted the first non-number character as a decimal point,
unless there was a prior decimal point, in which case all characters
up to that point are ignored. This would parse "123z4" as "123.4"
and "123xy6" as "6". I did not keep this behavior -- in the new code,
these examples all fail to parse.
The new ParseNumber was inlined into ConvertStringToNumber, which
returns true on success and (false, 0) on failure.
BUG=pdfium:361
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1582013002 .
|
|
This was causing pdfium_diff to fail to link on ARM/linux
due to missing neon-specifc symbols. Ideally we could
add the missing symbols (and update the latest version
of libpng), but that can happen in a separate CL.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1581193007 .
|
|
Although trailer's size value is required by spec, other readers such as
Acrobat or libpoppler can handle without it. Loose up the check to be
more tolerant.
BUG=pdfium:213
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1582193002 .
|
|
These cover some corner cases discussed from the CL at
https://codereview.chromium.org/1582013002/
R=thestig@chromium.org, tombergan@chromium.org
Review URL: https://codereview.chromium.org/1582383002 .
|
|
BUG=pdfium:360
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1585823003 .
|
|
R=thestig@chromium.org
BUG=571479
Review URL: https://codereview.chromium.org/1585243003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1582903004 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1588643003 .
|
|
Also fixes a potential issue in CPDF_Dictionary::ReplaceKey.
R=thestig@chromium.org
BUG=577030
Review URL: https://codereview.chromium.org/1582963003 .
|
|
Avoid invalidating iterators by deferring the std::map operations.
Also remove unused PDF_ReplaceFull().
BUG=577030
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1581963004 .
|
|
R=thestig@chromium.org, tombergan@chromium.org
Review URL: https://codereview.chromium.org/1588733003 .
|
|
This regressed in commit f6dafc9.
BUG=576915
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1582763002 .
|
|
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1575363007 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1579353002 .
|
|
Rename to CPDF_IndirectObjectHolder
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1576113003 .
|
|
CPDF_SyntaxParser::GetObject() may enter into an infinite loop when a
signature dictionary doesn't have 'Contents' field. Add a check to
avoid that.
BUG=pdfium:344
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1575833004 .
|
|
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1544943002 .
|
|
BUG=pdfium:346
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1578543002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1570873005 .
|
|
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr
so it's not completely removed just yet.
Adds begin()/end() to CPDF_Dictionary and removes the
GetStartPos()/GetNextElement() functions to traverse the dictionary.
Callers are changed accordingly. AddValue() is also removed.
R=tsepez@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1541703003 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1572733002 .
|
|
Make m_InternalStage an enum.
Use safe types to detect overflow.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1568373003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567333003 .
|
|
BUG=pdfium:343
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1569343002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570973002 .
|