summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-02-03XFA: Roll DEPS for V8 to 3c3d7e7.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1665933003 .
2016-02-03Add CFXA_Object helper methods.Tom Sepez
Mark some ctors explicit. Rename GetXFANode to GetXFAObject to match its return type, since it is cast to node in many places. BUG=pdfium:384 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1662063002 .
2016-02-03Merge to XFA: Fix prototypes for CPDF_FormNotify.Tom Sepez
Original Review URL: https://codereview.chromium.org/1660633003 . (cherry picked from commit e8ea737bf9ef95b406c74fc3b1120f3fa6c4e227) Conflicts: fpdfsdk/include/fsdk_baseform.h fpdfsdk/src/fsdk_baseform.cpp TBR=thestig@chromium.org BUG= Review URL: https://codereview.chromium.org/1668483004 .
2016-02-03Fix prototypes for CPDF_FormNotify.Tom Sepez
Avoid some const casts, unused return types, etc. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1660633003 .
2016-02-03Merge to XFA: Make m_IndexArray sane.Tom Sepez
Review URL: https://codereview.chromium.org/1660733002 . (cherry picked from commit 7c87508ae4b8300caf97aebffae42ba2c7fd6e52) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1660103004 .
2016-02-03Make m_IndexArray sane.Tom Sepez
This was an obstacle to removing CFX_DWordArray; rather than rote conversion of an array where the even elements mean one thing and the odd elements another, make an array of pairs. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1660733002 .
2016-02-03Roll DEPS for V8 to 3c3d7e7.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1661123002 .
2016-02-03Merge to XFA: Complete unit tests for CPDF_ArrayWei Li
Also remove one unnecessary member function. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1660523003 . (cherry picked from commit 6f358daa2e8b1639a1c3a3f07a449f8450197e8b) Review URL: https://codereview.chromium.org/1667873002 .
2016-02-03Complete unit tests for CPDF_ArrayWei Li
Also remove one unnecessary member function. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1660523003 .
2016-02-02XFA: Fix a crashier in SetFocus()Jun Fang
BUG=pdfium:374 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1640233004 .
2016-02-02Fix heap-use-after-free in V8::Initialize()Jun Fang
BUG=pdfium:376 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1651193005 .
2016-02-02XFA: Fix SEGV in CPDFXFA_Document::SetCurrentPage()Jun Fang
BUG=pdfium:377 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1658163002 .
2016-02-02Revert "Roll DEPS for v8 to 3c56400."Lei Zhang
This reverts commit 0fe7f600254fa390d60fcad3e6af5e4f46df244c. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1662823002 .
2016-02-02Roll DEPS for v8 to 3c56400.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1665593003 .
2016-02-02Merge to XFA: Kill CFX_ByteArray in master.Tom Sepez
One trivial edit in fx_basic.h Includes both fixes for build breakage. Review URL: https://codereview.chromium.org/1653253002 . (cherry picked from commit 9b0a59d659d8083802385649ba74370d65c41e36) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1655423002 .
2016-02-02Fix windows build at 77244553b268 (FX_BOOL vs. bool)Tom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1667433002 .
2016-02-02Fix build on windows (IWYU) at 9b0a59d659d8Tom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1660753002 .
2016-02-02Kill CFX_ByteArray in master.Tom Sepez
(Many more uses in XFA). R=thestig@chromium.org Review URL: https://codereview.chromium.org/1653253002 .
2016-02-01Revert "Fix a crashier in CPDFSDK_Document::GetPageView()"Jun Fang
This reverts commit 1be28d1b037de32c75632e10e7d2fc758fe7f962. BUG=pdfium:369 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1659463006 .
2016-02-01Fix a crashier in CPDFSDK_Document::GetPageView()Jun Fang
XFA document should be released before SDK document is released. BUG=pdfium:369 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1652883002 .
2016-02-01Fix AddressSanitizer: heap-buffer-overflow in ValidateCanonicalTime()Jun Fang
BUG=pdfium:378 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1652933002 .
2016-02-01Merge to XFA: Tidy up CPDF_DocEnvironment::JS_* methodsTom Sepez
One trivial conflict in fsdk_mgr.h Review URL: https://codereview.chromium.org/1658853002 . (cherry picked from commit 1654972e0c81f1841653f803903cc48b93f1738e) R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1651313002 .
2016-02-01Tidy up CPDF_DocEnvironment::JS_* methodsTom Sepez
Remove code from header. Put related declarations together. Add convenience function for widestrings. Avoid pointless releases. Use early returns in all cases for consistency. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1658853002 .
2016-02-01Merge to XFA: Remove the m_ObjVersion member variable from CPDF_Parser.Lei Zhang
Use the gennum field in the m_ObjectInfo map instead. BUG=pdfium:111 R=weili@chromium.org TBR=weili@chromium.org Review URL: https://codereview.chromium.org/1654303002 . (cherry picked from commit a620372c9e1d0ff825bcbe6620fe7e1b63c769c2) Review URL: https://codereview.chromium.org/1653023004 .
2016-02-01Remove the m_ObjVersion member variable from CPDF_Parser.Lei Zhang
Use the gennum field in the m_ObjectInfo map instead. BUG=pdfium:111 R=weili@chromium.org Review URL: https://codereview.chromium.org/1654303002 .
2016-02-01Merge to XFA: Remove the m_V5Type member variable from CPDF_Parser.chromium/2641chromium/2640chromium/2639chromium/2638Lei Zhang
Use the type field in the m_ObjectInfo map instead. BUG=pdfium:111 TBR=weili@chromium.org Review URL: https://codereview.chromium.org/1650793002 . (cherry picked from commit 93c196d868535f684007a7d3ed1f7146851a0ab9) Review URL: https://codereview.chromium.org/1652083004 .
2016-02-01Merge to XFA: Remove CGW_ArrayTemplate and its O(n^2 log n) sort.Tom Sepez
Original Review URL: https://codereview.chromium.org/1652613002 . (cherry picked from commit 0841b0f37678ba4962247f5636e9390718fc027e) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1657663003 .
2016-02-01Remove CGW_ArrayTemplate and its O(n^2 log n) sort.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1652613002 .
2016-02-01Remove the m_V5Type member variable from CPDF_Parser.Lei Zhang
Use the type field in the m_ObjectInfo map instead. BUG=pdfium:111 R=weili@chromium.org Review URL: https://codereview.chromium.org/1650793002 .
2016-02-01Merge to XFA: Use JS_ExpandKeywordParams() in app.response()Tom Sepez
Original Review URL: https://codereview.chromium.org/1654523002 . (cherry picked from commit 3859258ebe9e81e1f766b57e7f78c786ae4ed495) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1658753002 .
2016-02-01Use JS_ExpandKeywordParams() in app.response()Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1654523002 .
2016-02-01Merge to XFA: Add Test for field.getArray() sort-order.Tom Sepez
Review URL: https://codereview.chromium.org/1650623004 . (cherry picked from commit 56d618ac9b4c82a9a350f21bbc6ec2ec6a95c8b0) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1657533004 .
2016-02-01Add Test for field.getArray() sort-order.Tom Sepez
One more test before replacing the old sort() mechanism. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1650623004 .
2016-01-29Merge to XFA: Some cleanup of fpdf_render_loadimage.cppOliver Chang
- Generalise GetBits8() - Get rid of C-style casts. - Make CFX_DIBSource::SetDownSampleSize() non const. It's only overriden once and called in one place and it doesn't make sense for it to be const. - Get rid of a macro - Make public member vars of CPDF_DIBSource private - And others... TBR=thestig@chromium.org Original Review URL: https://codereview.chromium.org/1644403003 . (cherry picked from commit 487935f662ba4711caf1c2c06873b676fd3fba3e) Review URL: https://codereview.chromium.org/1649243002 .
2016-01-29Some cleanup of fpdf_render_loadimage.cppOliver Chang
- Generalise GetBits8() - Get rid of C-style casts. - Make CFX_DIBSource::SetDownSampleSize() non const. It's only overriden once and called in one place and it doesn't make sense for it to be const. - Get rid of a macro - Make public member vars of CPDF_DIBSource private - And others... R=thestig@chromium.org Review URL: https://codereview.chromium.org/1644403003 .
2016-01-29Merge to XFA: Refactor CPDF_Object and its subclasses.Wei Li
Mainly use virtual functions to replace functions with switch statements. Also remove a few unused functions and make some format changes. BUG=pdfium:63 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1634373003 . (cherry picked from commit df1ab41e000069dda7bf21527308f3bf41e126ca) Review URL: https://codereview.chromium.org/1650493003 .
2016-01-29Another round of cleanup in CPDF_Parser and friends.Lei Zhang
- Remove dead code. - Add more public methods and remove friends. TBR=weili@chromium.org Review URL: https://codereview.chromium.org/1566133002 . (cherry picked from commit 9e8185948f7631515951770ca8778f42cc9fd2fc) Review URL: https://codereview.chromium.org/1649233002 .
2016-01-29Another round of cleanup in CPDF_Parser and friends.Lei Zhang
- Remove dead code. - Add more public methods and remove friends. R=weili@chromium.org Review URL: https://codereview.chromium.org/1566133002 .
2016-01-29Refactor CPDF_Object and its subclasses.Wei Li
Mainly use virtual functions to replace functions with switch statements. Also remove a few unused functions and make some format changes. BUG=pdfium:63 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1634373003 .
2016-01-29Merge to XFA: Fix botched "CC:" parameter passing in JS_DocmailForm().Tom Sepez
Original Review URL: https://codereview.chromium.org/1645413002 . (cherry picked from commit 6902db5cbaf0afb8f2cb4df325e1a4e7d6acd53f) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1648793006 .
2016-01-29Fix botched "CC:" parameter passing in JS_DocmailForm().Tom Sepez
Moved onto JS_ExpandKeywordParams(), and added a test which showed the failure to pass all the data back to the embedder. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1645413002 .
2016-01-29Merge to XFA: Add tests for CBA_AnnotIterator.Tom Sepez
Original Review URL: https://codereview.chromium.org/1652533002 . (cherry picked from commit 1bce5f62f3292a6baf35491bf4c9b4fde2fb73e3) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1652543003 .
2016-01-29Add tests for CBA_AnnotIterator.Tom Sepez
I'm about to replace the sort() that underlies this class, so I first want to be sure I don't disrupt the order. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1652533002 .
2016-01-29Merge to XFA: Member function name refactoringWei Li
This is needed by Cl 1634373003 as the name collision with virtual functions will be shown as warnings on Linux. Also, it is better to use different names for different cases. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1644633003 . (cherry picked from commit d45e7a51904164fb22049f0a7a80d2a94c06936b) Review URL: https://codereview.chromium.org/1648233002 .
2016-01-29Merge to XFA: Roll DEPS for V8 to 43be969.Lei Zhang
BUG=581960 R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1648283003 . (cherry picked from commit b0b6373e685e0591fb47fe6cb90e767728241e7f) Review URL: https://codereview.chromium.org/1650553003 .
2016-01-29Roll DEPS for V8 to 43be969.Lei Zhang
BUG=581960 R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1648283003 .
2016-01-29Merge to XFA: Fix behaviour of app.alert() with a single object argument.Tom Sepez
Original Review URL: https://codereview.chromium.org/1641693003 . (cherry picked from commit 66519af52b61ca158044651d0507d47efb364f87) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1639253008 .
2016-01-29Fix behaviour of app.alert() with a single object argument.Tom Sepez
Centralize the "arguments in an object" logic. See the section "Method Arguments" in the js_api_reference.pdf. Add some tests to hit the ambiguous cases this section implies, and test that all parameters are passed end-to-end to our callbacks. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1641693003 .
2016-01-28Member function name refactoringWei Li
This is needed by Cl 1634373003 as the name collision with virtual functions will be shown as warnings on Linux. Also, it is better to use different names for different cases. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1644633003 .
2016-01-28Fix memory leakage on Linux - part3jinming_wang
BUG=pdfium:348 R=jochen@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1633083002 .
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-21 17:51:29 +0000